Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0030563 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Web POS | major | always | 2015-08-12 15:25 | 2015-10-01 13:11 | |||
Reporter | maite | View Status | public | |||||
Assigned To | fmolina | |||||||
Priority | urgent | Resolution | fixed | Fixed in Version | RR15Q4 | |||
Status | closed | Fix in branch | Fixed in SCM revision | e3b05d7e2a0a | ||||
Projection | none | ETA | none | Target Version | RR15Q4 | |||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | guilleaer | |||||||
OBNetwork customer | OBPS | |||||||
Support ticket | 37841 | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0030563: Loaded product characteristic values of products that are not in the webpos database. | |||||||
Description | When there are products in the assortment that does not have any price those products are not loaded to the WEBPOS database. But if those products have some characteristics their values are loaded. | |||||||
Steps To Reproduce | - In the backend, go to Basecamp lantern product and delete all its prices and check that it is included in the assortment. - Log in in a POS terminal and ensure that the basecamp lantern is not available. - Open the developer tools and check that its characteristics values are loaded even thought the product is not: select count(*) from m_product_ch_value where not exists (Select 1 from m_product where m_product.m_product_id = m_product_ch_value.m_product_id) | |||||||
Proposed Solution | The query that loads product characteristics values should properly filter the products, not only by the assortment. Notice that there are to java classes loading the M_Product_ch_values. ProductCharacteristic.java and ProductProductChValue.java (see issue 0030562) | |||||||
Tags | No tags attached. | |||||||
Attached Files | ![]() | |||||||
![]() |
||||||||
|
![]() |
|
(0080595) hgbot (developer) 2015-09-23 23:29 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 4b5d8f16f50195495382b52edec22a71b1b7ff60 Author: Facundo Molina <fmolina <at> koodu.es> Date: Wed Sep 23 18:26:29 2015 -0300 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4b5d8f16f50195495382b52edec22a71b1b7ff60 [^] Fixed issue 30563: Not load product characteristic of not loaded products --- M src/org/openbravo/retail/posterminal/master/ProductCharacteristicValue.java M web/org.openbravo.retail.posterminal/js/model/productcharacteristicvalue.js --- |
(0080740) guilleaer (viewer) 2015-09-30 11:26 |
You don't need to include in the subquery PricingPriceListVersion table. You can filter directly in Pricing product price using the price list version id. The format of the java file is not correct. Be careful. Attached a diff with propossed changes. |
(0080779) hgbot (developer) 2015-10-01 12:56 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: e3b05d7e2a0ab32c9ad1f6499391dffd37548df8 Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Thu Oct 01 10:46:40 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e3b05d7e2a0ab32c9ad1f6499391dffd37548df8 [^] fixed issue 30563: Improved query removing not needed table and some code format --- M src/org/openbravo/retail/posterminal/master/ProductCharacteristicValue.java --- |
![]() |
|||
Date Modified | Username | Field | Change |
2015-08-12 15:25 | maite | New Issue | |
2015-08-12 15:25 | maite | Assigned To | => Retail |
2015-08-12 15:25 | maite | OBNetwork customer | => Yes |
2015-08-12 15:25 | maite | Support ticket | => 37841 |
2015-08-12 15:25 | maite | Triggers an Emergency Pack | => No |
2015-08-12 15:26 | maite | Severity | major => critical |
2015-08-12 15:26 | maite | Issue Monitored: networkb | |
2015-08-13 08:51 | gorkaion | Proposed Solution updated | |
2015-08-13 08:52 | gorkaion | Relationship added | related to 0030562 |
2015-08-24 13:24 | maite | Resolution time | => 1442354400 |
2015-09-08 20:52 | fmolina | Status | new => scheduled |
2015-09-08 20:52 | fmolina | Assigned To | Retail => fmolina |
2015-09-23 23:29 | hgbot | Checkin | |
2015-09-23 23:29 | hgbot | Note Added: 0080595 | |
2015-09-23 23:29 | hgbot | Status | scheduled => resolved |
2015-09-23 23:29 | hgbot | Resolution | open => fixed |
2015-09-23 23:29 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4b5d8f16f50195495382b52edec22a71b1b7ff60 [^] |
2015-09-25 11:02 | Orekaria | Review Assigned To | => guilleaer |
2015-09-30 11:26 | guilleaer | Note Added: 0080740 | |
2015-09-30 11:26 | guilleaer | Status | resolved => new |
2015-09-30 11:26 | guilleaer | Resolution | fixed => open |
2015-09-30 11:27 | guilleaer | File Added: proposseddiff.diff | |
2015-09-30 18:07 | Orekaria | Target Version | RR15Q4 => RR16Q1 |
2015-09-30 18:15 | Orekaria | Target Version | RR16Q1 => RR15Q4 |
2015-10-01 12:56 | hgbot | Checkin | |
2015-10-01 12:56 | hgbot | Note Added: 0080779 | |
2015-10-01 12:56 | hgbot | Status | new => resolved |
2015-10-01 12:56 | hgbot | Resolution | open => fixed |
2015-10-01 12:56 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4b5d8f16f50195495382b52edec22a71b1b7ff60 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e3b05d7e2a0ab32c9ad1f6499391dffd37548df8 [^] |
2015-10-01 13:00 | marvintm | Severity | critical => major |
2015-10-01 13:11 | marvintm | Status | resolved => closed |
2015-10-01 13:11 | marvintm | Fixed in Version | => RR15Q4 |
Copyright © 2000 - 2009 MantisBT Group |