Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030563Retail ModulesWeb POSpublic2015-08-12 15:252015-10-01 13:11
Reportermaite 
Assigned Tofmolina 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q4Fixed in VersionRR15Q4 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerOBPS
Support ticket37841
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030563: Loaded product characteristic values of products that are not in the webpos database.
DescriptionWhen there are products in the assortment that does not have any price those products are not loaded to the WEBPOS database. But if those products have some
characteristics their values are loaded.
Steps To Reproduce- In the backend, go to Basecamp lantern product and delete all its prices and check that it is included in the assortment.
- Log in in a POS terminal and ensure that the basecamp lantern is not available.
- Open the developer tools and check that its characteristics values are loaded even thought the product is not:
select count(*) from m_product_ch_value where not exists (Select 1 from m_product
where m_product.m_product_id = m_product_ch_value.m_product_id)

Proposed SolutionThe query that loads product characteristics values should properly filter the
products, not only by the assortment.

Notice that there are to java classes loading the M_Product_ch_values. ProductCharacteristic.java and ProductProductChValue.java (see issue 0030562)
Additional Information
TagsNo tags attached.
Relationships
related to defect 0030562RR15Q4 closed Sandrahuguet Duplicated table with product characteristic values in local database. 
Attached Filesdiff proposseddiff.diff (2,191) 2015-09-30 11:27
https://issues.openbravo.com/file_download.php?file_id=8497&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-08-12 15:25maiteNew Issue
2015-08-12 15:25maiteAssigned To => Retail
2015-08-12 15:25maiteOBNetwork customer => Yes
2015-08-12 15:25maiteSupport ticket => 37841
2015-08-12 15:25maiteTriggers an Emergency Pack => No
2015-08-12 15:26maiteSeveritymajor => critical
2015-08-12 15:26maiteIssue Monitored: networkb
2015-08-13 08:51gorkaionProposed Solution updated
2015-08-13 08:52gorkaionRelationship addedrelated to 0030562
2015-08-24 13:24maiteResolution time => 1442354400
2015-09-08 20:52fmolinaStatusnew => scheduled
2015-09-08 20:52fmolinaAssigned ToRetail => fmolina
2015-09-23 23:29hgbotCheckin
2015-09-23 23:29hgbotNote Added: 0080595
2015-09-23 23:29hgbotStatusscheduled => resolved
2015-09-23 23:29hgbotResolutionopen => fixed
2015-09-23 23:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4b5d8f16f50195495382b52edec22a71b1b7ff60 [^]
2015-09-25 11:02OrekariaReview Assigned To => guilleaer
2015-09-30 11:26guilleaerNote Added: 0080740
2015-09-30 11:26guilleaerStatusresolved => new
2015-09-30 11:26guilleaerResolutionfixed => open
2015-09-30 11:27guilleaerFile Added: proposseddiff.diff
2015-09-30 18:07OrekariaTarget VersionRR15Q4 => RR16Q1
2015-09-30 18:15OrekariaTarget VersionRR16Q1 => RR15Q4
2015-10-01 12:56hgbotCheckin
2015-10-01 12:56hgbotNote Added: 0080779
2015-10-01 12:56hgbotStatusnew => resolved
2015-10-01 12:56hgbotResolutionopen => fixed
2015-10-01 12:56hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4b5d8f16f50195495382b52edec22a71b1b7ff60 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e3b05d7e2a0ab32c9ad1f6499391dffd37548df8 [^]
2015-10-01 13:00marvintmSeveritycritical => major
2015-10-01 13:11marvintmStatusresolved => closed
2015-10-01 13:11marvintmFixed in Version => RR15Q4

Notes
(0080595)
hgbot   
2015-09-23 23:29   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4b5d8f16f50195495382b52edec22a71b1b7ff60
Author: Facundo Molina <fmolina <at> koodu.es>
Date: Wed Sep 23 18:26:29 2015 -0300
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4b5d8f16f50195495382b52edec22a71b1b7ff60 [^]

Fixed issue 30563: Not load product characteristic of not loaded products

---
M src/org/openbravo/retail/posterminal/master/ProductCharacteristicValue.java
M web/org.openbravo.retail.posterminal/js/model/productcharacteristicvalue.js
---
(0080740)
guilleaer   
2015-09-30 11:26   
You don't need to include in the subquery PricingPriceListVersion table. You can filter directly in Pricing product price using the price list version id.

The format of the java file is not correct. Be careful.

Attached a diff with propossed changes.
(0080779)
hgbot   
2015-10-01 12:56   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e3b05d7e2a0ab32c9ad1f6499391dffd37548df8
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Oct 01 10:46:40 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e3b05d7e2a0ab32c9ad1f6499391dffd37548df8 [^]

fixed issue 30563: Improved query removing not needed table and some code format

---
M src/org/openbravo/retail/posterminal/master/ProductCharacteristicValue.java
---