Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0030548
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Retail Modules] Web POSmajoralways2015-08-11 13:182015-09-11 09:28
ReporterOrekariaView Statuspublic 
Assigned ToOrekaria 
PriorityhighResolutionfixedFixed in VersionRR15Q4
StatusclosedFix in branchFixed in SCM revision12585560c5ab
ProjectionnoneETAnoneTarget VersionRR15Q4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0030548: Stabilization: A 'callback(me)' is executed in 'OB.UTIL.saveComposeInfo'

DescriptionA 'callback(me)' is executed in 'OB.UTIL.saveComposeInfo'

The callback is executed and sent to the children instead of just being sent
This action breaks the standard way across the application, which is, execute the callback in the children, (the reason why it is called callback)
Steps To ReproduceA 'callback(me)' is executed in 'OB.UTIL.saveComposeInfo'

Verify the flows in which this code is executed:
- in the login
- finishing a sale
- performing a cashup

Verify the consequences of the callback being executed in the calling
Proposed SolutionChange the code to this, and check if flows are correct:

instead of:
  ... , callback(me), ...

set it to:
  ... , callback, ...

or

  ... , function () { callback(me)}, ...

TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0030603RR15Q4 closedOrekaria Stabilization: RR15Q4 related issues 

-  Notes
(0079612)
hgbot (developer)
2015-08-22 20:35

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 12585560c5abf73f76f7f27584e468faf4390d8b
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Sat Aug 22 20:32:56 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/12585560c5abf73f76f7f27584e468faf4390d8b [^]

Fixes issue 30548: The callback is passed as usual

- The problem is that the callback is intended to be exectuted at the end of the flow and this was executed before calling the saveInTransaction method

---
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---

- Issue History
Date Modified Username Field Change
2015-08-11 13:18 Orekaria New Issue
2015-08-11 13:18 Orekaria Assigned To => Retail
2015-08-11 13:18 Orekaria Triggers an Emergency Pack => No
2015-08-19 09:32 Orekaria Proposed Solution updated
2015-08-19 09:42 Orekaria Proposed Solution updated
2015-08-19 12:33 Orekaria Relationship added blocks 0030603
2015-08-19 12:43 Orekaria Type defect => design defect
2015-08-19 18:15 Orekaria Proposed Solution updated
2015-08-19 18:34 Orekaria Target Version => RR15Q4
2015-08-19 18:34 Orekaria Summary A 'callback(me)' is executed in 'OB.UTIL.saveComposeInfo' => Stabilization: A 'callback(me)' is executed in 'OB.UTIL.saveComposeInfo'
2015-08-22 20:35 hgbot Checkin
2015-08-22 20:35 hgbot Note Added: 0079612
2015-08-22 20:35 hgbot Status new => resolved
2015-08-22 20:35 hgbot Resolution open => fixed
2015-08-22 20:35 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/12585560c5abf73f76f7f27584e468faf4390d8b [^]
2015-08-31 09:18 marvintm Assigned To Retail => Orekaria
2015-09-11 09:28 marvintm Review Assigned To => marvintm
2015-09-11 09:28 marvintm Status resolved => closed
2015-09-11 09:28 marvintm Fixed in Version => RR15Q4


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker