Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030548Retail ModulesWeb POSpublic2015-08-11 13:182015-09-11 09:28
ReporterOrekaria 
Assigned ToOrekaria 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q4Fixed in VersionRR15Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030548: Stabilization: A 'callback(me)' is executed in 'OB.UTIL.saveComposeInfo'
DescriptionA 'callback(me)' is executed in 'OB.UTIL.saveComposeInfo'

The callback is executed and sent to the children instead of just being sent
This action breaks the standard way across the application, which is, execute the callback in the children, (the reason why it is called callback)
Steps To ReproduceA 'callback(me)' is executed in 'OB.UTIL.saveComposeInfo'

Verify the flows in which this code is executed:
- in the login
- finishing a sale
- performing a cashup

Verify the consequences of the callback being executed in the calling
Proposed SolutionChange the code to this, and check if flows are correct:

instead of:
  ... , callback(me), ...

set it to:
  ... , callback, ...

or

  ... , function () { callback(me)}, ...

Additional Information
TagsNo tags attached.
Relationships
blocks defect 0030603RR15Q4 closed Orekaria Stabilization: RR15Q4 related issues 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-08-11 13:18OrekariaNew Issue
2015-08-11 13:18OrekariaAssigned To => Retail
2015-08-11 13:18OrekariaTriggers an Emergency Pack => No
2015-08-19 09:32OrekariaProposed Solution updated
2015-08-19 09:42OrekariaProposed Solution updated
2015-08-19 12:33OrekariaRelationship addedblocks 0030603
2015-08-19 12:43OrekariaTypedefect => design defect
2015-08-19 18:15OrekariaProposed Solution updated
2015-08-19 18:34OrekariaTarget Version => RR15Q4
2015-08-19 18:34OrekariaSummaryA 'callback(me)' is executed in 'OB.UTIL.saveComposeInfo' => Stabilization: A 'callback(me)' is executed in 'OB.UTIL.saveComposeInfo'
2015-08-22 20:35hgbotCheckin
2015-08-22 20:35hgbotNote Added: 0079612
2015-08-22 20:35hgbotStatusnew => resolved
2015-08-22 20:35hgbotResolutionopen => fixed
2015-08-22 20:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/12585560c5abf73f76f7f27584e468faf4390d8b [^]
2015-08-31 09:18marvintmAssigned ToRetail => Orekaria
2015-09-11 09:28marvintmReview Assigned To => marvintm
2015-09-11 09:28marvintmStatusresolved => closed
2015-09-11 09:28marvintmFixed in Version => RR15Q4

Notes
(0079612)
hgbot   
2015-08-22 20:35   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 12585560c5abf73f76f7f27584e468faf4390d8b
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Sat Aug 22 20:32:56 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/12585560c5abf73f76f7f27584e468faf4390d8b [^]

Fixes issue 30548: The callback is passed as usual

- The problem is that the callback is intended to be exectuted at the end of the flow and this was executed before calling the saveInTransaction method

---
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---