Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0030501
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorrandom2015-08-05 10:062016-01-27 18:59
ReporteraaroncaleroView Statuspublic 
Assigned Tomarvintm 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionb4ebac097335
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0030501: Wrong tax calculation the pricelist does not include taxes.

DescriptionWhen the pricelist is checked as not including taxes, sometimes the tax amount is wrongly calculated
Steps To ReproduceCreate a ticket.
Add products:
*Avalanche transceiver (net: 150.5; gross 182.11)
*Headlamp ultralight (net: 18.9; gross: 22.87)
Verify that the total of the ticket is 204.98
Go to the menu, and tap on return this receipt.
Verify that the total of the ticket is NOT -204.98 (check attached screenshots)
Proposed SolutionSee:
https://code.openbravo.com/erp/pmods-branches/org.openbravo.retail.posterminal-but-dev/rev/78806e25f58a [^]
https://code.openbravo.com/erp/pmods-branches/org.openbravo.retail.posterminal-but-dev/rev/550b27ea23f5 [^]
TagsNo tags attached.
Attached Filespng file icon wrong_tax(1).png [^] (255,820 bytes) 2015-08-05 10:06


png file icon wrong_tax(2).png [^] (330,822 bytes) 2015-08-05 10:06

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on defect 0030742RR15Q4 closedOrekaria Error when finishing a sale with total price 0 
depends on defect 0030771RR16Q1 closedjorge-garcia CalculateTaxes should not be executed when the receipt is being closed 
related to defect 0030422pi closedRetail Cannot return receipt with pricelist including taxes, when the ticket has more than one line 

-  Notes
(0079392)
hgbot (developer)
2015-08-17 13:58

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6f943cc34f9f11f8779b6a920b444f2d7005e52a
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Aug 17 13:57:06 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6f943cc34f9f11f8779b6a920b444f2d7005e52a [^]

Fixes issue 030501: Wrong tax calculation the pricelist does not include taxes.
* This modification avoids to execute calculateGross() several times (one per line) when returning a receipt. Now calculateGross() is executed only once at the end of doing all the changes to return the receipt. This avoids calculateGross() and for instance calculateTaxes() to be reentrant due the asynchronous nature of calculateGross() and calculateTaxes.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0079397)
hgbot (developer)
2015-08-17 19:46

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f38254959f802e1f2e88fc27da50e218abb66b40
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Mon Aug 17 19:43:52 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f38254959f802e1f2e88fc27da50e218abb66b40 [^]

Backed out changeset: 6f943cc34f9f, issue 30501. Continuous integration failing

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0079687)
hgbot (developer)
2015-08-25 11:30

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2577d4fbb54c568174679f16c2d8c4b575e45884
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Tue Aug 25 10:23:57 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2577d4fbb54c568174679f16c2d8c4b575e45884 [^]

Related to issue 30501 and issue 30466: Errors in the taxes calculation are shown in the console

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
(0079760)
hgbot (developer)
2015-08-26 16:37

 Repository: tools/automation/pi-mobile
Changeset: 2aed07833bd971e47711a16e6ea09b268b6ff1b3
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Wed Aug 26 16:36:06 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2aed07833bd971e47711a16e6ea09b268b6ff1b3 [^]

Related to issue 30501: Added 'I30501_DivideBy0WhenReturnI' tests

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/I30501_DivideBy0WhenReturnI.java
---
(0080508)
hgbot (developer)
2015-09-19 13:05

 Repository: tools/automation/pi-mobile
Changeset: b83be8d474fa743aee813a9757b25ab45fd1cb4a
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Sat Sep 19 13:04:58 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b83be8d474fa743aee813a9757b25ab45fd1cb4a [^]

Verifies issue 30501: Added the 'I30501_WrongReturnAmount' test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/I30501_WrongReturnAmount.java
---
(0083553)
hgbot (developer)
2016-01-22 11:47

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b4ebac09733556a930ab85ffe5b2b09ea8ec87c0
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Aug 17 13:57:06 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b4ebac09733556a930ab85ffe5b2b09ea8ec87c0 [^]

Fixes issue 030501: Wrong tax calculation the pricelist does not include taxes.
* This modification avoids to execute calculateGross() several times (one per line) when returning a receipt. Now calculateGross() is executed only once at the end of doing all the changes to return the receipt. This avoids calculateGross() and for instance calculateTaxes() to be reentrant due the asynchronous nature of calculateGross() and calculateTaxes.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---

- Issue History
Date Modified Username Field Change
2015-08-05 10:06 aaroncalero New Issue
2015-08-05 10:06 aaroncalero Assigned To => Retail
2015-08-05 10:06 aaroncalero File Added: wrong_tax(1).png
2015-08-05 10:06 aaroncalero Triggers an Emergency Pack => No
2015-08-05 10:06 aaroncalero File Added: wrong_tax(2).png
2015-08-17 10:40 adrianromero Assigned To Retail => adrianromero
2015-08-17 13:58 hgbot Checkin
2015-08-17 13:58 hgbot Note Added: 0079392
2015-08-17 13:58 hgbot Status new => resolved
2015-08-17 13:58 hgbot Resolution open => fixed
2015-08-17 13:58 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6f943cc34f9f11f8779b6a920b444f2d7005e52a [^]
2015-08-17 14:01 adrianromero Review Assigned To => marvintm
2015-08-17 18:47 Osmany Relationship added related to 0030422
2015-08-17 19:46 hgbot Checkin
2015-08-17 19:46 hgbot Note Added: 0079397
2015-08-17 19:49 Orekaria Status resolved => new
2015-08-17 19:49 Orekaria Resolution fixed => open
2015-08-25 11:30 hgbot Checkin
2015-08-25 11:30 hgbot Note Added: 0079687
2015-08-26 16:37 hgbot Checkin
2015-08-26 16:37 hgbot Note Added: 0079760
2015-09-01 14:26 adrianromero Assigned To adrianromero => marvintm
2015-09-01 14:26 adrianromero Proposed Solution updated
2015-09-19 10:35 Orekaria Relationship added depends on 0030742
2015-09-19 11:14 Orekaria Relationship added depends on 0030771
2015-09-19 13:05 hgbot Checkin
2015-09-19 13:05 hgbot Note Added: 0080508
2016-01-22 11:47 hgbot Checkin
2016-01-22 11:47 hgbot Note Added: 0083553
2016-01-22 11:47 hgbot Status new => resolved
2016-01-22 11:47 hgbot Resolution open => fixed
2016-01-22 11:47 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6f943cc34f9f11f8779b6a920b444f2d7005e52a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b4ebac09733556a930ab85ffe5b2b09ea8ec87c0 [^]
2016-01-27 18:59 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker