Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030501Retail ModulesWeb POSpublic2015-08-05 10:062016-01-27 18:59
Reporteraaroncalero 
Assigned Tomarvintm 
PrioritynormalSeveritymajorReproducibilityrandom
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030501: Wrong tax calculation the pricelist does not include taxes.
DescriptionWhen the pricelist is checked as not including taxes, sometimes the tax amount is wrongly calculated
Steps To ReproduceCreate a ticket.
Add products:
*Avalanche transceiver (net: 150.5; gross 182.11)
*Headlamp ultralight (net: 18.9; gross: 22.87)
Verify that the total of the ticket is 204.98
Go to the menu, and tap on return this receipt.
Verify that the total of the ticket is NOT -204.98 (check attached screenshots)
Proposed SolutionSee:
https://code.openbravo.com/erp/pmods-branches/org.openbravo.retail.posterminal-but-dev/rev/78806e25f58a [^]
https://code.openbravo.com/erp/pmods-branches/org.openbravo.retail.posterminal-but-dev/rev/550b27ea23f5 [^]
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0030742RR15Q4 closed Orekaria Error when finishing a sale with total price 0 
depends on defect 0030771RR16Q1 closed jorge-garcia CalculateTaxes should not be executed when the receipt is being closed 
related to defect 0030422pi closed Retail Cannot return receipt with pricelist including taxes, when the ticket has more than one line 
Attached Filespng wrong_tax(1).png (255,820) 2015-08-05 10:06
https://issues.openbravo.com/file_download.php?file_id=8344&type=bug
png

png wrong_tax(2).png (330,822) 2015-08-05 10:06
https://issues.openbravo.com/file_download.php?file_id=8345&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-08-05 10:06aaroncaleroNew Issue
2015-08-05 10:06aaroncaleroAssigned To => Retail
2015-08-05 10:06aaroncaleroFile Added: wrong_tax(1).png
2015-08-05 10:06aaroncaleroTriggers an Emergency Pack => No
2015-08-05 10:06aaroncaleroFile Added: wrong_tax(2).png
2015-08-17 10:40adrianromeroAssigned ToRetail => adrianromero
2015-08-17 13:58hgbotCheckin
2015-08-17 13:58hgbotNote Added: 0079392
2015-08-17 13:58hgbotStatusnew => resolved
2015-08-17 13:58hgbotResolutionopen => fixed
2015-08-17 13:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6f943cc34f9f11f8779b6a920b444f2d7005e52a [^]
2015-08-17 14:01adrianromeroReview Assigned To => marvintm
2015-08-17 18:47OsmanyRelationship addedrelated to 0030422
2015-08-17 19:46hgbotCheckin
2015-08-17 19:46hgbotNote Added: 0079397
2015-08-17 19:49OrekariaStatusresolved => new
2015-08-17 19:49OrekariaResolutionfixed => open
2015-08-25 11:30hgbotCheckin
2015-08-25 11:30hgbotNote Added: 0079687
2015-08-26 16:37hgbotCheckin
2015-08-26 16:37hgbotNote Added: 0079760
2015-09-01 14:26adrianromeroAssigned Toadrianromero => marvintm
2015-09-01 14:26adrianromeroProposed Solution updated
2015-09-19 10:35OrekariaRelationship addeddepends on 0030742
2015-09-19 11:14OrekariaRelationship addeddepends on 0030771
2015-09-19 13:05hgbotCheckin
2015-09-19 13:05hgbotNote Added: 0080508
2016-01-22 11:47hgbotCheckin
2016-01-22 11:47hgbotNote Added: 0083553
2016-01-22 11:47hgbotStatusnew => resolved
2016-01-22 11:47hgbotResolutionopen => fixed
2016-01-22 11:47hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6f943cc34f9f11f8779b6a920b444f2d7005e52a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b4ebac09733556a930ab85ffe5b2b09ea8ec87c0 [^]
2016-01-27 18:59marvintmStatusresolved => closed

Notes
(0079392)
hgbot   
2015-08-17 13:58   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6f943cc34f9f11f8779b6a920b444f2d7005e52a
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Aug 17 13:57:06 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6f943cc34f9f11f8779b6a920b444f2d7005e52a [^]

Fixes issue 030501: Wrong tax calculation the pricelist does not include taxes.
* This modification avoids to execute calculateGross() several times (one per line) when returning a receipt. Now calculateGross() is executed only once at the end of doing all the changes to return the receipt. This avoids calculateGross() and for instance calculateTaxes() to be reentrant due the asynchronous nature of calculateGross() and calculateTaxes.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0079397)
hgbot   
2015-08-17 19:46   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f38254959f802e1f2e88fc27da50e218abb66b40
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Mon Aug 17 19:43:52 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f38254959f802e1f2e88fc27da50e218abb66b40 [^]

Backed out changeset: 6f943cc34f9f, issue 30501. Continuous integration failing

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0079687)
hgbot   
2015-08-25 11:30   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2577d4fbb54c568174679f16c2d8c4b575e45884
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Tue Aug 25 10:23:57 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2577d4fbb54c568174679f16c2d8c4b575e45884 [^]

Related to issue 30501 and issue 30466: Errors in the taxes calculation are shown in the console

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
(0079760)
hgbot   
2015-08-26 16:37   
Repository: tools/automation/pi-mobile
Changeset: 2aed07833bd971e47711a16e6ea09b268b6ff1b3
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Wed Aug 26 16:36:06 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2aed07833bd971e47711a16e6ea09b268b6ff1b3 [^]

Related to issue 30501: Added 'I30501_DivideBy0WhenReturnI' tests

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/I30501_DivideBy0WhenReturnI.java
---
(0080508)
hgbot   
2015-09-19 13:05   
Repository: tools/automation/pi-mobile
Changeset: b83be8d474fa743aee813a9757b25ab45fd1cb4a
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Sat Sep 19 13:04:58 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b83be8d474fa743aee813a9757b25ab45fd1cb4a [^]

Verifies issue 30501: Added the 'I30501_WrongReturnAmount' test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/I30501_WrongReturnAmount.java
---
(0083553)
hgbot   
2016-01-22 11:47   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b4ebac09733556a930ab85ffe5b2b09ea8ec87c0
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Aug 17 13:57:06 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b4ebac09733556a930ab85ffe5b2b09ea8ec87c0 [^]

Fixes issue 030501: Wrong tax calculation the pricelist does not include taxes.
* This modification avoids to execute calculateGross() several times (one per line) when returning a receipt. Now calculateGross() is executed only once at the end of doing all the changes to return the receipt. This avoids calculateGross() and for instance calculateTaxes() to be reentrant due the asynchronous nature of calculateGross() and calculateTaxes.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---