Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0030471 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] 04. Warehouse management | major | always | 2015-07-31 12:27 | 2015-08-20 23:16 | |||
Reporter | umartirena | View Status | public | |||||
Assigned To | AtulOpenbravo | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | 603caa01cb42 | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | vmromanos | |||||||
OBNetwork customer | No | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Support ticket | ||||||||
Regression level | Production - Confirmed Stable | |||||||
Regression date | 2014-06-16 | |||||||
Regression introduced in release | 3.0PR15Q1 | |||||||
Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/05f152469a6a [^] | |||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0030471: Return from Customer Pick&Edit Lines allows to enter more quantity to return than the pending to be returned | |||||||
Description | Return from Customer Pick&Edit Lines allows to enter more quantity to return than the pending to be returned. This happens because the "Returned Quantity other RM" field is showing negative values instead of positive, so this makes the validation on Returned field to perform wrongly. There is another issue in the pick&edit probably related to the same problem. It shows shipment lines fully returned, when they should not appear. | |||||||
Steps To Reproduce | As F&B Group Admin: * Go to Sales Order window and create a Sales Order with a product with stock for quantity 5. * Go to Create Shipments from Orders and create the shipment from the previous Sales Order. * Go to Return from Customer Window and create a header for the same Business Partner as previous Order/Shipment. * Click on Pick&Edit Lines and select the previous shipment line. Set Returned 3. CLick Done. * Book the document. * Create a new header of Return from Customer. * Click again on Pick&Edit Lines. Realize that the previous shipment line appears with -3 on Returned Quantity other RM field, what is wrong because it should be 3. * Check also that it allows to enter a value on Returned field between 0 and 8. when it should be between 0 and 2. * At least, if you put a value greater than 3 it will not allow to book the document, it will throw an error. | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
![]() |
|||||||||||||||
|
![]() |
|
(0079167) AtulOpenbravo (viewer) 2015-08-04 06:01 edited on: 2015-08-04 06:04 |
Test Plan - Login as F&B Group International Admin. - Go to Sales Order window and create a Sales Order with a product with stock for quantity 5. - Go to Create Shipments from Orders and create the shipment from the previous Sales Order. - Go to Return from Customer Window and create a header for the same Business Partner as previous Order/Shipment. - Click on Pick & Edit Lines and select the previous shipment line. Set Returned as 3 and click Done. Book the document. - Create a new header of Return from Customer. Click again on Pick&Edit Lines. Realize that the previous shipment line appears with 3 on Returned Quantity other RM field. Check that it allows to enter a value on Returned field between 0 and 2. Put a value greater than 2 it will not allow to book the document, it will throw an error. Alternative Test Plan - Go to Purchase Order window and create a Purchase Order with a product with Qty 5. - Go to Pending Goods Receipt and create the it for previous Purchase Order. - Go to Return To Vendor Window and create a header for the same Business Partner as previous Order/Receipt. - Click on Pick & Edit Lines and select the previous Receipt line. Set Returned as 3 and click Done. Book the document. - Create a new header of Return To Vendor. Click again on Pick&Edit Lines. Realize that the previous receipt line appears with 3 on Returned Quantity other RM field. Check that it allows to enter a value on Returned field between 0 and 2. Put a value greater than 2 it will not allow to book the document, it will throw an error. |
(0079174) hgbot (developer) 2015-08-04 12:02 |
Repository: erp/devel/pi Changeset: 603caa01cb426466778e8c9048cf4b33cf206de1 Author: Atul Gaware <atul.gaware <at> openbravo.com> Date: Mon Aug 03 23:08:59 2015 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/603caa01cb426466778e8c9048cf4b33cf206de1 [^] Fixes Issue 30471: Return from Customer Pick&Edit Lines allows to enter more quantity to return than the pending to be returned Return document has negative movementqty so ReturnQtyOtherRM was negative. It should be postive so unlike ReturnQty it is multiplied with -1 as in prev Datasource prior to transforming it to HQL PE. Where clause which checks MovementQty of shipment line with the ReturnQtyOtherRM was missing. Sum of Shipmentline MovementQty and ReturnQtyOtherRM should not be zero. It is added to fix the problem. --- M src-db/database/sourcedata/AD_TABLE.xml --- |
(0079175) vmromanos (viewer) 2015-08-04 12:02 |
Code review + testing OK Tested in both Oracle and PostgreSQL |
(0079519) hudsonbot (viewer) 2015-08-20 23:16 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8c91718397a5 [^] Maturity status: Test |
![]() |
|||
Date Modified | Username | Field | Change |
2015-07-31 12:27 | umartirena | New Issue | |
2015-07-31 12:27 | umartirena | Assigned To | => Triage Finance |
2015-07-31 12:27 | umartirena | OBNetwork customer | => No |
2015-07-31 12:27 | umartirena | Modules | => Core |
2015-07-31 12:27 | umartirena | Triggers an Emergency Pack | => No |
2015-08-03 12:36 | AtulOpenbravo | Assigned To | Triage Finance => AtulOpenbravo |
2015-08-03 12:37 | AtulOpenbravo | Status | new => scheduled |
2015-08-04 06:01 | AtulOpenbravo | Note Added: 0079167 | |
2015-08-04 06:04 | AtulOpenbravo | Note Edited: 0079167 | View Revisions |
2015-08-04 09:43 | AtulOpenbravo | Regression date | => 2014-06-16 |
2015-08-04 09:43 | AtulOpenbravo | Regression introduced by commit | => https://code.openbravo.com/erp/devel/pi/rev/05f152469a6a [^] |
2015-08-04 10:21 | AtulOpenbravo | Status | scheduled => acknowledged |
2015-08-04 10:25 | AtulOpenbravo | Status | acknowledged => scheduled |
2015-08-04 10:29 | AtulOpenbravo | Regression level | => Production - Confirmed Stable |
2015-08-04 10:29 | AtulOpenbravo | Regression introduced in release | => 3.0PR15Q1 |
2015-08-04 12:02 | hgbot | Checkin | |
2015-08-04 12:02 | hgbot | Note Added: 0079174 | |
2015-08-04 12:02 | hgbot | Status | scheduled => resolved |
2015-08-04 12:02 | hgbot | Resolution | open => fixed |
2015-08-04 12:02 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/603caa01cb426466778e8c9048cf4b33cf206de1 [^] |
2015-08-04 12:02 | vmromanos | Review Assigned To | => vmromanos |
2015-08-04 12:02 | vmromanos | Note Added: 0079175 | |
2015-08-04 12:02 | vmromanos | Status | resolved => closed |
2015-08-20 23:16 | hudsonbot | Checkin | |
2015-08-20 23:16 | hudsonbot | Note Added: 0079519 |
Copyright © 2000 - 2009 MantisBT Group |