Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0030384
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] 09. Financial managementtrivialN/A2015-07-17 09:052015-09-15 15:56
ReportervmromanosView Statuspublic 
Assigned ToAtulOpenbravo 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision023d06d04ece
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Todmiguelez
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0030384: Create a JUnit test for AD_ISORGINCLUDED function

DescriptionThe AD_ISORGINCLUDED is going to be modified to improve its performance. Before doing this change, we need to be sure we don't enter any regression.

So, it's necessary to create a JUnit test (OBBaseTest) that covers every possible scenario for this function: distinct orgs in the same branch with different levels, in different branches (not included), swapping parent/child order, mixing with organizations of different clients, passing the same organization, organization id that doesn't exist, etc.

The test should be included in src-test folder
Steps To ReproduceNA
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0079029)
shuehner (administrator)
2015-07-22 14:45

Note: especially for the case of 'id's that do not exist' maybe interesting to define what is intended behavior.
I.e. does it matter to get exact same current behavior?
Or does it not (for that case)
(0080387)
hgbot (developer)
2015-09-14 18:05

Repository: erp/devel/pi
Changeset: 023d06d04ececed8a71ca546bfa150d3471f9e48
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Jul 27 15:09:29 2015 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/023d06d04ececed8a71ca546bfa150d3471f9e48 [^]

Fixes Issue 30384:Junit test cases for AD_ORGISINCLUDED db function

Junit test handles following cases:
* Case I: Distinct Organization in the same branch with different levels.
* Case II: Distinct Organization in the different branch with different levels.
* Case III: Swap parent/child order
* Case IV: Organization with different clients
* Case V: Same Organization
* Case VI: Organization that does not exists.

---
A src-test/src/org/openbravo/test/db/model/functions/Ad_isorgincludedTest.java
---
(0080388)
dmiguelez (developer)
2015-09-14 18:08

Code Review + Testing Ok
(0080406)
hudsonbot (developer)
2015-09-15 15:56

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/27462487da9b [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-07-17 09:05 vmromanos New Issue
2015-07-17 09:05 vmromanos Assigned To => Triage Finance
2015-07-17 09:05 vmromanos Modules => Core
2015-07-17 09:05 vmromanos Triggers an Emergency Pack => No
2015-07-22 10:29 AtulOpenbravo Assigned To Triage Finance => AtulOpenbravo
2015-07-22 10:29 AtulOpenbravo Status new => scheduled
2015-07-22 14:45 shuehner Note Added: 0079029
2015-07-22 14:45 shuehner Issue Monitored: shuehner
2015-09-14 18:05 hgbot Checkin
2015-09-14 18:05 hgbot Note Added: 0080387
2015-09-14 18:05 hgbot Status scheduled => resolved
2015-09-14 18:05 hgbot Resolution open => fixed
2015-09-14 18:05 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/023d06d04ececed8a71ca546bfa150d3471f9e48 [^]
2015-09-14 18:08 dmiguelez Review Assigned To => dmiguelez
2015-09-14 18:08 dmiguelez Note Added: 0080388
2015-09-14 18:08 dmiguelez Status resolved => closed
2015-09-15 15:56 hudsonbot Checkin
2015-09-15 15:56 hudsonbot Note Added: 0080406


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker