Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030384Openbravo ERP09. Financial managementpublic2015-07-17 09:052015-09-15 15:56
Reportervmromanos 
Assigned ToAtulOpenbravo 
PrioritynormalSeveritytrivialReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030384: Create a JUnit test for AD_ISORGINCLUDED function
DescriptionThe AD_ISORGINCLUDED is going to be modified to improve its performance. Before doing this change, we need to be sure we don't enter any regression.

So, it's necessary to create a JUnit test (OBBaseTest) that covers every possible scenario for this function: distinct orgs in the same branch with different levels, in different branches (not included), swapping parent/child order, mixing with organizations of different clients, passing the same organization, organization id that doesn't exist, etc.

The test should be included in src-test folder
Steps To ReproduceNA
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-07-17 09:05vmromanosNew Issue
2015-07-17 09:05vmromanosAssigned To => Triage Finance
2015-07-17 09:05vmromanosModules => Core
2015-07-17 09:05vmromanosTriggers an Emergency Pack => No
2015-07-22 10:29AtulOpenbravoAssigned ToTriage Finance => AtulOpenbravo
2015-07-22 10:29AtulOpenbravoStatusnew => scheduled
2015-07-22 14:45shuehnerNote Added: 0079029
2015-07-22 14:45shuehnerIssue Monitored: shuehner
2015-09-14 18:05hgbotCheckin
2015-09-14 18:05hgbotNote Added: 0080387
2015-09-14 18:05hgbotStatusscheduled => resolved
2015-09-14 18:05hgbotResolutionopen => fixed
2015-09-14 18:05hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/023d06d04ececed8a71ca546bfa150d3471f9e48 [^]
2015-09-14 18:08dmiguelezReview Assigned To => dmiguelez
2015-09-14 18:08dmiguelezNote Added: 0080388
2015-09-14 18:08dmiguelezStatusresolved => closed
2015-09-15 15:56hudsonbotCheckin
2015-09-15 15:56hudsonbotNote Added: 0080406

Notes
(0079029)
shuehner   
2015-07-22 14:45   
Note: especially for the case of 'id's that do not exist' maybe interesting to define what is intended behavior.
I.e. does it matter to get exact same current behavior?
Or does it not (for that case)
(0080387)
hgbot   
2015-09-14 18:05   
Repository: erp/devel/pi
Changeset: 023d06d04ececed8a71ca546bfa150d3471f9e48
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Jul 27 15:09:29 2015 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/023d06d04ececed8a71ca546bfa150d3471f9e48 [^]

Fixes Issue 30384:Junit test cases for AD_ORGISINCLUDED db function

Junit test handles following cases:
* Case I: Distinct Organization in the same branch with different levels.
* Case II: Distinct Organization in the different branch with different levels.
* Case III: Swap parent/child order
* Case IV: Organization with different clients
* Case V: Same Organization
* Case VI: Organization that does not exists.

---
A src-test/src/org/openbravo/test/db/model/functions/Ad_isorgincludedTest.java
---
(0080388)
dmiguelez   
2015-09-14 18:08   
Code Review + Testing Ok
(0080406)
hudsonbot   
2015-09-15 15:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/27462487da9b [^]
Maturity status: Test