Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0030349 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Offline Mode | minor | always | 2015-07-14 11:08 | 2016-02-01 08:59 | |||
| Reporter | plujan | View Status | public | |||||
| Assigned To | migueldejuana | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | RR15Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 981b4f96cb1e | ||||
| Projection | none | ETA | none | Target Version | RR15Q4 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | main | SCM revision | ||||||
| Review Assigned To | mtaal | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0030349: A red icon indicating data not synchronised is shown even if nothing needs to be synchronised | |||||||
| Description | When using the front end in offline mode, a small red icon on the to left corner and a menu entry about data pending to synchronise is shown even if there is no actual data pending to synchronise. See steps. | |||||||
| Steps To Reproduce | 1. Start in online mode (network connected) by logging in as vallblanca user 2. Create a new ticket for a backpack. 3. Pay it to close the ticket. Check the blue icon shown while synchronising and that the icon disappears when the data has been synchronised. 4. Logout and unplug the network cable to go offline. Log in again as vallblanca user 5. Check that now a red icon is shown and a new menu entry "Pending Sync." was added. 6. Click that entry and see that there is no actual data to synchronise. See attached screenshot. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  OfflineTicket_3.png [^] (52,138 bytes) 2015-07-14 11:08
Selection_101.png [^] (82,490 bytes) 2015-08-30 07:20
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||||||||||||||||
|
|||||||||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0078820) migueldejuana (developer) 2015-07-15 16:30 |
It also happens in RR15Q2. |
|
(0078822) hgbot (developer) 2015-07-15 16:34 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 567c0d9f5dd936456372bfb55df7a0deb2445486 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Wed Jul 15 16:34:16 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/567c0d9f5dd936456372bfb55df7a0deb2445486 [^] Fixed issue 0030349: [RR15Q3] A red icon indicating data not synchronised is shown even if nothing needs to be synchronised When a synchronization of a model returns error callback, we need to be sure that there aren't items to synch before showing red icon. Actual cashup is synchronized in the login but we do not take into account this cashup. Red icon tells that we have something pending to synchronize and if we clean cache, we could loose information. --- M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js --- |
|
(0079036) hgbot (developer) 2015-07-23 09:03 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 2406debac222185162be55ba99739300a2a092fa Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Thu Jul 16 15:17:01 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2406debac222185162be55ba99739300a2a092fa [^] Fixed issue 0030349: [RR15Q3] A red icon indicating data not synchronised is shown even if nothing needs to be synchronised and HGVOL fix When a synchronization of a model returns error callback, we need to be sure that there aren't items to synch before showing red icon. Actual cashup is synchronized in the login but we do not take into account this cashup. Red icon tells that we have something pending to synchronize and if we clean cache, we could loose information. HGVOL fix: When we finish iterating all servers(after iterating offline server) we call to fail callback --- M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js --- |
|
(0079816) mtaal (manager) 2015-08-30 07:21 |
Hi, I tested the flow but with me the sync button shows up and the items to sync shows a cashup. But in the resolution text above it is stated that the cashup sync at login should not be taken into account? gr. Martin |
|
(0079905) migueldejuana (developer) 2015-08-31 14:51 |
Now, we have messages to syncronize and so far, there is no way to know if that cashup has info to synchronize in the backend. So we need to take into account and show when we login offline. |
|
(0079990) mtaal (manager) 2015-09-01 12:48 |
Revisit this topic to see if we can make a distinction between data syncs/messages which can be ignored when the server is not there. The cashup messages when logging can in some cases be ignored (if isProcess is not true on the cashup for example). An idea: the call to the request router should have an extra parameter: dropMessageOnFailure. Default is false/not set. In specific cases a caller can set this to true when the message can be ignored if the server is not available. |
|
(0080028) hgbot (developer) 2015-09-02 18:57 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 38cbb8a34cb5a059ea4d44c1c8cdd08b5f58d468 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Wed Sep 02 16:41:11 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/38cbb8a34cb5a059ea4d44c1c8cdd08b5f58d468 [^] Fixed issue 0030349: [RR15Q3] A red icon indicating data not synchronised is shown even if nothing needs to be synchronised Do not execute runSyncProcess, we just need process all pending messages when doing Login --- M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js --- |
|
(0080030) hgbot (developer) 2015-09-02 21:48 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: da8422af57741473c3d48688bec5ecdc463d3431 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Wed Sep 02 21:48:33 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/da8422af57741473c3d48688bec5ecdc463d3431 [^] Fixed issue 0030349: [RR15Q3] A red icon indicating data not synchronised is shown even if nothing needs to be synchronised Do not execute runSyncProcess, we just need process all pending messages when doing Login --- M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js --- |
|
(0080256) hgbot (developer) 2015-09-09 08:52 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: aec8576b64ef56a46a9a0680c77c48f6636b21eb Author: Martin Taal <martin.taal <at> openbravo.com> Date: Tue Sep 08 18:33:00 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/aec8576b64ef56a46a9a0680c77c48f6636b21eb [^] Related to issue 30349: [RR15Q3] A red icon indicating data not synchronised is shown even if nothing needs to be synchronised Check if a model can be skipped for syncing, if so skip it --- M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js --- |
|
(0080260) hgbot (developer) 2015-09-09 08:53 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 83c54e62ffbf9717bac3deb178d817003a4f1c44 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Tue Sep 08 18:33:40 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/83c54e62ffbf9717bac3deb178d817003a4f1c44 [^] Fixes issue Related to issue 30349: [RR15Q3] A red icon indicating data not synchronised is shown even if nothing needs to be synchronised Skip cashup sync if it is the same as a previous cashup which is already synced --- M web/org.openbravo.retail.posterminal/js/login/model/login-model.js --- |
|
(0080268) mtaal (manager) 2015-09-09 10:16 edited on: 2015-09-09 10:17 |
Inadvertently resolved the issue, the q4 issue should be set to resolved |
|
(0080775) Orekaria (administrator) 2015-10-01 12:27 |
This issue has been closed due to the RR15Q4 freeze. The issue https://issues.openbravo.com/view.php?id=31004 [^] continue addressing the topic in the next release cycle, RR16Q1 |
|
(0083546) hgbot (developer) 2016-01-22 11:27 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 981b4f96cb1e838e1f5c85cda1d44b9a92ba8154 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Thu Jul 16 15:17:01 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/981b4f96cb1e838e1f5c85cda1d44b9a92ba8154 [^] Fixed issue 0030349: [RR15Q3] A red icon indicating data not synchronised is shown even if nothing needs to be synchronised and HGVOL fix When a synchronization of a model returns error callback, we need to be sure that there aren't items to synch before showing red icon. Actual cashup is synchronized in the login but we do not take into account this cashup. Red icon tells that we have something pending to synchronize and if we clean cache, we could loose information. HGVOL fix: When we finish iterating all servers(after iterating offline server) we call to fail callback --- M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js --- |
|
(0083763) mtaal (manager) 2016-02-01 08:59 |
Afaics it was unadvertently set to resolved from closed. Setting back to closed. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-07-14 11:08 | plujan | New Issue | |
| 2015-07-14 11:08 | plujan | Assigned To | => Retail |
| 2015-07-14 11:08 | plujan | File Added: OfflineTicket_3.png | |
| 2015-07-14 11:08 | plujan | Triggers an Emergency Pack | => No |
| 2015-07-15 16:29 | migueldejuana | Assigned To | Retail => migueldejuana |
| 2015-07-15 16:30 | migueldejuana | Note Added: 0078820 | |
| 2015-07-15 16:34 | hgbot | Checkin | |
| 2015-07-15 16:34 | hgbot | Note Added: 0078822 | |
| 2015-07-15 16:34 | hgbot | Status | new => resolved |
| 2015-07-15 16:34 | hgbot | Resolution | open => fixed |
| 2015-07-15 16:34 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/567c0d9f5dd936456372bfb55df7a0deb2445486 [^] |
| 2015-07-15 16:35 | migueldejuana | Review Assigned To | => marvintm |
| 2015-07-23 09:03 | hgbot | Checkin | |
| 2015-07-23 09:03 | hgbot | Note Added: 0079036 | |
| 2015-07-23 09:03 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/567c0d9f5dd936456372bfb55df7a0deb2445486 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2406debac222185162be55ba99739300a2a092fa [^] |
| 2015-08-12 12:56 | marvintm | Target Version | RR15Q3 => |
| 2015-08-12 12:56 | marvintm | Status | resolved => new |
| 2015-08-12 12:56 | marvintm | Resolution | fixed => open |
| 2015-08-12 12:56 | marvintm | Status | new => scheduled |
| 2015-08-12 12:56 | marvintm | Status | scheduled => resolved |
| 2015-08-12 12:56 | marvintm | Resolution | open => fixed |
| 2015-08-30 07:20 | mtaal | File Added: Selection_101.png | |
| 2015-08-30 07:20 | mtaal | Review Assigned To | marvintm => mtaal |
| 2015-08-30 07:21 | mtaal | Note Added: 0079816 | |
| 2015-08-31 14:51 | migueldejuana | Note Added: 0079905 | |
| 2015-09-01 12:48 | mtaal | Note Added: 0079990 | |
| 2015-09-01 12:48 | mtaal | Status | resolved => new |
| 2015-09-01 12:48 | mtaal | Resolution | fixed => open |
| 2015-09-02 18:57 | hgbot | Checkin | |
| 2015-09-02 18:57 | hgbot | Note Added: 0080028 | |
| 2015-09-02 18:57 | hgbot | Status | new => resolved |
| 2015-09-02 18:57 | hgbot | Resolution | open => fixed |
| 2015-09-02 18:57 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2406debac222185162be55ba99739300a2a092fa [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/38cbb8a34cb5a059ea4d44c1c8cdd08b5f58d468 [^] |
| 2015-09-02 21:48 | hgbot | Checkin | |
| 2015-09-02 21:48 | hgbot | Note Added: 0080030 | |
| 2015-09-02 21:48 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/38cbb8a34cb5a059ea4d44c1c8cdd08b5f58d468 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/da8422af57741473c3d48688bec5ecdc463d3431 [^] |
| 2015-09-03 10:01 | migueldejuana | Status | resolved => new |
| 2015-09-03 10:01 | migueldejuana | Resolution | fixed => open |
| 2015-09-09 08:52 | hgbot | Checkin | |
| 2015-09-09 08:52 | hgbot | Note Added: 0080256 | |
| 2015-09-09 08:53 | hgbot | Checkin | |
| 2015-09-09 08:53 | hgbot | Note Added: 0080260 | |
| 2015-09-09 10:10 | mtaal | Relationship added | blocks 0029912 |
| 2015-09-09 10:15 | mtaal | Status | new => scheduled |
| 2015-09-09 10:15 | mtaal | Status | scheduled => resolved |
| 2015-09-09 10:15 | mtaal | Fixed in Version | => RR15Q4 |
| 2015-09-09 10:15 | mtaal | Resolution | open => fixed |
| 2015-09-09 10:16 | mtaal | Note Added: 0080268 | |
| 2015-09-09 10:16 | mtaal | Status | resolved => new |
| 2015-09-09 10:16 | mtaal | Resolution | fixed => open |
| 2015-09-09 10:16 | mtaal | Fixed in Version | RR15Q4 => |
| 2015-09-09 10:17 | mtaal | Note Edited: 0080268 | View Revisions |
| 2015-09-30 21:15 | mtaal | Status | new => scheduled |
| 2015-09-30 21:15 | mtaal | Status | scheduled => resolved |
| 2015-09-30 21:15 | mtaal | Fixed in Version | => RR15Q4 |
| 2015-09-30 21:15 | mtaal | Resolution | open => fixed |
| 2015-09-30 21:15 | mtaal | Summary | [RR15Q3] A red icon indicating data not synchronised is shown even if nothing needs to be synchronised => A red icon indicating data not synchronised is shown even if nothing needs to be synchronised |
| 2015-10-01 11:51 | Orekaria | Target Version | => RR15Q4 |
| 2015-10-01 12:25 | Orekaria | Relationship added | blocks 0031004 |
| 2015-10-01 12:27 | Orekaria | Note Added: 0080775 | |
| 2015-10-01 12:27 | Orekaria | Status | resolved => closed |
| 2016-01-22 11:27 | hgbot | Checkin | |
| 2016-01-22 11:27 | hgbot | Note Added: 0083546 | |
| 2016-01-22 11:27 | hgbot | Status | closed => resolved |
| 2016-01-22 11:27 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/da8422af57741473c3d48688bec5ecdc463d3431 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/981b4f96cb1e838e1f5c85cda1d44b9a92ba8154 [^] |
| 2016-02-01 08:59 | mtaal | Note Added: 0083763 | |
| 2016-02-01 08:59 | mtaal | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |