Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030349Retail ModulesOffline Modepublic2015-07-14 11:082016-02-01 08:59
Reporterplujan 
Assigned Tomigueldejuana 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionRR15Q4Fixed in VersionRR15Q4 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030349: A red icon indicating data not synchronised is shown even if nothing needs to be synchronised
DescriptionWhen using the front end in offline mode, a small red icon on the to left corner and a menu entry about data pending to synchronise is shown even if there is no actual data pending to synchronise. See steps.
Steps To Reproduce1. Start in online mode (network connected) by logging in as vallblanca user
2. Create a new ticket for a backpack.
3. Pay it to close the ticket. Check the blue icon shown while synchronising and that the icon disappears when the data has been synchronised.
4. Logout and unplug the network cable to go offline. Log in again as vallblanca user
5. Check that now a red icon is shown and a new menu entry "Pending Sync." was added.
6. Click that entry and see that there is no actual data to synchronise. See attached screenshot.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0030559RR15Q3.1 closed migueldejuana [RR15Q3] A red icon indicating data not synchronised is shown even if nothing needs to be synchronised 
depends on defect 0030799RR15Q4 closed migueldejuana [RR15Q4] A red icon indicating data not synchronised is shown even if nothing needs to be synchronised 
blocks feature request 0029912 closed mtaal WebPOS Transparent Multi-Server Environments 
blocks defect 0031004RR16Q3 closed migueldejuana A red icon indicating data not synchronised is shown even if nothing needs to be synchronised 
Attached Filespng OfflineTicket_3.png (52,138) 2015-07-14 11:08
https://issues.openbravo.com/file_download.php?file_id=8276&type=bug
png

png Selection_101.png (82,490) 2015-08-30 07:20
https://issues.openbravo.com/file_download.php?file_id=8394&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2015-07-14 11:08plujanNew Issue
2015-07-14 11:08plujanAssigned To => Retail
2015-07-14 11:08plujanFile Added: OfflineTicket_3.png
2015-07-14 11:08plujanTriggers an Emergency Pack => No
2015-07-15 16:29migueldejuanaAssigned ToRetail => migueldejuana
2015-07-15 16:30migueldejuanaNote Added: 0078820
2015-07-15 16:34hgbotCheckin
2015-07-15 16:34hgbotNote Added: 0078822
2015-07-15 16:34hgbotStatusnew => resolved
2015-07-15 16:34hgbotResolutionopen => fixed
2015-07-15 16:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/567c0d9f5dd936456372bfb55df7a0deb2445486 [^]
2015-07-15 16:35migueldejuanaReview Assigned To => marvintm
2015-07-23 09:03hgbotCheckin
2015-07-23 09:03hgbotNote Added: 0079036
2015-07-23 09:03hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/567c0d9f5dd936456372bfb55df7a0deb2445486 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2406debac222185162be55ba99739300a2a092fa [^]
2015-08-12 12:56marvintmTarget VersionRR15Q3 =>
2015-08-12 12:56marvintmStatusresolved => new
2015-08-12 12:56marvintmResolutionfixed => open
2015-08-12 12:56marvintmStatusnew => scheduled
2015-08-12 12:56marvintmStatusscheduled => resolved
2015-08-12 12:56marvintmResolutionopen => fixed
2015-08-30 07:20mtaalFile Added: Selection_101.png
2015-08-30 07:20mtaalReview Assigned Tomarvintm => mtaal
2015-08-30 07:21mtaalNote Added: 0079816
2015-08-31 14:51migueldejuanaNote Added: 0079905
2015-09-01 12:48mtaalNote Added: 0079990
2015-09-01 12:48mtaalStatusresolved => new
2015-09-01 12:48mtaalResolutionfixed => open
2015-09-02 18:57hgbotCheckin
2015-09-02 18:57hgbotNote Added: 0080028
2015-09-02 18:57hgbotStatusnew => resolved
2015-09-02 18:57hgbotResolutionopen => fixed
2015-09-02 18:57hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2406debac222185162be55ba99739300a2a092fa [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/38cbb8a34cb5a059ea4d44c1c8cdd08b5f58d468 [^]
2015-09-02 21:48hgbotCheckin
2015-09-02 21:48hgbotNote Added: 0080030
2015-09-02 21:48hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/38cbb8a34cb5a059ea4d44c1c8cdd08b5f58d468 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/da8422af57741473c3d48688bec5ecdc463d3431 [^]
2015-09-03 10:01migueldejuanaStatusresolved => new
2015-09-03 10:01migueldejuanaResolutionfixed => open
2015-09-09 08:52hgbotCheckin
2015-09-09 08:52hgbotNote Added: 0080256
2015-09-09 08:53hgbotCheckin
2015-09-09 08:53hgbotNote Added: 0080260
2015-09-09 10:10mtaalRelationship addedblocks 0029912
2015-09-09 10:15mtaalStatusnew => scheduled
2015-09-09 10:15mtaalStatusscheduled => resolved
2015-09-09 10:15mtaalFixed in Version => RR15Q4
2015-09-09 10:15mtaalResolutionopen => fixed
2015-09-09 10:16mtaalNote Added: 0080268
2015-09-09 10:16mtaalStatusresolved => new
2015-09-09 10:16mtaalResolutionfixed => open
2015-09-09 10:16mtaalFixed in VersionRR15Q4 =>
2015-09-09 10:17mtaalNote Edited: 0080268bug_revision_view_page.php?bugnote_id=0080268#r9403
2015-09-30 21:15mtaalStatusnew => scheduled
2015-09-30 21:15mtaalStatusscheduled => resolved
2015-09-30 21:15mtaalFixed in Version => RR15Q4
2015-09-30 21:15mtaalResolutionopen => fixed
2015-09-30 21:15mtaalSummary[RR15Q3] A red icon indicating data not synchronised is shown even if nothing needs to be synchronised => A red icon indicating data not synchronised is shown even if nothing needs to be synchronised
2015-10-01 11:51OrekariaTarget Version => RR15Q4
2015-10-01 12:25OrekariaRelationship addedblocks 0031004
2015-10-01 12:27OrekariaNote Added: 0080775
2015-10-01 12:27OrekariaStatusresolved => closed
2016-01-22 11:27hgbotCheckin
2016-01-22 11:27hgbotNote Added: 0083546
2016-01-22 11:27hgbotStatusclosed => resolved
2016-01-22 11:27hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/da8422af57741473c3d48688bec5ecdc463d3431 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/981b4f96cb1e838e1f5c85cda1d44b9a92ba8154 [^]
2016-02-01 08:59mtaalNote Added: 0083763
2016-02-01 08:59mtaalStatusresolved => closed

Notes
(0078820)
migueldejuana   
2015-07-15 16:30   
It also happens in RR15Q2.
(0078822)
hgbot   
2015-07-15 16:34   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 567c0d9f5dd936456372bfb55df7a0deb2445486
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Jul 15 16:34:16 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/567c0d9f5dd936456372bfb55df7a0deb2445486 [^]

Fixed issue 0030349: [RR15Q3] A red icon indicating data not synchronised is shown even if nothing needs to be synchronised

When a synchronization of a model returns error callback, we need to be sure that there aren't items to synch before showing red icon.
Actual cashup is synchronized in the login but we do not take into account this cashup.
Red icon tells that we have something pending to synchronize and if we clean cache, we could loose information.

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0079036)
hgbot   
2015-07-23 09:03   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 2406debac222185162be55ba99739300a2a092fa
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jul 16 15:17:01 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2406debac222185162be55ba99739300a2a092fa [^]

Fixed issue 0030349: [RR15Q3] A red icon indicating data not synchronised is shown even if nothing needs to be synchronised and HGVOL fix

When a synchronization of a model returns error callback, we need to be sure that there aren't items to synch before showing red icon.
Actual cashup is synchronized in the login but we do not take into account this cashup.
Red icon tells that we have something pending to synchronize and if we clean cache, we could loose information.
HGVOL fix: When we finish iterating all servers(after iterating offline server) we call to fail callback

---
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
---
(0079816)
mtaal   
2015-08-30 07:21   
Hi,
I tested the flow but with me the sync button shows up and the items to sync shows a cashup. But in the resolution text above it is stated that the cashup sync at login should not be taken into account?

gr. Martin
(0079905)
migueldejuana   
2015-08-31 14:51   
Now, we have messages to syncronize and so far, there is no way to know if that cashup has info to synchronize in the backend. So we need to take into account and show when we login offline.
(0079990)
mtaal   
2015-09-01 12:48   
Revisit this topic to see if we can make a distinction between data syncs/messages which can be ignored when the server is not there.

The cashup messages when logging can in some cases be ignored (if isProcess is not true on the cashup for example).

An idea: the call to the request router should have an extra parameter: dropMessageOnFailure. Default is false/not set. In specific cases a caller can set this to true when the message can be ignored if the server is not available.
(0080028)
hgbot   
2015-09-02 18:57   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 38cbb8a34cb5a059ea4d44c1c8cdd08b5f58d468
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Sep 02 16:41:11 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/38cbb8a34cb5a059ea4d44c1c8cdd08b5f58d468 [^]

Fixed issue 0030349: [RR15Q3] A red icon indicating data not synchronised is shown even if nothing needs to be synchronised

Do not execute runSyncProcess, we just need process all pending messages when doing Login

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0080030)
hgbot   
2015-09-02 21:48   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: da8422af57741473c3d48688bec5ecdc463d3431
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Sep 02 21:48:33 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/da8422af57741473c3d48688bec5ecdc463d3431 [^]

Fixed issue 0030349: [RR15Q3] A red icon indicating data not synchronised is shown even if nothing needs to be synchronised

Do not execute runSyncProcess, we just need process all pending messages when doing Login

---
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
---
(0080256)
hgbot   
2015-09-09 08:52   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: aec8576b64ef56a46a9a0680c77c48f6636b21eb
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Sep 08 18:33:00 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/aec8576b64ef56a46a9a0680c77c48f6636b21eb [^]

Related to issue 30349: [RR15Q3] A red icon indicating data not synchronised is shown even if nothing needs to be synchronised
Check if a model can be skipped for syncing, if so skip it

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0080260)
hgbot   
2015-09-09 08:53   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 83c54e62ffbf9717bac3deb178d817003a4f1c44
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Sep 08 18:33:40 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/83c54e62ffbf9717bac3deb178d817003a4f1c44 [^]

Fixes issue Related to issue 30349: [RR15Q3] A red icon indicating data not synchronised is shown even if nothing needs to be synchronised
Skip cashup sync if it is the same as a previous cashup which is already synced

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0080268)
mtaal   
2015-09-09 10:16   
(edited on: 2015-09-09 10:17)
Inadvertently resolved the issue, the q4 issue should be set to resolved
(0080775)
Orekaria   
2015-10-01 12:27   
This issue has been closed due to the RR15Q4 freeze.
The issue https://issues.openbravo.com/view.php?id=31004 [^] continue addressing the topic in the next release cycle, RR16Q1
(0083546)
hgbot   
2016-01-22 11:27   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 981b4f96cb1e838e1f5c85cda1d44b9a92ba8154
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jul 16 15:17:01 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/981b4f96cb1e838e1f5c85cda1d44b9a92ba8154 [^]

Fixed issue 0030349: [RR15Q3] A red icon indicating data not synchronised is shown even if nothing needs to be synchronised and HGVOL fix

When a synchronization of a model returns error callback, we need to be sure that there aren't items to synch before showing red icon.
Actual cashup is synchronized in the login but we do not take into account this cashup.
Red icon tells that we have something pending to synchronize and if we clean cache, we could loose information.
HGVOL fix: When we finish iterating all servers(after iterating offline server) we call to fail callback

---
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
---
(0083763)
mtaal   
2016-02-01 08:59   
Afaics it was unadvertently set to resolved from closed. Setting back to closed.