Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0030339 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
backport | [Openbravo ERP] A. Platform | minor | have not tried | 2015-07-10 12:14 | 2015-07-16 12:58 | |||
Reporter | shuehner | View Status | public | |||||
Assigned To | alostale | |||||||
Priority | immediate | Resolution | fixed | Fixed in Version | 3.0PR15Q3 | |||
Status | closed | Fix in branch | Fixed in SCM revision | 613b06e82db5 | ||||
Projection | none | ETA | none | Target Version | 3.0PR15Q3 | |||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | shuehner | |||||||
OBNetwork customer | No | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Support ticket | ||||||||
Regression level | Coding ( Testing ) | |||||||
Regression date | 2015-06-18 | |||||||
Regression introduced in release | pi | |||||||
Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/0609c9593fc7cd34a25959e41230528685f29578 [^] | |||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0030339: New pg version check which should only stop old pg versions fails to parse 9.5ahpha1 and also stop using it | |||||||
Description | That new version check if designed to prevent using Q3 and higher with pg versions <9.1 However probably because of some bug it fails also prevent using 9.5alpha1 probably as it is confused with the alhpa1 suffix. | |||||||
Steps To Reproduce | try install.source on pg9.4alpha1 (note: possible in try) pg 9.5alpha1 is also already available on the usual apt.postgresql.org repos to easily installable on any debian/ubuntu system | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
![]() |
||||||||
|
![]() |
|
(0078763) hgbot (developer) 2015-07-13 08:28 |
Repository: erp/backports/3.0PR15Q3 Changeset: 613b06e82db5731c34bd6b8e7db5d22a25ce68bc Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Fri Jul 10 13:19:36 2015 +0200 URL: http://code.openbravo.com/erp/backports/3.0PR15Q3/rev/613b06e82db5731c34bd6b8e7db5d22a25ce68bc [^] fixed bug 30339: pg version check prevents using 9.5ahpha1 The check compares version with 9.1 but it took 9.5alpha1 as whole version where alpha1 string part should be removed. Fixed by removing textual parts of the version (this was already done for Oracle) --- M src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/DatabaseVersionCheck.class M src-util/buildvalidation/src/org/openbravo/buildvalidation/DatabaseVersionCheck.java --- |
(0078873) shuehner (administrator) 2015-07-16 12:58 |
Backport also: Citing details from issue testing to have them locally here: Reviewed & tested. Tested by running code against manually extract db versions for 8.4.x, 9.1.x, 9.3.x, 9.5alpha1 On top of several more having special non-numeric suffixes found by searching butler-db with: select distinct db_version from ad_heartbeat where db = 'POSTGRE'; All ok with 1 minor issue: 9.1RC1 formally should not be accepted as some earlier release candidate only. However people using RC should know better themselves and fine to not cover this corner case in this check. |
![]() |
|||
Date Modified | Username | Field | Change |
2015-07-10 13:28 | alostale | Type | defect => backport |
2015-07-10 13:28 | alostale | Target Version | => 3.0PR15Q3 |
2015-07-10 13:30 | alostale | Review Assigned To | => shuehner |
2015-07-13 08:28 | hgbot | Checkin | |
2015-07-13 08:28 | hgbot | Note Added: 0078763 | |
2015-07-13 08:28 | hgbot | Status | scheduled => resolved |
2015-07-13 08:28 | hgbot | Resolution | open => fixed |
2015-07-13 08:28 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/backports/3.0PR15Q3/rev/613b06e82db5731c34bd6b8e7db5d22a25ce68bc [^] |
2015-07-16 12:58 | shuehner | Note Added: 0078873 | |
2015-07-16 12:58 | shuehner | Status | resolved => closed |
2015-07-16 12:58 | shuehner | Fixed in Version | => 3.0PR15Q3 |
Copyright © 2000 - 2009 MantisBT Group |