Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030339Openbravo ERPA. Platformpublic2015-07-10 12:142015-07-16 12:58
Reportershuehner 
Assigned Toalostale 
PriorityimmediateSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q3Fixed in Version3.0PR15Q3 
Merge Request Status
Review Assigned Toshuehner
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelCoding ( Testing )
Regression date2015-06-18
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/0609c9593fc7cd34a25959e41230528685f29578 [^]
Triggers an Emergency PackNo
Summary0030339: New pg version check which should only stop old pg versions fails to parse 9.5ahpha1 and also stop using it
DescriptionThat new version check if designed to prevent using Q3 and higher with pg versions <9.1

However probably because of some bug it fails also prevent using 9.5alpha1 probably as it is confused with the alhpa1 suffix.

Steps To Reproducetry install.source on pg9.4alpha1 (note: possible in try)
pg 9.5alpha1 is also already available on the usual apt.postgresql.org repos to easily installable on any debian/ubuntu system
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0030337 closed alostale New pg version check which should only stop old pg versions fails to parse 9.5ahpha1 and also stop using it 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-07-10 13:28alostaleTypedefect => backport
2015-07-10 13:28alostaleTarget Version => 3.0PR15Q3
2015-07-10 13:30alostaleReview Assigned To => shuehner
2015-07-13 08:28hgbotCheckin
2015-07-13 08:28hgbotNote Added: 0078763
2015-07-13 08:28hgbotStatusscheduled => resolved
2015-07-13 08:28hgbotResolutionopen => fixed
2015-07-13 08:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q3/rev/613b06e82db5731c34bd6b8e7db5d22a25ce68bc [^]
2015-07-16 12:58shuehnerNote Added: 0078873
2015-07-16 12:58shuehnerStatusresolved => closed
2015-07-16 12:58shuehnerFixed in Version => 3.0PR15Q3

Notes
(0078763)
hgbot   
2015-07-13 08:28   
Repository: erp/backports/3.0PR15Q3
Changeset: 613b06e82db5731c34bd6b8e7db5d22a25ce68bc
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Jul 10 13:19:36 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q3/rev/613b06e82db5731c34bd6b8e7db5d22a25ce68bc [^]

fixed bug 30339: pg version check prevents using 9.5ahpha1

  The check compares version with 9.1 but it took 9.5alpha1 as whole version where
  alpha1 string part should be removed.

  Fixed by removing textual parts of the version (this was already done for Oracle)

---
M src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/DatabaseVersionCheck.class
M src-util/buildvalidation/src/org/openbravo/buildvalidation/DatabaseVersionCheck.java
---
(0078873)
shuehner   
2015-07-16 12:58   
Backport also:
Citing details from issue testing to have them locally here:

 Reviewed & tested.
Tested by running code against manually extract db versions for 8.4.x, 9.1.x, 9.3.x, 9.5alpha1

On top of several more having special non-numeric suffixes found by searching butler-db with:
select distinct db_version from ad_heartbeat where db = 'POSTGRE';

All ok with 1 minor issue:
9.1RC1 formally should not be accepted as some earlier release candidate only.
However people using RC should know better themselves and fine to not cover this corner case in this check.