0030301: "Not Balance" error received when posting a transaction (although suspense balancing is not needed)

Description

"Not Balance" error received when posting a transaction (although suspense balancing is not needed)

Steps To Reproduce

1. Access General Ledger Configuration window and General Accounts tab and leave "Suspense Balancing" field empty and uncheck "Suspense Balancing use" for España and International ledgers
2. Access "Cuenta de Banco" financial account and search Transaction with Line no 4800. Unpost transaction
3. Post transaction again and "Not Balanced" error will be raised

If you come back to General Ledger Configuration and mark "Suspense Balancing Use" and then try to post Transaction again it will be correctly posted (not using suspense balancing account)

Proposed Solution

1. Revert changeset https://code.openbravo.com/erp/devel/pi/rev/368eb470c2955fb9525c9e529591c2699122ef21 [^]

2. Replace this piece of code in DocFINFinAccTransaction.getBalance()

    // if payment IN/OUT is in Multi-Currency then get Multi-Currency amount field because
    // FIN_Payment line amount is in that currency.
    if (payment != null) {
      if (!payment.getAccount().getCurrency().getId()
          .equalsIgnoreCase(payment.getCurrency().getId())) {
        retValue = payment.getAmount();
      }
    }

by

    // if payment IN/OUT is in Multi-Currency then get Multi-Currency amount field because
    // FIN_Payment line amount is in that currency.
    if (payment != null) {
      if (!payment.getAccount().getCurrency().getId()
          .equalsIgnoreCase(payment.getCurrency().getId())) {
        retValue = payment.isReceipt() ? payment.getAmount() : payment.getAmount().negate();
      }
    }

Tags

Approved

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0030273

3.0PR15Q4

closed

AtulOpenbravo

"Not Balance" error received when posting a transaction (although suspense balancing is not needed)

Notes
(0078666) hgbot (developer) 2015-07-06 12:04	Repository: erp/backports/3.0PR15Q3 Changeset: b8a65b22f95fa31e1f6f69a90a9af993939e9816 Author: Atul Gaware <atul.gaware <at> openbravo.com> Date: Thu Jul 02 22:07:27 2015 +0530 URL: http://code.openbravo.com/erp/backports/3.0PR15Q3/rev/b8a65b22f95fa31e1f6f69a90a9af993939e9816 [^] Fixes Issue 30301:"Not Balance" error received when posting a transaction (although suspense balancing is not needed) Fix takes into account the payment's sign (payment in/out). --- M src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransaction.java ---

(0078669) vmromanos (viewer) 2015-07-06 12:05	Code review + testing OK

Issue History
Date Modified	Username	Field	Change
2015-07-02 12:41	vmromanos	Type	defect => backport
2015-07-02 12:41	vmromanos	Target Version	3.0PR15Q4 => 3.0PR15Q3
2015-07-02 19:26	dmitry_mezentsev	Tag Attached: Approved
2015-07-06 12:04	hgbot	Checkin
2015-07-06 12:04	hgbot	Note Added: 0078666
2015-07-06 12:04	hgbot	Status	scheduled => resolved
2015-07-06 12:04	hgbot	Resolution	open => fixed
2015-07-06 12:04	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/backports/3.0PR15Q3/rev/b8a65b22f95fa31e1f6f69a90a9af993939e9816 [^]
2015-07-06 12:05	vmromanos	Review Assigned To	=> vmromanos
2015-07-06 12:05	vmromanos	Note Added: 0078669
2015-07-06 12:05	vmromanos	Status	resolved => closed