0030301: "Not Balance" error received when posting a transaction (although suspense balancing is not needed)

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0030301

Openbravo ERP

09. Financial management

public

2015-06-29 12:54

2015-07-06 12:05

Reporter

maite

Assigned To

AtulOpenbravo

Priority

immediate

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

3.0PR15Q3

Fixed in Version

Merge Request Status

Review Assigned To

vmromanos

OBNetwork customer

OBPS

Web browser

Modules

Advanced Payables and Receivables Mngmt

Support ticket

37111

Regression level

Production - QA Approved

Regression date

2015-01-13

Regression introduced in release

3.0PR15Q2

Regression introduced by commit

https://code.openbravo.com/erp/devel/pi/rev/368eb470c2955fb9525c9e529591c2699122ef21 [^]

Triggers an Emergency Pack

Summary

0030301: "Not Balance" error received when posting a transaction (although suspense balancing is not needed)

Description

"Not Balance" error received when posting a transaction (although suspense balancing is not needed)

Steps To Reproduce

1. Access General Ledger Configuration window and General Accounts tab and leave "Suspense Balancing" field empty and uncheck "Suspense Balancing use" for España and International ledgers
2. Access "Cuenta de Banco" financial account and search Transaction with Line no 4800. Unpost transaction
3. Post transaction again and "Not Balanced" error will be raised

If you come back to General Ledger Configuration and mark "Suspense Balancing Use" and then try to post Transaction again it will be correctly posted (not using suspense balancing account)

Proposed Solution

1. Revert changeset https://code.openbravo.com/erp/devel/pi/rev/368eb470c2955fb9525c9e529591c2699122ef21 [^]

2. Replace this piece of code in DocFINFinAccTransaction.getBalance()

    // if payment IN/OUT is in Multi-Currency then get Multi-Currency amount field because
    // FIN_Payment line amount is in that currency.
    if (payment != null) {
      if (!payment.getAccount().getCurrency().getId()
          .equalsIgnoreCase(payment.getCurrency().getId())) {
        retValue = payment.getAmount();
      }
    }

by

    // if payment IN/OUT is in Multi-Currency then get Multi-Currency amount field because
    // FIN_Payment line amount is in that currency.
    if (payment != null) {
      if (!payment.getAccount().getCurrency().getId()
          .equalsIgnoreCase(payment.getCurrency().getId())) {
        retValue = payment.isReceipt() ? payment.getAmount() : payment.getAmount().negate();
      }
    }

Additional Information