Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0030298
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Discounts and Promotionstrivialalways2015-06-15 10:282015-08-14 14:26
ReporterasiermartirenaView Statuspublic 
Assigned ToRetail 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision5430efba69f7
ProjectionnoneETAnoneTarget VersionRR15Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression levelCode review
Regression date2015-05-05
Regression introduced in releasemain
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a1c1c77a3384b2225f92d600ae03073ada0c5c0d [^]
Triggers an Emergency PackNo
Summary

0030298: Problem with identifier attribute created to show discounts

DescriptionWhen adding a promotion to a product list, an identifier attribute is generated to show a customized name for that promotion. Then, when rendering the line that identifier value is taken and assigned to show in the discount line.
This identifier is not stored in any column in database, so when someone tries to generate again the ticket (for example when creating a return ticket), the line renderization tries to access to the not stored identifier value. This casuses that 'undefined' value is shown for the recovered discount line.
Steps To ReproduceCreate a ticket and add a discount to a product. Pay the ticket.
Return the ticket and select the product with the discount.

In the order created the discount will be shown with the name 'undefined'.
Proposed SolutionCreate a new column to store the identifier value, and only fill it if the identifier is needed. Then, when creating the discount component don't assign the identifier directly. Check if the identifier is filled, and else assign the name value.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0030176 closedjorge-garcia Problem with identifier attribute created to show discounts 

-  Notes
(0079256)
hgbot (developer)
2015-08-07 14:13

Repository: retail/backports/3.0RR15Q3/org.openbravo.retail.discounts
Changeset: 5430efba69f71959af98874aa08ab66a56bd774d
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Aug 03 09:46:20 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q3/org.openbravo.retail.discounts/rev/5430efba69f71959af98874aa08ab66a56bd774d [^]

Fixed issue 30298: Problem with identifier attribute created to show discounts

The problem was that the identifier of the issue is not saved in the database.

The solution is to create a new column that stores the identifier, and retrieve
the discount identifier from the database.

---
M src-db/database/model/modifiedTables/C_ORDERLINE_OFFER.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
---
(0079259)
hgbot (developer)
2015-08-07 14:15

Repository: retail/backports/3.0RR15Q3/org.openbravo.retail.posterminal
Changeset: 176570e17b3093206214d6a2cc7f9f740261681d
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Aug 07 14:10:39 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q3/org.openbravo.retail.posterminal/rev/176570e17b3093206214d6a2cc7f9f740261681d [^]

Related to issue 30298: Changed needed in posterminal module

Some changes are required for the implementation of the discounts module
changes.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/PaidReceipts.java
M web/org.openbravo.retail.posterminal/js/components/renderorderline.js
---
(0079303)
hgbot (developer)
2015-08-11 10:00

Repository: retail/backports/3.0RR15Q3/org.openbravo.retail.posterminal
Changeset: 4495802a2b369cf8f74218ccbdb652a40d600cbc
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Aug 11 09:59:45 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q3/org.openbravo.retail.posterminal/rev/4495802a2b369cf8f74218ccbdb652a40d600cbc [^]

Related to issue 30298: Changed needed in posterminal module

order.js file must be changed too.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0079357)
hgbot (developer)
2015-08-14 13:26

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: aa0b535fc3e586c30aee23dbe8665b97736c6c43
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Aug 11 09:59:45 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/aa0b535fc3e586c30aee23dbe8665b97736c6c43 [^]

Fixes issue 30176, port of issue 30298: Changed needed in posterminal module

order.js file must be changed too.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0079359)
hgbot (developer)
2015-08-14 13:26

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: acfc788c2c5ce9401c9fe9a1d1a4e5a30d9082aa
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Aug 07 14:10:39 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/acfc788c2c5ce9401c9fe9a1d1a4e5a30d9082aa [^]

Fixes issue 30176, port of issue 30298: Changed needed in posterminal module

Some changes are required for the implementation of the discounts module
changes.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/PaidReceipts.java
M web/org.openbravo.retail.posterminal/js/components/renderorderline.js
---
(0079362)
hgbot (developer)
2015-08-14 14:26

Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 3037b3f02cf7bca0c99b8a77974782465772108f
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Aug 03 09:46:20 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/3037b3f02cf7bca0c99b8a77974782465772108f [^]

Fixes issue 30176, port of issue 30298: Problem with identifier attribute created to show discounts

The problem was that the identifier of the issue is not saved in the database.

The solution is to create a new column that stores the identifier, and retrieve
the discount identifier from the database.

---
M src-db/database/model/modifiedTables/C_ORDERLINE_OFFER.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
---

- Issue History
Date Modified Username Field Change
2015-07-02 10:03 marvintm Type defect => backport
2015-07-02 10:03 marvintm Target Version => RR15Q3
2015-08-07 14:13 hgbot Checkin
2015-08-07 14:13 hgbot Note Added: 0079256
2015-08-07 14:13 hgbot Status scheduled => resolved
2015-08-07 14:13 hgbot Resolution open => fixed
2015-08-07 14:13 hgbot Fixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR15Q3/org.openbravo.retail.discounts/rev/5430efba69f71959af98874aa08ab66a56bd774d [^]
2015-08-07 14:15 hgbot Checkin
2015-08-07 14:15 hgbot Note Added: 0079259
2015-08-11 10:00 hgbot Checkin
2015-08-11 10:00 hgbot Note Added: 0079303
2015-08-12 12:55 marvintm Review Assigned To => marvintm
2015-08-12 12:55 marvintm Status resolved => closed
2015-08-14 13:26 hgbot Checkin
2015-08-14 13:26 hgbot Note Added: 0079357
2015-08-14 13:26 hgbot Checkin
2015-08-14 13:26 hgbot Note Added: 0079359
2015-08-14 14:26 hgbot Checkin
2015-08-14 14:26 hgbot Note Added: 0079362


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker