0030298: Problem with identifier attribute created to show discounts

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0030298

Retail Modules

Discounts and Promotions

public

2015-06-15 10:28

2015-08-14 14:26

Reporter

asiermartirena

Assigned To

Retail

Priority

immediate

Severity

trivial

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR15Q3

Fixed in Version

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Code review

Regression date

2015-05-05

Regression introduced in release

main

Regression introduced by commit

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a1c1c77a3384b2225f92d600ae03073ada0c5c0d [^]

Triggers an Emergency Pack

Summary

0030298: Problem with identifier attribute created to show discounts

Description

When adding a promotion to a product list, an identifier attribute is generated to show a customized name for that promotion. Then, when rendering the line that identifier value is taken and assigned to show in the discount line.
This identifier is not stored in any column in database, so when someone tries to generate again the ticket (for example when creating a return ticket), the line renderization tries to access to the not stored identifier value. This casuses that 'undefined' value is shown for the recovered discount line.

Steps To Reproduce

Create a ticket and add a discount to a product. Pay the ticket.
Return the ticket and select the product with the discount.

In the order created the discount will be shown with the name 'undefined'.

Proposed Solution

Create a new column to store the identifier value, and only fill it if the identifier is needed. Then, when creating the discount component don't assign the identifier directly. Check if the identifier is filled, and else assign the name value.

Additional Information