Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0030236
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Layaway orderminoralways2015-06-23 17:552016-01-14 09:53
ReportermigueldejuanaView Statuspublic 
Assigned ToOrekaria 
PrioritynormalResolutionfixedFixed in VersionRR16Q1
StatusclosedFix in branchFixed in SCM revision1e7064538e5e
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tojorge-garcia
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0030236: Pressing Layaway button more than once we increment doc number

DescriptionWhen creating a Layaway, we can press several times Layaway button before it disappears. This increments doc number, so we have created VBS1/0000097 sales order and after pressing Layaway 3 times next order will be VBS1/0000100.
Steps To Reproduce1- Add a product
2- Press "Layaway this receipt"
3- Click total button
4- Check the document number of the actual order
5- Press Layaway button as many times as you can
6- Check the document number of the actual order
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0031879RR15Q3.4 closedjorge-garcia Pressing Layaway button more than once we increment doc number 
related to defect 0031547 closedOrekaria Clicking more than once in "Layaway" button induces that it is not possible save layaways from that moment  
related to defect 0033695 closedmigueldejuana It is still possible to press twice Done or Layaway buttons 

-  Notes
(0079411)
Osmany (developer)
2015-08-18 17:27

 unable to reproduce in pi.
(0082070)
hgbot (developer)
2015-11-23 12:09

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1adb4a2d23e9f8ac698ab122b17b7d4e4f14a129
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Nov 23 12:06:51 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1adb4a2d23e9f8ac698ab122b17b7d4e4f14a129 [^]

Fixed issue 30236, 31547: Layaway button is disabled when it is pressed and scrim is shown

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0082710)
migueldejuana (developer)
2015-12-14 12:25

 Tested and reviewed in 64e10a30bf7d
(0082739)
Orekaria (administrator)
2015-12-14 20:01

 using show/hide and enable/disable is inconsistent
the effect can be shown if this test is run:

    tap(TestId.BUTTON_BROWSE);
    tap(TestId.BUTTON_CATEGORY_BACKPACKSANDTRAVEL);
    tap(TestId.BUTTON_PRODUCT_BACKPACKSANDTRAVEL_ALPINESKIING);
    verify(TestId.LABEL_TOTALTOPAY, "109.90");
    tap(TestId.BUTTON_PAY);
    isVisible(TestId.BUTTON_PAY_EXACT, true);
    isVisible(TestId.BUTTON_LAYAWAY, false);
    isVisible(TestId.BUTTON_PAY_USECREDIT, false);
    tap(TestId.BUTTON_MENU);
    tap(TestId.BUTTON_MENU_LAYAWAYTHISRECEIPT);
    verify(TestId.LABEL_RECEIPT_TYPE, "To be laid away");
    isVisible(TestId.BUTTON_LAYAWAY, true);
    isVisible(TestId.BUTTON_PAY_USECREDIT, false);
    isVisible(TestId.BUTTON_PAY_EXACT, false);
    tap(TestId.BUTTON_LAYAWAY);
    verify(TestId.LABEL_TOTALTOPAY, "0.00");

    tap(TestId.BUTTON_BROWSE);
    tap(TestId.BUTTON_CATEGORY_BACKPACKSANDTRAVEL);
    tap(TestId.BUTTON_PRODUCT_BACKPACKSANDTRAVEL_ALPINESKIING);
    verify(TestId.LABEL_TOTALTOPAY, "109.90");
    tap(TestId.BUTTON_PAY);
    isVisible(TestId.BUTTON_PAY_EXACT, true);
    isVisible(TestId.BUTTON_LAYAWAY, false);
    isVisible(TestId.BUTTON_PAY_USECREDIT, false);
    tap(TestId.BUTTON_MENU);
    tap(TestId.BUTTON_MENU_LAYAWAYTHISRECEIPT);
    verify(TestId.LABEL_RECEIPT_TYPE, "To be laid away");
    isVisible(TestId.BUTTON_LAYAWAY, true);
    isVisible(TestId.BUTTON_PAY_USECREDIT, false);
    isVisible(TestId.BUTTON_PAY_EXACT, false);
    tap(TestId.BUTTON_LAYAWAY);
    verify(TestId.LABEL_TOTALTOPAY, "0.00");
(0082820)
hgbot (developer)
2015-12-17 12:49

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9342c18cd1856bc3e631d21c2846fd54bdfcc636
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Mon Dec 14 20:07:44 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9342c18cd1856bc3e631d21c2846fd54bdfcc636 [^]

Backed out issue 30236, issue 31547; changeset: 1adb4a2d23e9

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0082823)
hgbot (developer)
2015-12-17 12:49

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1e7064538e5efd7e7c9c9fb22b4c9627676b2087
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Mon Dec 14 20:15:34 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1e7064538e5efd7e7c9c9fb22b4c9627676b2087 [^]

Fixes issue 30236, issue 31547: The scrim and the 'showing' value prevent the layaway button from being tapped more than once

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0082857)
hgbot (developer)
2015-12-18 04:55

 Repository: tools/automation/pi-mobile
Changeset: dca701201ed59a7a7538e4512d7e43b8d39cb78c
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Dec 17 21:54:56 2015 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/dca701201ed59a7a7538e4512d7e43b8d39cb78c [^]

Related to issue 30236: Added automated test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I30236_LayawayVerifyDocumentNumber.java
---
(0083007)
jorge-garcia (reporter)
2015-12-28 10:38

 The test must verify that the documentNo has increased only once independent of the number of clicks in the Layaway button
(0083027)
hgbot (developer)
2015-12-28 18:53

 Repository: tools/automation/pi-mobile
Changeset: d45c402031ce1384b22e9aa2a0c170502a7cea35
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Mon Dec 28 18:52:53 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/d45c402031ce1384b22e9aa2a0c170502a7cea35 [^]

Related to issue 30236: The test verifies that the document number has correctly been increased in 1

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31547_LayawayButtonMultipleTaps.java
---
(0083030)
jorge-garcia (reporter)
2015-12-29 08:52

 Code review and testing OK

- Issue History
Date Modified Username Field Change
2015-06-23 17:55 migueldejuana New Issue
2015-06-23 17:55 migueldejuana Assigned To => Retail
2015-06-23 17:55 migueldejuana Triggers an Emergency Pack => No
2015-08-18 17:27 Osmany Status new => scheduled
2015-08-18 17:27 Osmany Note Added: 0079411
2015-11-20 12:16 lorenzofidalgo Relationship added related to 0031547
2015-11-20 13:17 Orekaria Status scheduled => acknowledged
2015-11-23 12:09 hgbot Checkin
2015-11-23 12:09 hgbot Note Added: 0082070
2015-11-23 12:09 hgbot Status acknowledged => resolved
2015-11-23 12:09 hgbot Resolution open => fixed
2015-11-23 12:09 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1adb4a2d23e9f8ac698ab122b17b7d4e4f14a129 [^]
2015-12-09 10:04 Orekaria Review Assigned To => marvintm
2015-12-09 10:04 Orekaria Assigned To Retail => guilleaer
2015-12-14 09:04 mtaal Review Assigned To marvintm => migueldejuana
2015-12-14 12:25 migueldejuana Note Added: 0082710
2015-12-14 12:25 migueldejuana Status resolved => closed
2015-12-14 20:01 Orekaria Note Added: 0082739
2015-12-14 20:01 Orekaria Status closed => new
2015-12-14 20:01 Orekaria Resolution fixed => open
2015-12-14 20:01 Orekaria Status new => scheduled
2015-12-17 12:49 hgbot Checkin
2015-12-17 12:49 hgbot Note Added: 0082820
2015-12-17 12:49 hgbot Checkin
2015-12-17 12:49 hgbot Note Added: 0082823
2015-12-17 12:49 hgbot Status scheduled => resolved
2015-12-17 12:49 hgbot Resolution open => fixed
2015-12-17 12:49 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1adb4a2d23e9f8ac698ab122b17b7d4e4f14a129 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1e7064538e5efd7e7c9c9fb22b4c9627676b2087 [^]
2015-12-18 04:55 hgbot Checkin
2015-12-18 04:55 hgbot Note Added: 0082857
2015-12-24 04:57 Orekaria Assigned To guilleaer => Orekaria
2015-12-28 10:38 jorge-garcia Note Added: 0083007
2015-12-28 10:38 jorge-garcia Status resolved => new
2015-12-28 10:38 jorge-garcia Resolution fixed => open
2015-12-28 10:38 jorge-garcia Status new => scheduled
2015-12-28 18:53 hgbot Checkin
2015-12-28 18:53 hgbot Note Added: 0083027
2015-12-28 18:53 Orekaria Status scheduled => resolved
2015-12-28 18:53 Orekaria Fixed in Version => RR16Q1
2015-12-28 18:53 Orekaria Resolution open => fixed
2015-12-29 08:52 jorge-garcia Review Assigned To migueldejuana => jorge-garcia
2015-12-29 08:52 jorge-garcia Note Added: 0083030
2015-12-29 08:52 jorge-garcia Status resolved => closed
2016-01-14 09:52 guilleaer Note Added: 0083276
2016-01-14 09:52 guilleaer Status closed => new
2016-01-14 09:52 guilleaer Resolution fixed => open
2016-01-14 09:52 guilleaer Fixed in Version RR16Q1 =>
2016-01-14 09:53 guilleaer Status new => scheduled
2016-01-14 09:53 guilleaer Status scheduled => resolved
2016-01-14 09:53 guilleaer Fixed in Version => RR16Q1
2016-01-14 09:53 guilleaer Resolution open => fixed
2016-01-14 09:53 guilleaer Status resolved => closed
2016-01-14 09:54 guilleaer Note Deleted: 0083276
2016-08-12 09:52 migueldejuana Relationship added related to 0033695

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker