Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030236Retail ModulesLayaway orderpublic2015-06-23 17:552016-01-14 09:53
Reportermigueldejuana 
Assigned ToOrekaria 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q1 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030236: Pressing Layaway button more than once we increment doc number
DescriptionWhen creating a Layaway, we can press several times Layaway button before it disappears. This increments doc number, so we have created VBS1/0000097 sales order and after pressing Layaway 3 times next order will be VBS1/0000100.
Steps To Reproduce1- Add a product
2- Press "Layaway this receipt"
3- Click total button
4- Check the document number of the actual order
5- Press Layaway button as many times as you can
6- Check the document number of the actual order
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0031879RR15Q3.4 closed jorge-garcia Pressing Layaway button more than once we increment doc number 
related to defect 0031547 closed Orekaria Clicking more than once in "Layaway" button induces that it is not possible save layaways from that moment  
related to defect 0033695 closed migueldejuana It is still possible to press twice Done or Layaway buttons 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-06-23 17:55migueldejuanaNew Issue
2015-06-23 17:55migueldejuanaAssigned To => Retail
2015-06-23 17:55migueldejuanaTriggers an Emergency Pack => No
2015-08-18 17:27OsmanyStatusnew => scheduled
2015-08-18 17:27OsmanyNote Added: 0079411
2015-11-20 12:16lorenzofidalgoRelationship addedrelated to 0031547
2015-11-20 13:17OrekariaStatusscheduled => acknowledged
2015-11-23 12:09hgbotCheckin
2015-11-23 12:09hgbotNote Added: 0082070
2015-11-23 12:09hgbotStatusacknowledged => resolved
2015-11-23 12:09hgbotResolutionopen => fixed
2015-11-23 12:09hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1adb4a2d23e9f8ac698ab122b17b7d4e4f14a129 [^]
2015-12-09 10:04OrekariaReview Assigned To => marvintm
2015-12-09 10:04OrekariaAssigned ToRetail => guilleaer
2015-12-14 09:04mtaalReview Assigned Tomarvintm => migueldejuana
2015-12-14 12:25migueldejuanaNote Added: 0082710
2015-12-14 12:25migueldejuanaStatusresolved => closed
2015-12-14 20:01OrekariaNote Added: 0082739
2015-12-14 20:01OrekariaStatusclosed => new
2015-12-14 20:01OrekariaResolutionfixed => open
2015-12-14 20:01OrekariaStatusnew => scheduled
2015-12-17 12:49hgbotCheckin
2015-12-17 12:49hgbotNote Added: 0082820
2015-12-17 12:49hgbotCheckin
2015-12-17 12:49hgbotNote Added: 0082823
2015-12-17 12:49hgbotStatusscheduled => resolved
2015-12-17 12:49hgbotResolutionopen => fixed
2015-12-17 12:49hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1adb4a2d23e9f8ac698ab122b17b7d4e4f14a129 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1e7064538e5efd7e7c9c9fb22b4c9627676b2087 [^]
2015-12-18 04:55hgbotCheckin
2015-12-18 04:55hgbotNote Added: 0082857
2015-12-24 04:57OrekariaAssigned Toguilleaer => Orekaria
2015-12-28 10:38jorge-garciaNote Added: 0083007
2015-12-28 10:38jorge-garciaStatusresolved => new
2015-12-28 10:38jorge-garciaResolutionfixed => open
2015-12-28 10:38jorge-garciaStatusnew => scheduled
2015-12-28 18:53hgbotCheckin
2015-12-28 18:53hgbotNote Added: 0083027
2015-12-28 18:53OrekariaStatusscheduled => resolved
2015-12-28 18:53OrekariaFixed in Version => RR16Q1
2015-12-28 18:53OrekariaResolutionopen => fixed
2015-12-29 08:52jorge-garciaReview Assigned Tomigueldejuana => jorge-garcia
2015-12-29 08:52jorge-garciaNote Added: 0083030
2015-12-29 08:52jorge-garciaStatusresolved => closed
2016-01-14 09:52guilleaerNote Added: 0083276
2016-01-14 09:52guilleaerStatusclosed => new
2016-01-14 09:52guilleaerResolutionfixed => open
2016-01-14 09:52guilleaerFixed in VersionRR16Q1 =>
2016-01-14 09:53guilleaerStatusnew => scheduled
2016-01-14 09:53guilleaerStatusscheduled => resolved
2016-01-14 09:53guilleaerFixed in Version => RR16Q1
2016-01-14 09:53guilleaerResolutionopen => fixed
2016-01-14 09:53guilleaerStatusresolved => closed
2016-01-14 09:54guilleaerNote Deleted: 0083276
2016-08-12 09:52migueldejuanaRelationship addedrelated to 0033695

Notes
(0079411)
Osmany   
2015-08-18 17:27   
unable to reproduce in pi.
(0082070)
hgbot   
2015-11-23 12:09   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1adb4a2d23e9f8ac698ab122b17b7d4e4f14a129
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Nov 23 12:06:51 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1adb4a2d23e9f8ac698ab122b17b7d4e4f14a129 [^]

Fixed issue 30236, 31547: Layaway button is disabled when it is pressed and scrim is shown

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0082710)
migueldejuana   
2015-12-14 12:25   
Tested and reviewed in 64e10a30bf7d
(0082739)
Orekaria   
2015-12-14 20:01   
using show/hide and enable/disable is inconsistent
the effect can be shown if this test is run:

    tap(TestId.BUTTON_BROWSE);
    tap(TestId.BUTTON_CATEGORY_BACKPACKSANDTRAVEL);
    tap(TestId.BUTTON_PRODUCT_BACKPACKSANDTRAVEL_ALPINESKIING);
    verify(TestId.LABEL_TOTALTOPAY, "109.90");
    tap(TestId.BUTTON_PAY);
    isVisible(TestId.BUTTON_PAY_EXACT, true);
    isVisible(TestId.BUTTON_LAYAWAY, false);
    isVisible(TestId.BUTTON_PAY_USECREDIT, false);
    tap(TestId.BUTTON_MENU);
    tap(TestId.BUTTON_MENU_LAYAWAYTHISRECEIPT);
    verify(TestId.LABEL_RECEIPT_TYPE, "To be laid away");
    isVisible(TestId.BUTTON_LAYAWAY, true);
    isVisible(TestId.BUTTON_PAY_USECREDIT, false);
    isVisible(TestId.BUTTON_PAY_EXACT, false);
    tap(TestId.BUTTON_LAYAWAY);
    verify(TestId.LABEL_TOTALTOPAY, "0.00");

    tap(TestId.BUTTON_BROWSE);
    tap(TestId.BUTTON_CATEGORY_BACKPACKSANDTRAVEL);
    tap(TestId.BUTTON_PRODUCT_BACKPACKSANDTRAVEL_ALPINESKIING);
    verify(TestId.LABEL_TOTALTOPAY, "109.90");
    tap(TestId.BUTTON_PAY);
    isVisible(TestId.BUTTON_PAY_EXACT, true);
    isVisible(TestId.BUTTON_LAYAWAY, false);
    isVisible(TestId.BUTTON_PAY_USECREDIT, false);
    tap(TestId.BUTTON_MENU);
    tap(TestId.BUTTON_MENU_LAYAWAYTHISRECEIPT);
    verify(TestId.LABEL_RECEIPT_TYPE, "To be laid away");
    isVisible(TestId.BUTTON_LAYAWAY, true);
    isVisible(TestId.BUTTON_PAY_USECREDIT, false);
    isVisible(TestId.BUTTON_PAY_EXACT, false);
    tap(TestId.BUTTON_LAYAWAY);
    verify(TestId.LABEL_TOTALTOPAY, "0.00");
(0082820)
hgbot   
2015-12-17 12:49   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9342c18cd1856bc3e631d21c2846fd54bdfcc636
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Mon Dec 14 20:07:44 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9342c18cd1856bc3e631d21c2846fd54bdfcc636 [^]

Backed out issue 30236, issue 31547; changeset: 1adb4a2d23e9

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0082823)
hgbot   
2015-12-17 12:49   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1e7064538e5efd7e7c9c9fb22b4c9627676b2087
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Mon Dec 14 20:15:34 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1e7064538e5efd7e7c9c9fb22b4c9627676b2087 [^]

Fixes issue 30236, issue 31547: The scrim and the 'showing' value prevent the layaway button from being tapped more than once

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0082857)
hgbot   
2015-12-18 04:55   
Repository: tools/automation/pi-mobile
Changeset: dca701201ed59a7a7538e4512d7e43b8d39cb78c
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Dec 17 21:54:56 2015 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/dca701201ed59a7a7538e4512d7e43b8d39cb78c [^]

Related to issue 30236: Added automated test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I30236_LayawayVerifyDocumentNumber.java
---
(0083007)
jorge-garcia   
2015-12-28 10:38   
The test must verify that the documentNo has increased only once independent of the number of clicks in the Layaway button
(0083027)
hgbot   
2015-12-28 18:53   
Repository: tools/automation/pi-mobile
Changeset: d45c402031ce1384b22e9aa2a0c170502a7cea35
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Mon Dec 28 18:52:53 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/d45c402031ce1384b22e9aa2a0c170502a7cea35 [^]

Related to issue 30236: The test verifies that the document number has correctly been increased in 1

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31547_LayawayButtonMultipleTaps.java
---
(0083030)
jorge-garcia   
2015-12-29 08:52   
Code review and testing OK