Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0030178
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Retail Modules] Web POSminorN/A2015-06-15 11:532015-09-07 13:30
ReporterguillermogilView Statuspublic 
Assigned Toguillermogil 
PrioritynormalResolutionfixedFixed in VersionRR15Q4
StatusclosedFix in branchFixed in SCM revision71ede4979672
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomtaal
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0030178: It could be nice to have a hook before the save process of the customer

DescriptionIt could be nice to have a hook before the save process of the customer
OBPOS_PostCustomerSave
Executed when: Before a Customer is saved.
Arguments:
bpToSave: The object of the bussiness partner
Arguments for callback:
null
Steps To ReproduceN/A
TagsNo tags attached.
Attached Filesdiff file icon postCustomerSaveHook.diff [^] (1,979 bytes) 2015-06-16 10:07 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0079748)
hgbot (developer)
2015-08-26 11:59

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 71ede49796720e604fa50ba8729a7c8151364f08
Author: Jonathan Bueno <jonathan.bueno <at> openbravo.com>
Date: Wed Aug 26 11:55:36 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/71ede49796720e604fa50ba8729a7c8151364f08 [^]

Fixed issue 0030178: It could be nice to have a hook before the save process of the customer

added hook before a customer is saved

---
M web/org.openbravo.retail.posterminal/js/data/datacustomersave.js
---
(0080164)
mtaal (manager)
2015-09-07 08:58

Hi,
Two comments:
- the hook is executed before the customer save so imho it should be called OBPOS_PreCustomerSave (also update the docs when changing it)
- the hook covers one case (remote customer data) but not the case of local customer data, the hook calling code should also be added here I think (check my proposal also):
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/6417b5a426ff/web/org.openbravo.retail.posterminal/js/data/datacustomersave.js#l110 [^]

gr. Martin
(0080171)
mtaal (manager)
2015-09-07 09:56

I updated the docs to reflect the exact point when this hook is called:
http://wiki.openbravo.com/wiki/List_of_Hooks_in_Web_POS [^]
(0080173)
hgbot (developer)
2015-09-07 10:24

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 81f887d5e8d79bc0ddcfedbd194321bdc9f19dd4
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Mon Sep 07 10:24:25 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/81f887d5e8d79bc0ddcfedbd194321bdc9f19dd4 [^]

Related to issue 30178: Post Customer Save hook

Added hook logic if not remote is used

---
M web/org.openbravo.retail.posterminal/js/data/datacustomersave.js
---
(0080174)
guillermogil (manager)
2015-09-07 10:25

After discuss it with AMO we have agreed that the name is correct
(0080193)
mtaal (manager)
2015-09-07 13:30

Reviewed and tested in local and remote customer mode

- Issue History
Date Modified Username Field Change
2015-06-15 11:53 guillermogil New Issue
2015-06-15 11:53 guillermogil Assigned To => Retail
2015-06-15 11:53 guillermogil Triggers an Emergency Pack => No
2015-06-16 10:07 guillermogil File Added: postCustomerSaveHook.diff
2015-08-20 09:03 guillermogil Assigned To Retail => guillermogil
2015-08-20 09:04 guillermogil Review Assigned To => marvintm
2015-08-26 11:59 hgbot Checkin
2015-08-26 11:59 hgbot Note Added: 0079748
2015-08-26 11:59 hgbot Status new => resolved
2015-08-26 11:59 hgbot Resolution open => fixed
2015-08-26 11:59 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/71ede49796720e604fa50ba8729a7c8151364f08 [^]
2015-09-03 11:25 mtaal Review Assigned To marvintm => mtaal
2015-09-07 08:58 mtaal Note Added: 0080164
2015-09-07 08:58 mtaal Status resolved => new
2015-09-07 08:58 mtaal Resolution fixed => open
2015-09-07 09:56 mtaal Note Added: 0080171
2015-09-07 10:24 hgbot Checkin
2015-09-07 10:24 hgbot Note Added: 0080173
2015-09-07 10:25 guillermogil Note Added: 0080174
2015-09-07 10:25 guillermogil Status new => scheduled
2015-09-07 10:25 guillermogil Status scheduled => resolved
2015-09-07 10:25 guillermogil Resolution open => fixed
2015-09-07 13:30 mtaal Note Added: 0080193
2015-09-07 13:30 mtaal Status resolved => closed
2015-09-07 13:30 mtaal Fixed in Version => RR15Q4


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker