Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030178Retail ModulesWeb POSpublic2015-06-15 11:532015-09-07 13:30
Reporterguillermogil 
Assigned Toguillermogil 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q4 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030178: It could be nice to have a hook before the save process of the customer
DescriptionIt could be nice to have a hook before the save process of the customer
OBPOS_PostCustomerSave
Executed when: Before a Customer is saved.
Arguments:
bpToSave: The object of the bussiness partner
Arguments for callback:
null
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff postCustomerSaveHook.diff (1,979) 2015-06-16 10:07
https://issues.openbravo.com/file_download.php?file_id=8212&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-06-15 11:53guillermogilNew Issue
2015-06-15 11:53guillermogilAssigned To => Retail
2015-06-15 11:53guillermogilOBNetwork customer => No
2015-06-15 11:53guillermogilTriggers an Emergency Pack => No
2015-06-16 10:07guillermogilFile Added: postCustomerSaveHook.diff
2015-08-20 09:03guillermogilAssigned ToRetail => guillermogil
2015-08-20 09:04guillermogilReview Assigned To => marvintm
2015-08-26 11:59hgbotCheckin
2015-08-26 11:59hgbotNote Added: 0079748
2015-08-26 11:59hgbotStatusnew => resolved
2015-08-26 11:59hgbotResolutionopen => fixed
2015-08-26 11:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/71ede49796720e604fa50ba8729a7c8151364f08 [^]
2015-09-03 11:25mtaalReview Assigned Tomarvintm => mtaal
2015-09-07 08:58mtaalNote Added: 0080164
2015-09-07 08:58mtaalStatusresolved => new
2015-09-07 08:58mtaalResolutionfixed => open
2015-09-07 09:56mtaalNote Added: 0080171
2015-09-07 10:24hgbotCheckin
2015-09-07 10:24hgbotNote Added: 0080173
2015-09-07 10:25guillermogilNote Added: 0080174
2015-09-07 10:25guillermogilStatusnew => scheduled
2015-09-07 10:25guillermogilStatusscheduled => resolved
2015-09-07 10:25guillermogilResolutionopen => fixed
2015-09-07 13:30mtaalNote Added: 0080193
2015-09-07 13:30mtaalStatusresolved => closed
2015-09-07 13:30mtaalFixed in Version => RR15Q4

Notes
(0079748)
hgbot   
2015-08-26 11:59   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 71ede49796720e604fa50ba8729a7c8151364f08
Author: Jonathan Bueno <jonathan.bueno <at> openbravo.com>
Date: Wed Aug 26 11:55:36 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/71ede49796720e604fa50ba8729a7c8151364f08 [^]

Fixed issue 0030178: It could be nice to have a hook before the save process of the customer

added hook before a customer is saved

---
M web/org.openbravo.retail.posterminal/js/data/datacustomersave.js
---
(0080164)
mtaal   
2015-09-07 08:58   
Hi,
Two comments:
- the hook is executed before the customer save so imho it should be called OBPOS_PreCustomerSave (also update the docs when changing it)
- the hook covers one case (remote customer data) but not the case of local customer data, the hook calling code should also be added here I think (check my proposal also):
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/6417b5a426ff/web/org.openbravo.retail.posterminal/js/data/datacustomersave.js#l110 [^]

gr. Martin
(0080171)
mtaal   
2015-09-07 09:56   
I updated the docs to reflect the exact point when this hook is called:
http://wiki.openbravo.com/wiki/List_of_Hooks_in_Web_POS [^]
(0080173)
hgbot   
2015-09-07 10:24   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 81f887d5e8d79bc0ddcfedbd194321bdc9f19dd4
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Mon Sep 07 10:24:25 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/81f887d5e8d79bc0ddcfedbd194321bdc9f19dd4 [^]

Related to issue 30178: Post Customer Save hook

Added hook logic if not remote is used

---
M web/org.openbravo.retail.posterminal/js/data/datacustomersave.js
---
(0080174)
guillermogil   
2015-09-07 10:25   
After discuss it with AMO we have agreed that the name is correct
(0080193)
mtaal   
2015-09-07 13:30   
Reviewed and tested in local and remote customer mode