0030175: Small coding change to not hide exception/stack trace

Description

There is current code in the OrderLoader which does this:
     } catch (Exception e) {
      System.out.println("Error calling to M_UPDATE_INVENTORY");
      throw new OBException(e.getMessage());

the system.out should go and also the throws should include the original exception:
+ throw new OBException(e.getMessage(), e);

Steps To Reproduce

force an exception in the update stock method

Proposed Solution

     } catch (Exception e) {
- System.out.println("Error calling to M_UPDATE_INVENTORY");
- throw new OBException(e.getMessage());
+ throw new OBException(e.getMessage(), e);
     }
   }

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0078272) hgbot (developer) 2015-06-15 06:37	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 5da88ff001153d202d8cc246c9c3a0a00bcdb078 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Mon Jun 15 06:37:11 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5da88ff001153d202d8cc246c9c3a0a00bcdb078 [^] Fixes issue 30175: Small coding change to not hide exception/stack trace Remove System.out and include original exception in throws --- M src/org/openbravo/retail/posterminal/OrderLoader.java ---

(0078487) migueldejuana (viewer) 2015-06-24 15:31	Tested and reviewed in 2d80f8cf8501

Issue History
Date Modified	Username	Field	Change
2015-06-15 06:36	mtaal	New Issue
2015-06-15 06:36	mtaal	Assigned To	=> mtaal
2015-06-15 06:36	mtaal	OBNetwork customer	=> No
2015-06-15 06:36	mtaal	Triggers an Emergency Pack	=> No
2015-06-15 06:37	hgbot	Checkin
2015-06-15 06:37	hgbot	Note Added: 0078272
2015-06-15 06:37	hgbot	Status	new => resolved
2015-06-15 06:37	hgbot	Resolution	open => fixed
2015-06-15 06:37	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5da88ff001153d202d8cc246c9c3a0a00bcdb078 [^]
2015-06-24 15:31	migueldejuana	Review Assigned To	=> migueldejuana
2015-06-24 15:31	migueldejuana	Note Added: 0078487
2015-06-24 15:31	migueldejuana	Status	resolved => closed
2015-06-24 15:31	migueldejuana	Fixed in Version	=> RR15Q3