Openbravo Issue Tracking System - Retail Modules
View Issue Details
0030175Retail ModulesWeb POSpublic2015-06-15 06:362015-06-24 15:31
mtaal 
mtaal 
normaltrivialhave not tried
closedfixed 
5
 
RR15Q3RR15Q3 
migueldejuana
No
0030175: Small coding change to not hide exception/stack trace
There is current code in the OrderLoader which does this:
     } catch (Exception e) {
      System.out.println("Error calling to M_UPDATE_INVENTORY");
      throw new OBException(e.getMessage());

the system.out should go and also the throws should include the original exception:
+ throw new OBException(e.getMessage(), e);
force an exception in the update stock method
     } catch (Exception e) {
- System.out.println("Error calling to M_UPDATE_INVENTORY");
- throw new OBException(e.getMessage());
+ throw new OBException(e.getMessage(), e);
     }
   }
No tags attached.
Issue History
2015-06-15 06:36mtaalNew Issue
2015-06-15 06:36mtaalAssigned To => mtaal
2015-06-15 06:36mtaalTriggers an Emergency Pack => No
2015-06-15 06:37hgbotCheckin
2015-06-15 06:37hgbotNote Added: 0078272
2015-06-15 06:37hgbotStatusnew => resolved
2015-06-15 06:37hgbotResolutionopen => fixed
2015-06-15 06:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5da88ff001153d202d8cc246c9c3a0a00bcdb078 [^]
2015-06-24 15:31migueldejuanaReview Assigned To => migueldejuana
2015-06-24 15:31migueldejuanaNote Added: 0078487
2015-06-24 15:31migueldejuanaStatusresolved => closed
2015-06-24 15:31migueldejuanaFixed in Version => RR15Q3

Notes
(0078272)
hgbot   
2015-06-15 06:37   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 5da88ff001153d202d8cc246c9c3a0a00bcdb078
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Jun 15 06:37:11 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5da88ff001153d202d8cc246c9c3a0a00bcdb078 [^]

Fixes issue 30175: Small coding change to not hide exception/stack trace
Remove System.out and include original exception in throws

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0078487)
migueldejuana   
2015-06-24 15:31   
Tested and reviewed in 2d80f8cf8501