Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0030116
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] Z. Othersmajoralways2015-05-22 09:562015-06-12 13:56
ReporterngarciaView Statuspublic 
Assigned Tojorge-garcia 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision7d09d1580a03
ProjectionnoneETAnoneTarget Version3.0PR15Q1.5
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tovmromanos
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Regression levelProduction - Confirmed Stable
Regression date2014-02-11
Regression introduced in release3.0PR14Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/87765308f9bd4cdc21b7b53b437f1ed014f5a483 [^]
Triggers an Emergency PackNo
Summary

0030116: Outstanding amount of sales order payment plan is not updated when payment method is set as automatic receipt

DescriptionOutstanding amount of sales order payment plan is not updated when payment method is set as automatic receipt
Steps To ReproduceAs group admin role:
   Create a new Payment Method and set Automatic Receipt = 'Y'
   Add it to a financial account
   Create a Sales Order, set the previously created payment method and Invoice Terms = Immediate
   Create a Sales Invoice from it and complete it
   Check the Received field of the Payment Plan of the order has been updated but the Outstanding amount has not been updated
TagsApproved
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 00299723.0PR15Q3 closedjorge-garcia Outstanding amount of sales order payment plan is not updated when payment method is set as automatic receipt 
blocks defect 00301703.0PR15Q3 closedaferraz Generic UpdatePaymentPlan module script 

-  Notes
(0078236)
hgbot (developer)
2015-06-12 13:46

 Repository: erp/backports/3.0PR15Q1.5
Changeset: 7d09d1580a03f1e0b3141534867414b5a00965a8
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Jun 10 10:52:18 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.5/rev/7d09d1580a03f1e0b3141534867414b5a00965a8 [^]

Fixed issue 30116: Outstanding amount of sales order payment plan is not updated

The problem was that the outstanding amount of sales order payment plan is not
updated when payment method is set as automatic receipt.

Before the commit which introduces this regression, the function checked the
status of the payment. With the changes, the function checks if the payment
schedule detail is paid.

The problem was in the update of the payment plan of the sales order,
specifically in WHERE clause for outstanding amount.

Now, the where clause works as expected, and the outstanding amount is updated
properly.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_GEN_PAYMENTSCHEDULE_INV.xml
---
(0078240)
hgbot (developer)
2015-06-12 13:46

 Repository: erp/backports/3.0PR15Q1.5
Changeset: da877979571529ce8b82b9e812c59aa6bbd4fa85
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Jun 12 12:05:42 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.5/rev/da877979571529ce8b82b9e812c59aa6bbd4fa85 [^]

Related to issue 30116: code review improvements
Reduced useless query complexity to update outstanding amount.
It's only necessary to check fin_payment_detail_id is null (not associated payment) or isinvoicepaid='N' (associated payment but in a non paid yet status)

---
M modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_GEN_PAYMENTSCHEDULE_INV.xml
---
(0078251)
vmromanos (manager)
2015-06-12 13:56

 Code review + testing OK

- Issue History
Date Modified Username Field Change
2015-06-05 11:48 jorge-garcia Type defect => backport
2015-06-05 11:48 jorge-garcia Target Version pi => 3.0PR15Q1.5
2015-06-05 13:09 jorge-garcia Regression date => 2014-02-11
2015-06-10 13:25 dmitry_mezentsev Tag Attached: Approved
2015-06-12 13:46 hgbot Checkin
2015-06-12 13:46 hgbot Note Added: 0078236
2015-06-12 13:46 hgbot Status scheduled => resolved
2015-06-12 13:46 hgbot Resolution open => fixed
2015-06-12 13:46 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q1.5/rev/7d09d1580a03f1e0b3141534867414b5a00965a8 [^]
2015-06-12 13:46 hgbot Checkin
2015-06-12 13:46 hgbot Note Added: 0078240
2015-06-12 13:56 vmromanos Review Assigned To => vmromanos
2015-06-12 13:56 vmromanos Note Added: 0078251
2015-06-12 13:56 vmromanos Status resolved => closed
2015-06-12 14:11 vmromanos Relationship added blocks 0030170

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker