0030079: Payment methods without financial account configured do not appear in Web POS

Description

Payment methods without financial account configured do not appear in Web POS because the HQL sentence that retrieves payment information, relies in an existing financial account. This is wrong because financial account is not mandatory

Steps To Reproduce

Create and configure a payment method for a POS terminal with no financial account configured. Go to Web pos and verify that this payment method does not appear when trying to pay an order

Proposed Solution

In Payment.java use the follwing HQL sentence:

      String hqlPayments = "select "
          + "p as payment, "
          + "p.paymentMethod as paymentMethod, " //
          + "c_currency_rate(coalesce(c, p.paymentMethod.currency), p.obposApplications.organization.currency, null, null, p.obposApplications.client.id, p.obposApplications.organization.id) as rate, "
          + "c_currency_rate(p.obposApplications.organization.currency, coalesce(c, p.paymentMethod.currency), null, null, p.obposApplications.client.id, p.obposApplications.organization.id) as mulrate, "
          + "coalesce(c.iSOCode, p.paymentMethod.currency.iSOCode) as isocode, " //
          + "coalesce(c.symbol, p.paymentMethod.currency.symbol) as symbol, " //
          + "coalesce(c.currencySymbolAtTheRight, p.paymentMethod.currency.currencySymbolAtTheRight) as currencySymbolAtTheRight, " //
          + "coalesce(f.currentBalance, 0) as currentBalance, " //
          + "c.obposPosprecision as obposPosprecision, " //
          + "img.bindaryData as image, " //
          + "img.mimetype as mimetype " //
          + "from OBPOS_App_Payment as p " //
          + "left outer join p.paymentMethod as pm " //
          + "left outer join pm.image as img " //
          + "left outer join p.financialAccount as f " // If financial Account is null currency
                                                       // values default to organization currency
                                                       // values.
          + "left outer join f.currency as c " //
          + "where p.obposApplications.id=? " //
          + "and p.$readableSimpleCriteria and p.$activeCriteria order by p.line, p.commercialName";

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0030078

closed

guillermogil

Payment methods without financial account configured do not appear in Web POS

Notes
(0078306) hgbot (developer) 2015-06-15 20:06	Repository: retail/backports/3.0RR15Q2.2/org.openbravo.retail.posterminal Changeset: 49a34b2ae39a780624d5b3b8dd4dfaf75a3a3312 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Mon Jun 15 20:06:28 2015 +0200 URL: http://code.openbravo.com/retail/backports/3.0RR15Q2.2/org.openbravo.retail.posterminal/rev/49a34b2ae39a780624d5b3b8dd4dfaf75a3a3312 [^] Fixed issue 30079. Payment methods without fin acc are not showing hqlPayments query is now looking for null values --- M src/org/openbravo/retail/posterminal/term/Payments.java ---

(0078344) malsasua (viewer) 2015-06-17 18:46	verified

Issue History
Date Modified	Username	Field	Change
2015-06-02 18:34	marvintm	Type	defect => backport
2015-06-02 18:34	marvintm	Target Version	=> RR15Q2.2
2015-06-15 20:06	hgbot	Checkin
2015-06-15 20:06	hgbot	Note Added: 0078306
2015-06-15 20:06	hgbot	Status	scheduled => resolved
2015-06-15 20:06	hgbot	Resolution	open => fixed
2015-06-15 20:06	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/retail/backports/3.0RR15Q2.2/org.openbravo.retail.posterminal/rev/49a34b2ae39a780624d5b3b8dd4dfaf75a3a3312 [^]
2015-06-17 18:46	malsasua	Review Assigned To	=> malsasua
2015-06-17 18:46	malsasua	Note Added: 0078344
2015-06-17 18:46	malsasua	Status	resolved => closed
2015-06-17 18:46	malsasua	Fixed in Version	=> RR15Q2.2