0030079: Payment methods without financial account configured do not appear in Web POS

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0030079

Retail Modules

Web POS

public

2015-06-02 16:50

2015-06-17 18:46

Reporter

adrianromero

Assigned To

Retail

Priority

urgent

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR15Q2.2

Fixed in Version

RR15Q2.2

Merge Request Status

Review Assigned To

malsasua

OBNetwork customer

Support ticket

Regression level

Production - QA Approved

Regression date

2015-02-18

Regression introduced in release

RR15Q2

Regression introduced by commit

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/992add0c4ec3 [^]

Triggers an Emergency Pack

Summary

0030079: Payment methods without financial account configured do not appear in Web POS

Description

Payment methods without financial account configured do not appear in Web POS because the HQL sentence that retrieves payment information, relies in an existing financial account. This is wrong because financial account is not mandatory

Steps To Reproduce

Create and configure a payment method for a POS terminal with no financial account configured. Go to Web pos and verify that this payment method does not appear when trying to pay an order

Proposed Solution

In Payment.java use the follwing HQL sentence:

      String hqlPayments = "select "
          + "p as payment, "
          + "p.paymentMethod as paymentMethod, " //
          + "c_currency_rate(coalesce(c, p.paymentMethod.currency), p.obposApplications.organization.currency, null, null, p.obposApplications.client.id, p.obposApplications.organization.id) as rate, "
          + "c_currency_rate(p.obposApplications.organization.currency, coalesce(c, p.paymentMethod.currency), null, null, p.obposApplications.client.id, p.obposApplications.organization.id) as mulrate, "
          + "coalesce(c.iSOCode, p.paymentMethod.currency.iSOCode) as isocode, " //
          + "coalesce(c.symbol, p.paymentMethod.currency.symbol) as symbol, " //
          + "coalesce(c.currencySymbolAtTheRight, p.paymentMethod.currency.currencySymbolAtTheRight) as currencySymbolAtTheRight, " //
          + "coalesce(f.currentBalance, 0) as currentBalance, " //
          + "c.obposPosprecision as obposPosprecision, " //
          + "img.bindaryData as image, " //
          + "img.mimetype as mimetype " //
          + "from OBPOS_App_Payment as p " //
          + "left outer join p.paymentMethod as pm " //
          + "left outer join pm.image as img " //
          + "left outer join p.financialAccount as f " // If financial Account is null currency
                                                       // values default to organization currency
                                                       // values.
          + "left outer join f.currency as c " //
          + "where p.obposApplications.id=? " //
          + "and p.$readableSimpleCriteria and p.$activeCriteria order by p.line, p.commercialName";

Additional Information