Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0030064 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
backport | [Openbravo ERP] A. Platform | minor | have not tried | 2015-06-01 13:52 | 2015-06-15 10:15 | |||
Reporter | alostale | View Status | public | |||||
Assigned To | AugustoMauch | |||||||
Priority | immediate | Resolution | fixed | Fixed in Version | 3.0PR15Q1.5 | |||
Status | closed | Fix in branch | Fixed in SCM revision | 161cae7de3fa | ||||
Projection | none | ETA | none | Target Version | 3.0PR15Q1.5 | |||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | alostale | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Regression level | Production - Confirmed Stable | |||||||
Regression date | 2014-11-19 | |||||||
Regression introduced in release | 3.0PR15Q1 | |||||||
Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/3221fd5a8661d7f9dfbfd6d4255bace9834e6535 [^] | |||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0030064: grid is not completely loaded after refresh in some cases | |||||||
Description | Grid is not completely loaded after refreshing it having a record selected and scrolling down to a different page. | |||||||
Steps To Reproduce | 1. Open Country and Region window (check grid is sorted by ISO code) 2. Select first country in the list (Andorra) 3. Scroll down until next page is requested 4. Click the refresh button. Grid is scrolled up again to display selected country -> OK 5. Scroll down till last record in the current page (India), there are 2 problems: -> grid shows to empty lines after India -> there is no extra request to continue loading missing records | |||||||
Tags | Approved | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | ||||||||
|
Notes | |
(0078079) hgbot (developer) 2015-06-04 15:38 |
Repository: erp/backports/3.0PR15Q1.5 Changeset: 161cae7de3fab1b3bbc8ae0a2a84d428dbcc3172 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Thu Jun 04 14:54:06 2015 +0200 URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.5/rev/161cae7de3fab1b3bbc8ae0a2a84d428dbcc3172 [^] Fixes issue 30064: Grid is properly loaded after refreshing with a selected row The problem was caused by this code (the this attribute is a ResultSet), which is contained in the fetchRemoteData function: } else if (this.grid.refreshingWithSelectedRecord) { // if the grid was refreshed with a record selected, use the range that contained that record // instead of using targetRecordId to improve the performance startRow = this.grid.selectedRecordInitInterval; endRow = this.grid.selectedRecordEndInterval; } If the grid is refreshed while one of its records is selected, then the startRow and endRow will be set so that the requested page contains the selected record. The problem was that the ResultSet.localData attribute was not being properly set, as at this points it was expected to contain the 'loading' value for all the rows that are being requested. As a result of this the localData attribute became malformed when the response was processed, and this caused the grid to misbehave. To fix this, the localData is configured to wait for the proper records: this.localData = []; this.setRangeLoading(startRow, endRow); --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js --- |
(0078285) alostale (manager) 2015-06-15 10:15 |
code reviewed + tested |
Issue History | |||
Date Modified | Username | Field | Change |
2015-06-01 13:55 | alostale | Type | defect => backport |
2015-06-01 13:55 | alostale | Target Version | => 3.0PR15Q1.5 |
2015-06-01 14:00 | alostale | Assigned To | platform => AugustoMauch |
2015-06-03 10:38 | dmitry_mezentsev | Tag Attached: Approved | |
2015-06-04 15:14 | AugustoMauch | Issue Monitored: alostale | |
2015-06-04 15:14 | AugustoMauch | Review Assigned To | => alostale |
2015-06-04 15:38 | hgbot | Checkin | |
2015-06-04 15:38 | hgbot | Note Added: 0078079 | |
2015-06-04 15:38 | hgbot | Status | scheduled => resolved |
2015-06-04 15:38 | hgbot | Resolution | open => fixed |
2015-06-04 15:38 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/backports/3.0PR15Q1.5/rev/161cae7de3fab1b3bbc8ae0a2a84d428dbcc3172 [^] |
2015-06-15 10:15 | alostale | Note Added: 0078285 | |
2015-06-15 10:15 | alostale | Status | resolved => closed |
2015-06-15 10:15 | alostale | Fixed in Version | => 3.0PR15Q1.5 |
Copyright © 2000 - 2009 MantisBT Group |