Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0029952
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] A. Platformmajorhave not tried2015-05-15 14:032015-05-25 11:11
ReporteryogaskarnikView Statuspublic 
Assigned Toalostale 
PriorityimmediateResolutionfixedFixed in Version3.0PR15Q1.5
StatusclosedFix in branchFixed in SCM revision44696cd0caad
ProjectionnoneETAnoneTarget Version3.0PR15Q1.5
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToAugustoMauch
Web browser
ModulesCore
Regression levelProduction - Confirmed Stable
Regression date2014-10-28
Regression introduced in release3.0PR15Q1
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/205fdc530e408b51a16a4d596c639339c607af95 [^]
Triggers an Emergency PackNo
Summary

0029952: ProcessBundle.setCloseConnection(false) has no impact when using DalBaseProcess, the connection is always closed

DescriptionDalBaseProcess closes the connection when called from another process. When you explicitly set the value to false for closeConnection method of bundle object, following error occurs:

javax.servlet.ServletException: @CODE=@connnection proxy not usable after
transaction completion
at
org.openbravo.scheduling.ProcessRequestData.update(ProcessRequestData.java:26
9)
at org.openbravo.scheduling.ProcessRunner.execute(ProcessRunner.java:93)
Steps To Reproduce1. Write a custom process extending DalBaseProcess
2. set bundle.setCloseConnection() to false
TagsApproved
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 00299023.0PR15Q3 closedalostale ProcessBundle.setCloseConnection(false) has no impact when using DalBaseProcess, the connection is always closed 

-  Notes
(0077654)
hgbot (developer)
2015-05-22 10:45

 Repository: erp/backports/3.0PR15Q1.5
Changeset: 44696cd0caad9435f8df5e9db1a90fc0b501a252
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu May 21 09:39:04 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.5/rev/44696cd0caad9435f8df5e9db1a90fc0b501a252 [^]

fixed bug 29952: ProcessBundle.setCloseConnection(false) closes connection

  When a process is invoked through ProcessRunner and its bundle is set as
  setCloseConnection(false) there were 2 problems:
    - connection was close after execution so it could not be reused by another
      process invoking it
    - ProcessRunner tried to update the process run status on a closed connection
      causing an error

  The problem is caused by the fix for issue 0027878 which correctly closes the
  connection in DalConnectionProvider when invoking releaseCommitConnection. But
  when setCloseConnection it relied in that bug not closing the connection to
  leave it open.

  The solution consists in doing directly the commit or rollback in DalBaseProcess
  without closing the connection.

---
M src/org/openbravo/service/db/DalBaseProcess.java
---
(0077692)
AugustoMauch (manager)
2015-05-25 11:11

 Code reviewed and verified in [1]@3847b902dc3f

[1] https://code.openbravo.com/erp/backports/3.0PR15Q1.5/ [^]

- Issue History
Date Modified Username Field Change
2015-05-21 09:30 alostale Type defect => backport
2015-05-21 09:30 alostale Target Version 3.0PR15Q3 => 3.0PR15Q1.4
2015-05-22 08:43 alostale Target Version 3.0PR15Q1.4 => 3.0PR15Q1.5
2015-05-22 08:44 alostale Review Assigned To => AugustoMauch
2015-05-22 09:43 dmitry_mezentsev Tag Attached: Approved
2015-05-22 10:45 hgbot Checkin
2015-05-22 10:45 hgbot Note Added: 0077654
2015-05-22 10:45 hgbot Status scheduled => resolved
2015-05-22 10:45 hgbot Resolution open => fixed
2015-05-22 10:45 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q1.5/rev/44696cd0caad9435f8df5e9db1a90fc0b501a252 [^]
2015-05-25 11:11 AugustoMauch Note Added: 0077692
2015-05-25 11:11 AugustoMauch Status resolved => closed
2015-05-25 11:11 AugustoMauch Fixed in Version => 3.0PR15Q1.5

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker