Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0029902
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2015-05-15 14:032015-05-25 10:17
ReporteryogaskarnikView Statuspublic 
Assigned Toalostale 
PriorityimmediateResolutionfixedFixed in Versionpi
StatusclosedFix in branchFixed in SCM revision4ecfba1d868c
ProjectionnoneETAnoneTarget Version3.0PR15Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToAugustoMauch
Web browser
ModulesCore
Regression levelProduction - Confirmed Stable
Regression date2014-10-28
Regression introduced in release3.0PR15Q1
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/205fdc530e408b51a16a4d596c639339c607af95 [^]
Triggers an Emergency PackNo
Summary

0029902: ProcessBundle.setCloseConnection(false) has no impact when using DalBaseProcess, the connection is always closed

DescriptionDalBaseProcess closes the connection when called from another process. When you explicitly set the value to false for closeConnection method of bundle object, following error occurs:

javax.servlet.ServletException: @CODE=@connnection proxy not usable after
transaction completion
at
org.openbravo.scheduling.ProcessRequestData.update(ProcessRequestData.java:26
9)
at org.openbravo.scheduling.ProcessRunner.execute(ProcessRunner.java:93)
Steps To Reproduce1. Write a custom process extending DalBaseProcess
2. set bundle.setCloseConnection() to false
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0020580 closedmtaal DalBaseProcess always closes the connection 
depends on backport 00299513.0PR15Q2.2 closedalostale ProcessBundle.setCloseConnection(false) has no impact when using DalBaseProcess, the connection is always closed 
depends on backport 00299523.0PR15Q1.5 closedalostale ProcessBundle.setCloseConnection(false) has no impact when using DalBaseProcess, the connection is always closed 
caused by defect 0027878 closedmarvintm Code in DalConnectionprovider relate to getTransactionConnection seems to leak db connections always 

-  Notes
(0077614)
hgbot (developer)
2015-05-21 10:32

 Repository: erp/devel/pi
Changeset: 4ecfba1d868c127c76dafdb5afe6b1bf5670e499
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu May 21 09:39:04 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4ecfba1d868c127c76dafdb5afe6b1bf5670e499 [^]

fixed bug 29902: ProcessBundle.setCloseConnection(false) closes connection

  When a process is invoked through ProcessRunner and its bundle is set as
  setCloseConnection(false) there were 2 problems:
    - connection was close after execution so it could not be reused by another
      process invoking it
    - ProcessRunner tried to update the process run status on a closed connection
      causing an error

  The problem is caused by the fix for issue 0027878 which correctly closes the
  connection in DalConnectionProvider when invoking releaseCommitConnection. But
  when setCloseConnection it relied in that bug not closing the connection to
  leave it open.

  The solution consists in doing directly the commit or rollback in DalBaseProcess
  without closing the connection.

---
M src/org/openbravo/service/db/DalBaseProcess.java
---
(0077615)
hgbot (developer)
2015-05-21 10:32

 Repository: erp/devel/pi
Changeset: f74892c7bc32382ff9918cf35783a4fe4ad354d5
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu May 21 10:32:06 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f74892c7bc32382ff9918cf35783a4fe4ad354d5 [^]

related to bug 29902: added test case

---
M src-test/src/org/openbravo/test/AllAntTaskTests.java
A src-test/src/org/openbravo/test/scheduling/ProcessSchedulingTest.java
---
(0077616)
alostale (manager)
2015-05-21 10:46

 Downgrading severity from major to minor because it only affects in very specific cases.
(0077642)
hudsonbot (developer)
2015-05-21 22:54

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/78fa6e8fdcad [^]
Maturity status: Test
(0077643)
hudsonbot (developer)
2015-05-21 22:54

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/78fa6e8fdcad [^]
Maturity status: Test
(0077687)
AugustoMauch (manager)
2015-05-25 10:17

 Code reviewed and verified in pi@c702e1364264

- Issue History
Date Modified Username Field Change
2015-05-15 14:03 yogaskarnik New Issue
2015-05-15 14:03 yogaskarnik Assigned To => platform
2015-05-15 14:03 yogaskarnik Modules => Core
2015-05-15 14:03 yogaskarnik Resolution time => 1432504800
2015-05-15 14:03 yogaskarnik Triggers an Emergency Pack => No
2015-05-15 15:12 egoitz Severity critical => major
2015-05-19 11:21 yogaskarnik Description Updated View Revisions
2015-05-19 11:21 yogaskarnik Steps to Reproduce Updated View Revisions
2015-05-21 08:40 alostale Relationship added caused by 0027878
2015-05-21 09:24 alostale Relationship added related to 0020580
2015-05-21 09:25 alostale Assigned To platform => alostale
2015-05-21 09:27 alostale Regression level => Production - Confirmed Stable
2015-05-21 09:27 alostale Regression date => 2014-10-28
2015-05-21 09:27 alostale Regression introduced in release => 3.0PR15Q1
2015-05-21 09:27 alostale Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/205fdc530e408b51a16a4d596c639339c607af95 [^]
2015-05-21 09:27 alostale Status new => scheduled
2015-05-21 09:30 alostale Status scheduled => acknowledged
2015-05-21 09:30 alostale Status acknowledged => scheduled
2015-05-21 10:32 hgbot Checkin
2015-05-21 10:32 hgbot Note Added: 0077614
2015-05-21 10:32 hgbot Status scheduled => resolved
2015-05-21 10:32 hgbot Resolution open => fixed
2015-05-21 10:32 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4ecfba1d868c127c76dafdb5afe6b1bf5670e499 [^]
2015-05-21 10:32 hgbot Checkin
2015-05-21 10:32 hgbot Note Added: 0077615
2015-05-21 10:46 alostale Note Added: 0077616
2015-05-21 10:46 alostale Severity major => minor
2015-05-21 10:52 alostale Review Assigned To => AugustoMauch
2015-05-21 22:54 hudsonbot Checkin
2015-05-21 22:54 hudsonbot Note Added: 0077642
2015-05-21 22:54 hudsonbot Checkin
2015-05-21 22:54 hudsonbot Note Added: 0077643
2015-05-25 10:17 AugustoMauch Note Added: 0077687
2015-05-25 10:17 AugustoMauch Status resolved => closed
2015-05-25 10:17 AugustoMauch Fixed in Version => pi

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker