0029948: Wrong landed cost calculation when referencing a negative goods receipt

Description

Wrong landed cost calculation when referencing a negative goods receipt

Steps To Reproduce

1. Create new product "costes". Define price=5 for "Tarifa Bebidas Alegres"
2. Register Goods Receipt for Bebidas Alegres. Add line for product "costes" and quantity=6. Process
3. Register Goods Receipt for Bebidas Alegres. Add line for product "costes" and quantity=-2. Process
4. Run "costing background process" and verify that cost is correctly calculated for "costes" product
5. Define Landed Cost Type referencing any account
6. Register Landed Cost document. Create register in Cost tab with amount=2. Access "Receipt" tab and add register selecting your receipt with qty=6 and your receipt with qty=-2 . Process Landed Cost
7. Come back to Product window, Transactions tab and search your negative transaction. Realize that Unit Cost=10 and Total Cost=10.50 when should be Unit Cost=10.50 (5.25*2) and Total Cost=11 (5.25*2+0.5)

Moreover, if you Reactivate your Landed Cost document, Process it again and review new Cost Adjustment it is not 1.50 but 1.48 and not 0.5 but 0.52

Tags

No tags attached.

Attached Files

29948.diff [^] (1,038 bytes) 2015-06-03 15:50 [Show Content] [Hide Content]

# HG changeset patch
# User Unai Martirena <unai.martirena@openbravo.com>
# Date 1432294050 -7200
#      Fri May 22 13:27:30 2015 +0200
# Node ID de8e345c24885adfd616003a113bb5811dd20aa2
# Parent  0e9b82c56280aeb0684c8179e1827e56e0ac443d
Fixes bug 29948

diff --git a/src/org/openbravo/costing/AverageCostAdjustment.java b/src/org/openbravo/costing/AverageCostAdjustment.java
--- a/src/org/openbravo/costing/AverageCostAdjustment.java
+++ b/src/org/openbravo/costing/AverageCostAdjustment.java
@@ -364,7 +364,7 @@
                 stdCurPrecission, RoundingMode.HALF_UP);
             BigDecimal unitCost = CostAdjustmentUtils.getTrxCost(trx, true, OBDal.getInstance()
                 .get(Currency.class, strCurrentCurId));
-            unitCost = unitCost.add(trxAdjAmt);
+            unitCost = unitCost.add(trxUnitCostAdjAmt);
             log.debug("Is adjustment needed? Expected {} vs Current {}",
                 expectedCost.toPlainString(), unitCost.toPlainString());
             if (expectedCost.compareTo(unitCost) != 0) {

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0030017	3.0PR15Q3	closed	aferraz	Should not be possible to select negative receipts when registering a Landed Cost
depends on	backport	0030005	3.0PR15Q2.2	closed	umartirena	Wrong landed cost calculation when referencing a negative goods receipt
depends on	backport	0030006	3.0PR15Q1.5	closed	umartirena	Wrong landed cost calculation when referencing a negative goods receipt

Notes
(0078026) umartirena (reporter) 2015-06-03 15:50	The issue has been closed as it is not any more reproducible due to the resolution of issue https://issues.openbravo.com/view.php?id=30017. [^] Just in case for any reason again happens the same problem find attached a little patch that was implemented at the very beginning of this issue.

Issue History
Date Modified	Username	Field	Change
2015-05-20 18:50	maite	New Issue
2015-05-20 18:50	maite	Assigned To	=> Triage Finance
2015-05-20 18:50	maite	Modules	=> Core
2015-05-20 18:50	maite	Triggers an Emergency Pack	=> No
2015-05-20 18:51	maite	Resolution time	=> 1434751200
2015-05-20 18:51	maite	Target Version	=> 3.0PR15Q3
2015-05-21 18:28	egoitz	Resolution time	1434751200 => 1432332000
2015-05-22 10:22	aferraz	Assigned To	Triage Finance => aferraz
2015-05-25 18:03	eduardo_Argal	Assigned To	aferraz => umartirena
2015-05-25 18:04	eduardo_Argal	Status	new => scheduled
2015-06-03 15:50	umartirena	Review Assigned To	=> umartirena
2015-06-03 15:50	umartirena	Note Added: 0078026
2015-06-03 15:50	umartirena	Status	scheduled => closed
2015-06-03 15:50	umartirena	Resolution	open => unable to reproduce
2015-06-03 15:50	umartirena	File Added: 29948.diff
2015-06-03 15:51	umartirena	Relationship added	related to 0030017