Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0029934 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Openbravo ERP] A. Platform | minor | have not tried | 2015-05-19 19:26 | 2015-06-01 11:22 | |||
| Reporter | mtaal | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR15Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 2d27df96c346 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR15Q3 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | alostale | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0029934: Extend VariablesBase to internally store session values even if there is no session object | |||||||
| Description | The VariablesBase class has methods like this: setSessionValue(String attribute, String value) getSessionValue(String sessionAttribute) These methods expect a HttpSession object to be present in the class. However the class has a constructor which does not set the local session member, leaves it null. Calling setSessionValue or getSessionValue will then throw a NPE and log an error | |||||||
| Steps To Reproduce | Use VariablesBase without setting the session and calling setSessionValue | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0077769) hgbot (developer) 2015-05-26 21:23 |
Repository: erp/devel/pi Changeset: 2d27df96c3467c653ca2bef2f205d00572804e0c Author: Martin Taal <martin.taal <at> openbravo.com> Date: Tue May 26 21:21:50 2015 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/2d27df96c3467c653ca2bef2f205d00572804e0c [^] Fixes issue 29934: Extend VariablesBase to internally store session values even if there is no session object Keep values in Map if there is no session. Changeset includes testcase --- M src-core/src/org/openbravo/base/VariablesBase.java M src-test/src/org/openbravo/test/AllAntTaskTests.java M src-test/src/org/openbravo/test/AllQuickAntTaskTests.java M src-test/src/org/openbravo/test/AntTaskTests.java A src-test/src/org/openbravo/test/system/Issue29934Test.java --- |
|
(0077811) hudsonbot (developer) 2015-05-27 15:38 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9cdfae4d18ae [^] Maturity status: Test |
|
(0077922) alostale (manager) 2015-06-01 11:22 |
code reviewed + tested |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-05-19 19:26 | mtaal | New Issue | |
| 2015-05-19 19:26 | mtaal | Assigned To | => mtaal |
| 2015-05-19 19:26 | mtaal | Modules | => Core |
| 2015-05-19 19:26 | mtaal | Triggers an Emergency Pack | => No |
| 2015-05-19 19:27 | mtaal | Review Assigned To | => alostale |
| 2015-05-26 21:23 | hgbot | Checkin | |
| 2015-05-26 21:23 | hgbot | Note Added: 0077769 | |
| 2015-05-26 21:23 | hgbot | Status | new => resolved |
| 2015-05-26 21:23 | hgbot | Resolution | open => fixed |
| 2015-05-26 21:23 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/2d27df96c3467c653ca2bef2f205d00572804e0c [^] |
| 2015-05-27 15:38 | hudsonbot | Checkin | |
| 2015-05-27 15:38 | hudsonbot | Note Added: 0077811 | |
| 2015-06-01 11:22 | alostale | Note Added: 0077922 | |
| 2015-06-01 11:22 | alostale | Status | resolved => closed |
| 2015-06-01 11:22 | alostale | Fixed in Version | => 3.0PR15Q3 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |