Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029934Openbravo ERPA. Platformpublic2015-05-19 19:262015-06-01 11:22
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q3Fixed in Version3.0PR15Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029934: Extend VariablesBase to internally store session values even if there is no session object
DescriptionThe VariablesBase class has methods like this:
setSessionValue(String attribute, String value)
getSessionValue(String sessionAttribute)

These methods expect a HttpSession object to be present in the class. However the class has a constructor which does not set the local session member, leaves it null.

Calling setSessionValue or getSessionValue will then throw a NPE and log an error
Steps To ReproduceUse VariablesBase without setting the session and calling setSessionValue
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-05-19 19:26mtaalNew Issue
2015-05-19 19:26mtaalAssigned To => mtaal
2015-05-19 19:26mtaalOBNetwork customer => No
2015-05-19 19:26mtaalModules => Core
2015-05-19 19:26mtaalTriggers an Emergency Pack => No
2015-05-19 19:27mtaalReview Assigned To => alostale
2015-05-26 21:23hgbotCheckin
2015-05-26 21:23hgbotNote Added: 0077769
2015-05-26 21:23hgbotStatusnew => resolved
2015-05-26 21:23hgbotResolutionopen => fixed
2015-05-26 21:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2d27df96c3467c653ca2bef2f205d00572804e0c [^]
2015-05-27 15:38hudsonbotCheckin
2015-05-27 15:38hudsonbotNote Added: 0077811
2015-06-01 11:22alostaleNote Added: 0077922
2015-06-01 11:22alostaleStatusresolved => closed
2015-06-01 11:22alostaleFixed in Version => 3.0PR15Q3

Notes
(0077769)
hgbot   
2015-05-26 21:23   
Repository: erp/devel/pi
Changeset: 2d27df96c3467c653ca2bef2f205d00572804e0c
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue May 26 21:21:50 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2d27df96c3467c653ca2bef2f205d00572804e0c [^]

Fixes issue 29934: Extend VariablesBase to internally store session values even if there is no session object
Keep values in Map if there is no session. Changeset includes testcase

---
M src-core/src/org/openbravo/base/VariablesBase.java
M src-test/src/org/openbravo/test/AllAntTaskTests.java
M src-test/src/org/openbravo/test/AllQuickAntTaskTests.java
M src-test/src/org/openbravo/test/AntTaskTests.java
A src-test/src/org/openbravo/test/system/Issue29934Test.java
---
(0077811)
hudsonbot   
2015-05-27 15:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9cdfae4d18ae [^]
Maturity status: Test
(0077922)
alostale   
2015-06-01 11:22   
code reviewed + tested