Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0029809
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] 09. Financial managementminoralways2015-01-27 18:092015-05-19 15:46
ReportervmromanosView Statuspublic 
Assigned Tovmromanos 
PriorityimmediateResolutionfixedFixed in Version3.0PR15Q1.4
StatusclosedFix in branchFixed in SCM revision2311966afd7b
ProjectionnoneETAnoneTarget Version3.0PR15Q1.4
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_12
OS VersionDebian 5.0Database version8.3.8Ant version1.7.0
Product VersionSCM revision 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2012-05-21
Regression introduced in release3.0MP12
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/c00d43ad77bdee88849caf11468e4c08c9e964e3 [^]
Triggers an Emergency PackNo
Summary

0029809: Impossible to create several calendars for the same organization

DescriptionRight now it's impossible to create several calendars for the same organization along as the calendars have similar periods.
This is a restriction that from a functional point of view has no sense and it creates problems in modules (like Intrastat) where it may be interesting to define several calendars per organization.
Steps To ReproduceGo to Fiscal Calendar window
Create a new record for org F&B España, S.A (note that sampledata has another calendar already created for this org)
Go to year and create 2014 year.
Run create periods process. An error is shown:
Error:
Saving failed. The dates period defined is overlapped with another period of an existing year.
Proposed SolutionAllow to create several calendars per organization
Ensure this restriction of overlapping periods is applied grouping by calendar
TagsApproved
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0028787 closedvmromanos Impossible to create several calendars for the same organization 

-  Notes
(0077289)
hgbot (developer)
2015-05-11 16:34

 Repository: erp/backports/3.0PR15Q1.4
Changeset: 774886184190c0d0b263f3301549de1511c990da
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu May 07 12:11:39 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.4/rev/774886184190c0d0b263f3301549de1511c990da [^]

Fixed bug 29809: Impossible to create several calendars for the same organization

Two pieces of code were affected by this bug:
PeriodEventHandler.java: EntityPersistenceEventObserver in charge of checking overlap in manual inserts/updates (or any java process) in c_period table
C_YEARPERIODS: db function associated to the create periods process inside the Fiscal Calendar | Year tab. It also verifies the periods don't overlap other periods.

The fix consists in checking that there is no date overlap per calendar. Before this fix the calendar wasn't taken into account, so it was not possible to define several calendars for the same organization with the same periods.

---
M src-db/database/model/functions/C_YEARPERIODS.xml
M src/org/openbravo/event/PeriodEventHandler.java
---
(0077294)
Sandrahuguet (viewer)
2015-05-11 17:03

 Code review + testing OK
(0077577)
hgbot (developer)
2015-05-19 14:43

 Repository: erp/backports/3.0PR15Q1.4
Changeset: 8d71f8028a5c5e9a230775b2f85dcac6cb6a5615
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue May 19 14:04:18 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.4/rev/8d71f8028a5c5e9a230775b2f85dcac6cb6a5615 [^]

Related to issue 29809: Backout wrong changeset

The changeset pushed was not the good one, and failed in Oracle

---
M src-db/database/model/functions/C_YEARPERIODS.xml
M src/org/openbravo/event/PeriodEventHandler.java
---
(0077578)
hgbot (developer)
2015-05-19 14:43

 Repository: erp/backports/3.0PR15Q1.4
Changeset: 2311966afd7be97116c566e5855b2dc0491fb93a
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu May 07 12:11:39 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.4/rev/2311966afd7be97116c566e5855b2dc0491fb93a [^]

Fixed bug 29809: Impossible to create several calendars for the same organization

Two pieces of code were affected by this bug:
PeriodEventHandler.java: EntityPersistenceEventObserver in charge of checking overlap in manual inserts/updates (or any java process) in c_period table
C_YEARPERIODS: db function associated to the create periods process inside the Fiscal Calendar | Year tab. It also verifies the periods don't overlap other periods.

The fix consists in checking that there is no date overlap per calendar. Before this fix the calendar wasn't taken into account, so it was not possible to define several calendars for the same organization with the same periods.

---
M src-db/database/model/functions/C_YEARPERIODS.xml
M src/org/openbravo/event/PeriodEventHandler.java
---

- Issue History
Date Modified Username Field Change
2015-05-07 10:50 vmromanos Type design defect => backport
2015-05-07 10:50 vmromanos Target Version => 3.0PR15Q1.4
2015-05-07 10:54 vmromanos Assigned To dmiguelez => vmromanos
2015-05-07 17:56 dmitry_mezentsev Tag Attached: Approved
2015-05-11 16:34 hgbot Checkin
2015-05-11 16:34 hgbot Note Added: 0077289
2015-05-11 16:34 hgbot Status scheduled => resolved
2015-05-11 16:34 hgbot Resolution open => fixed
2015-05-11 16:34 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q1.4/rev/774886184190c0d0b263f3301549de1511c990da [^]
2015-05-11 17:03 Sandrahuguet Review Assigned To => Sandrahuguet
2015-05-11 17:03 Sandrahuguet Note Added: 0077294
2015-05-11 17:03 Sandrahuguet Status resolved => closed
2015-05-11 17:03 Sandrahuguet Fixed in Version => 3.0PR15Q1.4
2015-05-19 14:43 hgbot Checkin
2015-05-19 14:43 hgbot Note Added: 0077577
2015-05-19 14:43 hgbot Checkin
2015-05-19 14:43 hgbot Note Added: 0077578
2015-05-19 14:43 hgbot Status closed => resolved
2015-05-19 14:43 hgbot Fixed in SCM revision http://code.openbravo.com/erp/backports/3.0PR15Q1.4/rev/774886184190c0d0b263f3301549de1511c990da [^] => http://code.openbravo.com/erp/backports/3.0PR15Q1.4/rev/2311966afd7be97116c566e5855b2dc0491fb93a [^]
2015-05-19 15:46 Sandrahuguet Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker