Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029809Openbravo ERP09. Financial managementpublic2015-01-27 18:092015-05-19 15:46
Reportervmromanos 
Assigned Tovmromanos 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionDebian 5.0
Product Version 
Target Version3.0PR15Q1.4Fixed in Version3.0PR15Q1.4 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2012-05-21
Regression introduced in release3.0MP12
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/c00d43ad77bdee88849caf11468e4c08c9e964e3 [^]
Triggers an Emergency PackNo
Summary0029809: Impossible to create several calendars for the same organization
DescriptionRight now it's impossible to create several calendars for the same organization along as the calendars have similar periods.
This is a restriction that from a functional point of view has no sense and it creates problems in modules (like Intrastat) where it may be interesting to define several calendars per organization.
Steps To ReproduceGo to Fiscal Calendar window
Create a new record for org F&B España, S.A (note that sampledata has another calendar already created for this org)
Go to year and create 2014 year.
Run create periods process. An error is shown:
Error:
Saving failed. The dates period defined is overlapped with another period of an existing year.
Proposed SolutionAllow to create several calendars per organization
Ensure this restriction of overlapping periods is applied grouping by calendar
Additional Information
TagsApproved
Relationships
blocks defect 0028787 closed vmromanos Impossible to create several calendars for the same organization 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-05-07 10:50vmromanosTypedesign defect => backport
2015-05-07 10:50vmromanosTarget Version => 3.0PR15Q1.4
2015-05-07 10:54vmromanosAssigned Todmiguelez => vmromanos
2015-05-07 17:56dmitry_mezentsevTag Attached: Approved
2015-05-11 16:34hgbotCheckin
2015-05-11 16:34hgbotNote Added: 0077289
2015-05-11 16:34hgbotStatusscheduled => resolved
2015-05-11 16:34hgbotResolutionopen => fixed
2015-05-11 16:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q1.4/rev/774886184190c0d0b263f3301549de1511c990da [^]
2015-05-11 17:03SandrahuguetReview Assigned To => Sandrahuguet
2015-05-11 17:03SandrahuguetNote Added: 0077294
2015-05-11 17:03SandrahuguetStatusresolved => closed
2015-05-11 17:03SandrahuguetFixed in Version => 3.0PR15Q1.4
2015-05-19 14:43hgbotCheckin
2015-05-19 14:43hgbotNote Added: 0077577
2015-05-19 14:43hgbotCheckin
2015-05-19 14:43hgbotNote Added: 0077578
2015-05-19 14:43hgbotStatusclosed => resolved
2015-05-19 14:43hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/backports/3.0PR15Q1.4/rev/774886184190c0d0b263f3301549de1511c990da [^] => http://code.openbravo.com/erp/backports/3.0PR15Q1.4/rev/2311966afd7be97116c566e5855b2dc0491fb93a [^]
2015-05-19 15:46SandrahuguetStatusresolved => closed

Notes
(0077289)
hgbot   
2015-05-11 16:34   
Repository: erp/backports/3.0PR15Q1.4
Changeset: 774886184190c0d0b263f3301549de1511c990da
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu May 07 12:11:39 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.4/rev/774886184190c0d0b263f3301549de1511c990da [^]

Fixed bug 29809: Impossible to create several calendars for the same organization

Two pieces of code were affected by this bug:
PeriodEventHandler.java: EntityPersistenceEventObserver in charge of checking overlap in manual inserts/updates (or any java process) in c_period table
C_YEARPERIODS: db function associated to the create periods process inside the Fiscal Calendar | Year tab. It also verifies the periods don't overlap other periods.

The fix consists in checking that there is no date overlap per calendar. Before this fix the calendar wasn't taken into account, so it was not possible to define several calendars for the same organization with the same periods.

---
M src-db/database/model/functions/C_YEARPERIODS.xml
M src/org/openbravo/event/PeriodEventHandler.java
---
(0077294)
Sandrahuguet   
2015-05-11 17:03   
Code review + testing OK
(0077577)
hgbot   
2015-05-19 14:43   
Repository: erp/backports/3.0PR15Q1.4
Changeset: 8d71f8028a5c5e9a230775b2f85dcac6cb6a5615
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue May 19 14:04:18 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.4/rev/8d71f8028a5c5e9a230775b2f85dcac6cb6a5615 [^]

Related to issue 29809: Backout wrong changeset

The changeset pushed was not the good one, and failed in Oracle

---
M src-db/database/model/functions/C_YEARPERIODS.xml
M src/org/openbravo/event/PeriodEventHandler.java
---
(0077578)
hgbot   
2015-05-19 14:43   
Repository: erp/backports/3.0PR15Q1.4
Changeset: 2311966afd7be97116c566e5855b2dc0491fb93a
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu May 07 12:11:39 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.4/rev/2311966afd7be97116c566e5855b2dc0491fb93a [^]

Fixed bug 29809: Impossible to create several calendars for the same organization

Two pieces of code were affected by this bug:
PeriodEventHandler.java: EntityPersistenceEventObserver in charge of checking overlap in manual inserts/updates (or any java process) in c_period table
C_YEARPERIODS: db function associated to the create periods process inside the Fiscal Calendar | Year tab. It also verifies the periods don't overlap other periods.

The fix consists in checking that there is no date overlap per calendar. Before this fix the calendar wasn't taken into account, so it was not possible to define several calendars for the same organization with the same periods.

---
M src-db/database/model/functions/C_YEARPERIODS.xml
M src/org/openbravo/event/PeriodEventHandler.java
---