0029483: When incremental is working, total button remains disabled for 1 minute

Description

When incremental update is working, total button remains disabled for 1 minute in slow devices an it bothers users.
Do we need to block total button when incremental update?
If we have a product in the ticket and the incremental update remove it, do we process correctly the order(because we are processing an order with a removed product)?

Steps To Reproduce

- Set incremental update every minute (POS Terminal Type window)
- Login in a slow device
- create an order and see how total button is disabled for a while without doing anything.

Proposed Solution

I know that could be a corner case but I would manage it.

Case: We have an opened order, we do an incremental refresh, something included in the order have changed in the master data.

Solution: I will review the opened orders content and see if something have change, if something have changed, show a modal telling this and 2 options:
- Delete the order and start creating the order again.
- Process the order as it is in that moment.

I know that it can be a bit hard but this should not happen very often and if it happens we must not let the user work with wrong data.

Tags

No tags attached.

Attached Files

diffIssue29483.diff [^] (1,476 bytes) 2015-06-25 11:59 [Show Content] [Hide Content]

diff -r 5f4ba529d48f web/org.openbravo.mobile.core/source/data/ob-datasource.js
--- a/web/org.openbravo.mobile.core/source/data/ob-datasource.js	Fri Feb 06 05:20:55 2015 +0000
+++ b/web/org.openbravo.mobile.core/source/data/ob-datasource.js	Thu Jun 25 11:58:20 2015 +0200
@@ -167,7 +167,7 @@
   }
 
   function serviceGET(source, dataparams, callback, callbackError, async) {
-    var synchId = OB.UTIL.SynchronizationHelper.busyUntilFinishes('serviceGET ' + source);
+    //var synchId = OB.UTIL.SynchronizationHelper.busyUntilFinishes('serviceGET ' + source);
     if (async !== false) {
       async = true;
     }
@@ -180,11 +180,11 @@
       ignoreForConnectionStatus: dataparams.parameters && dataparams.parameters.ignoreForConnectionStatus ? dataparams.parameters.ignoreForConnectionStatus : false,
       contentType: 'application/json;charset=utf-8',
       success: function (inSender, inResponse) {
-        OB.UTIL.SynchronizationHelper.finished(synchId, 'serviceGET');
+        //OB.UTIL.SynchronizationHelper.finished(synchId, 'serviceGET');
         serviceSuccess(inResponse, callback);
       },
       fail: function (inSender, inResponse) {
-        OB.UTIL.SynchronizationHelper.finished(synchId, 'serviceGET');
+        //OB.UTIL.SynchronizationHelper.finished(synchId, 'serviceGET');
         OB.UTIL.Debug.execute(function () {
           // show an error while in debug mode to help debugging and testing
           if (inSender && inSender === 401) {

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

0029396

RR15Q3

closed

Retail

Stabilization: RR15Q3 related

Notes
(0078502) guilleaer (manager) 2015-06-25 11:59 edited on: 2015-06-29 15:00	Attached a temporal fix for Q1.1 This functionality will be refactored in next releases.

(0078562) migueldejuana (developer) 2015-06-29 15:02	Reviewed

Issue History
Date Modified	Username	Field	Change
2015-03-31 18:47	migueldejuana	New Issue
2015-03-31 18:47	migueldejuana	Assigned To	=> Retail
2015-03-31 18:47	migueldejuana	Triggers an Emergency Pack	=> No
2015-03-31 18:47	migueldejuana	Relationship added	related to 0029396
2015-06-23 13:26	malsasua	Resolution time	=> 1435356000
2015-06-25 11:58	guilleaer	Assigned To	Retail => guilleaer
2015-06-25 11:59	guilleaer	File Added: diffIssue29483.diff
2015-06-25 11:59	guilleaer	Status	new => scheduled
2015-06-25 11:59	guilleaer	Note Added: 0078502
2015-06-25 11:59	guilleaer	Status	scheduled => resolved
2015-06-25 11:59	guilleaer	Resolution	open => fixed
2015-06-29 15:00	guilleaer	Note Edited: 0078502	View Revisions
2015-06-29 15:02	migueldejuana	Review Assigned To	=> migueldejuana
2015-06-29 15:02	migueldejuana	Note Added: 0078562
2015-06-29 15:02	migueldejuana	Status	resolved => closed