Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0029280
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Retail Modules] Web POSminoralways2015-03-13 19:592015-03-27 17:06
ReporterOrekariaView Statuspublic 
Assigned ToOrekaria 
PrioritynormalResolutionfixedFixed in VersionRR15Q2
StatusclosedFix in branchFixed in SCM revision3a2055ff8dfd
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0029280: Stabilization: Session related management requires a synchronous flow

DescriptionStabilization: Session related management requires a synchronous flow

There are session related exceptions that seams to be provoked by the asynchronous nature of the local database
Steps To ReproduceIn OB.Dal.find mofify:
  executeSqlErrorHandler('warn', "OB.Dal.find: table", tableName, txError, e);
with
  executeSqlErrorHandler('error', "OB.Dal.find: table", tableName, txError, e);

Run the tests. Verify that there are 'session' related errors. E.g:

OB.Dal.save: table 'ad_session'; {"message":"could not prepare statement (1 no such table: ad_session)","code":5}
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on defect 0029055RR15Q2 closedmarvintm Web POS doesn't handle update of local database tables correctly 
depends on defect 0029346 acknowledgedRetail Stabilization: OB.Dal.initCache should execute the callback when all the flow paths have finished 
depends on feature request 0029281 closedOrekaria Stabilization: Raise the log level of the OB.Dal.find errors, from 'warn' to 'error' 
blocks feature request 0029377RR15Q3 closedOrekaria Stabilization: RR15Q2 related 
Not all the children of this issue are yet resolved or closed.

-  Notes
(0075585)
hgbot (developer)
2015-03-13 22:59

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 3a2055ff8dfdf99e8f89b052e34ee5c6a52adc31
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Fri Mar 13 20:19:30 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3a2055ff8dfdf99e8f89b052e34ee5c6a52adc31 [^]

Fixes issue 29280: Session related operations are synchronous

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0075646)
adrianromero (manager)
2015-03-16 17:49

 Here the function setUserModeOnline is invoked and in the callback the updateSession function is invoked: https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/3a2055ff8dfd/web/org.openbravo.mobile.core/source/model/ob-terminal-model.js#l342 [^]

But the function setUserModeOnline also invokes updateSession: https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/3a2055ff8dfd/web/org.openbravo.mobile.core/source/model/ob-terminal-model.js#l1348 [^]

It seems to be redundant either one invocation or the other

Also, the function setUserModeOnline contains an 'if' and in both blocks of this 'if' expression the function "OB.Dal.save(user, function () ..." is invoked but only in one block the function updateSession is invoked. This also seems incorrect and must be reviewed.
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/3a2055ff8dfd/web/org.openbravo.mobile.core/source/model/ob-terminal-model.js#l1325 [^]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/3a2055ff8dfd/web/org.openbravo.mobile.core/source/model/ob-terminal-model.js#l1347 [^]
(0075828)
hgbot (developer)
2015-03-20 19:12

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: c668e54425cbee2f0dd05a755150a84472789a9d
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Fri Mar 20 17:15:24 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c668e54425cbee2f0dd05a755150a84472789a9d [^]

Related to issue 29280: 'setUserModelOnline' fixes

- the updateSession was being executed twice
- the 'setUserModelOnline' will save the session with the user

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0075945)
hgbot (developer)
2015-03-24 20:32

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: d2295f8757b10a4202a647ddf8522c1890eefc8a
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Tue Mar 24 19:57:29 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d2295f8757b10a4202a647ddf8522c1890eefc8a [^]

Related to issue 29280: Better save flow in the 'updateSession' method

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---

- Issue History
Date Modified Username Field Change
2015-03-13 19:59 Orekaria New Issue
2015-03-13 19:59 Orekaria Assigned To => Orekaria
2015-03-13 19:59 Orekaria Triggers an Emergency Pack => No
2015-03-13 22:42 Orekaria Relationship added depends on 0029055
2015-03-13 22:59 hgbot Checkin
2015-03-13 22:59 hgbot Note Added: 0075585
2015-03-13 22:59 hgbot Status new => resolved
2015-03-13 22:59 hgbot Resolution open => fixed
2015-03-13 22:59 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3a2055ff8dfdf99e8f89b052e34ee5c6a52adc31 [^]
2015-03-16 15:09 Orekaria Note Added: 0075628
2015-03-16 15:09 Orekaria Status resolved => new
2015-03-16 15:09 Orekaria Resolution fixed => open
2015-03-16 17:49 adrianromero Note Added: 0075646
2015-03-18 13:32 Orekaria Note Deleted: 0075628
2015-03-19 12:33 Orekaria Relationship added related to 0029346
2015-03-19 13:06 Orekaria Relationship replaced depends on 0029346
2015-03-20 19:12 hgbot Checkin
2015-03-20 19:12 hgbot Note Added: 0075828
2015-03-23 14:52 Orekaria Relationship added blocks 0029377
2015-03-24 18:35 Orekaria Steps to Reproduce Updated View Revisions
2015-03-24 18:35 Orekaria Relationship added depends on 0029281
2015-03-24 20:32 hgbot Checkin
2015-03-24 20:32 hgbot Note Added: 0075945
2015-03-25 09:08 Orekaria Steps to Reproduce Updated View Revisions
2015-03-25 16:12 Orekaria Status new => scheduled
2015-03-25 16:12 Orekaria Status scheduled => resolved
2015-03-25 16:12 Orekaria Fixed in Version => RR15Q2
2015-03-25 16:12 Orekaria Resolution open => fixed
2015-03-27 17:06 marvintm Review Assigned To => marvintm
2015-03-27 17:06 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker