Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0029246
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Warehouse Pickingmajorhave not tried2015-03-11 17:592015-12-09 10:17
ReporteralostaleView Statuspublic 
Assigned ToTriage Omni WMS 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision56cf6314ded4
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket38953
OBNetwork customerOBPS
Regression introduced in release
Summary

0029246: can get duplicated document numbers in picking list

DescriptionPicking module implements its own code to get document numbers, by reading the code looks like it can return duplicated numbers in case of concurrency.
Steps To ReproduceNot tested, just code review org.openbravo.warehouse.pickinglist.OBWPL_Utils.getDocumentNo method: it is selecting the sequence without creating any look, suppose this scencario:

-Thread A: selects docNo
-Thread B: selects docNo (got same number)
-Thread A: saves and flushes
-Thread B: saves and flushes
Proposed SolutionWhy to maintain what looks like a copy of org.openbravo.advpaymentmngt.utility.FIN_Utility.getDocumentNo
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0025075 closededuardo_Argal Openbravo ERP FIN_Utility.getDocumentNo method can return the same documentno to same document and organization. 

-  Notes
(0082596)
hgbot (developer)
2015-12-07 12:52

 Repository: erp/pmods/org.openbravo.warehouse.pickinglist
Changeset: 56cf6314ded4d791965e767c8fb830a9870df93c
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Dec 01 17:38:35 2015 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/56cf6314ded4d791965e767c8fb830a9870df93c [^]

Fixes Issue 29246:Can get duplicated document numbers in picking list

Removed OBWPL_Utils getDocumentNo method and made use of FIN_Utility
getDocumentNo method which does not allow duplicate document no by using
Lock mode in OBCriteria for Document Sequence.

---
M src/org/openbravo/warehouse/pickinglist/AssignActionHandler.java
M src/org/openbravo/warehouse/pickinglist/OBWPL_Utils.java
M src/org/openbravo/warehouse/pickinglist/OutboundPickingListProcess.java
M src/org/openbravo/warehouse/pickinglist/Utilities.java
M src/org/openbravo/warehouse/pickinglist/callout/PickingListDoctype.java
---
(0082597)
dmiguelez (viewer)
2015-12-07 12:52

 Code Review + Testing Ok
(0082606)
hgbot (developer)
2015-12-09 10:17

 Repository: erp/pmods/org.openbravo.warehouse.pickinglist
Changeset: 710e5382dbe6687f5e6dab83408f40bfd2517cb5
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Dec 09 10:17:26 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/710e5382dbe6687f5e6dab83408f40bfd2517cb5 [^]

Related to Issue 29246. Updated Module version.

---
M src-db/database/sourcedata/AD_MODULE.xml
---

- Issue History
Date Modified Username Field Change
2015-03-11 17:59 alostale New Issue
2015-03-11 17:59 alostale Assigned To => naiaramartinez
2015-03-11 17:59 alostale OBNetwork customer => No
2015-03-11 18:03 alostale Relationship added related to 0025075
2015-03-17 18:33 eduardo_Argal Status new => scheduled
2015-03-17 18:33 eduardo_Argal Assigned To naiaramartinez => eduardo_Argal
2015-10-23 15:04 ngarcia Issue Monitored: networkb
2015-10-23 15:05 ngarcia Resolution time => 1449097200
2015-10-23 15:05 ngarcia Support ticket => 38953
2015-10-23 15:05 ngarcia OBNetwork customer No => Yes
2015-10-23 15:05 ngarcia Priority normal => urgent
2015-10-26 11:50 VictorVillar Assigned To eduardo_Argal => Triage Finance
2015-12-07 12:52 hgbot Checkin
2015-12-07 12:52 hgbot Note Added: 0082596
2015-12-07 12:52 hgbot Status scheduled => resolved
2015-12-07 12:52 hgbot Resolution open => fixed
2015-12-07 12:52 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/56cf6314ded4d791965e767c8fb830a9870df93c [^]
2015-12-07 12:52 dmiguelez Review Assigned To => dmiguelez
2015-12-07 12:52 dmiguelez Note Added: 0082597
2015-12-07 12:52 dmiguelez Status resolved => closed
2015-12-09 10:17 hgbot Checkin
2015-12-09 10:17 hgbot Note Added: 0082606

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker