Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029246ModulesWarehouse Pickingpublic2015-03-11 17:592015-12-09 10:17
Reporteralostale 
Assigned ToTriage Omni WMS 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0029246: can get duplicated document numbers in picking list
DescriptionPicking module implements its own code to get document numbers, by reading the code looks like it can return duplicated numbers in case of concurrency.
Steps To ReproduceNot tested, just code review org.openbravo.warehouse.pickinglist.OBWPL_Utils.getDocumentNo method: it is selecting the sequence without creating any look, suppose this scencario:

-Thread A: selects docNo
-Thread B: selects docNo (got same number)
-Thread A: saves and flushes
-Thread B: saves and flushes
Proposed SolutionWhy to maintain what looks like a copy of org.openbravo.advpaymentmngt.utility.FIN_Utility.getDocumentNo
Additional Information
TagsNo tags attached.
Relationships
related to defect 0025075 closed eduardo_Argal Openbravo ERP FIN_Utility.getDocumentNo method can return the same documentno to same document and organization. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-03-11 17:59alostaleNew Issue
2015-03-11 17:59alostaleAssigned To => naiaramartinez
2015-03-11 18:03alostaleRelationship addedrelated to 0025075
2015-03-17 18:33eduardo_ArgalStatusnew => scheduled
2015-03-17 18:33eduardo_ArgalAssigned Tonaiaramartinez => eduardo_Argal
2015-10-23 15:04ngarciaIssue Monitored: networkb
2015-10-23 15:05ngarciaResolution time => 1449097200
2015-10-23 15:05ngarciaPrioritynormal => urgent
2015-10-26 11:50VictorVillarAssigned Toeduardo_Argal => Triage Finance
2015-12-07 12:52hgbotCheckin
2015-12-07 12:52hgbotNote Added: 0082596
2015-12-07 12:52hgbotStatusscheduled => resolved
2015-12-07 12:52hgbotResolutionopen => fixed
2015-12-07 12:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/56cf6314ded4d791965e767c8fb830a9870df93c [^]
2015-12-07 12:52dmiguelezReview Assigned To => dmiguelez
2015-12-07 12:52dmiguelezNote Added: 0082597
2015-12-07 12:52dmiguelezStatusresolved => closed
2015-12-09 10:17hgbotCheckin
2015-12-09 10:17hgbotNote Added: 0082606

Notes
(0082596)
hgbot   
2015-12-07 12:52   
Repository: erp/pmods/org.openbravo.warehouse.pickinglist
Changeset: 56cf6314ded4d791965e767c8fb830a9870df93c
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Dec 01 17:38:35 2015 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/56cf6314ded4d791965e767c8fb830a9870df93c [^]

Fixes Issue 29246:Can get duplicated document numbers in picking list

Removed OBWPL_Utils getDocumentNo method and made use of FIN_Utility
getDocumentNo method which does not allow duplicate document no by using
Lock mode in OBCriteria for Document Sequence.

---
M src/org/openbravo/warehouse/pickinglist/AssignActionHandler.java
M src/org/openbravo/warehouse/pickinglist/OBWPL_Utils.java
M src/org/openbravo/warehouse/pickinglist/OutboundPickingListProcess.java
M src/org/openbravo/warehouse/pickinglist/Utilities.java
M src/org/openbravo/warehouse/pickinglist/callout/PickingListDoctype.java
---
(0082597)
dmiguelez   
2015-12-07 12:52   
Code Review + Testing Ok
(0082606)
hgbot   
2015-12-09 10:17   
Repository: erp/pmods/org.openbravo.warehouse.pickinglist
Changeset: 710e5382dbe6687f5e6dab83408f40bfd2517cb5
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Dec 09 10:17:26 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/710e5382dbe6687f5e6dab83408f40bfd2517cb5 [^]

Related to Issue 29246. Updated Module version.

---
M src-db/database/sourcedata/AD_MODULE.xml
---