0029183: Running combo unit test fails on js error

Description

See related issue, change for that adds js code which fails in specific case.

The code:
      if (me.$.listOrderLines.collection.models.length > 0 && me.$.listOrderLines.collection.models[me.$.listOrderLines.collection.models.length - 1]._changing) {
        me.$.listOrderLines.scrollToBottom = true;
      } else if (list.models && list.length > 0 && model.id === list.models[list.length - 1].id) {
        me.$.listOrderLines.scrollToBottom = true;
      }

in this case it goes into the else but list is not defined causing a js error on js.models

Steps To Reproduce

Install unit/pos test modules
Login to STA-1 store
run:
OB.POS.JSUnitTest.runCombosTests()

Proposed Solution

Add additional safeguard in code so that if list parameter is not set the js code does not fail.

Tags

No tags attached.

Attached Files

Selection_111.png [^] (560,316 bytes) 2015-03-08 06:42

Selection_112.png [^] (253,714 bytes) 2015-03-08 06:42

Relationships [ Relation Graph ] [ Dependency Graph ]

caused by

defect

0028616

RR15Q2

closed

migueldejuana

Ticket scroll is losing the focus in some cases

Notes
(0075270) hgbot (developer) 2015-03-08 06:54	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 9b4bd0fb3703863a74bd4916e5db0673ee8ae523 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Sun Mar 08 06:54:17 2015 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9b4bd0fb3703863a74bd4916e5db0673ee8ae523 [^] Fixes issue 29183: Running combo unit test fails on js error Added check that parameter list is indeed set --- M web/org.openbravo.retail.posterminal/js/components/order.js ---

Issue History
Date Modified	Username	Field	Change
2015-03-08 06:42	mtaal	New Issue
2015-03-08 06:42	mtaal	Assigned To	=> marvintm
2015-03-08 06:42	mtaal	Triggers an Emergency Pack	=> No
2015-03-08 06:42	mtaal	Relationship added	caused by 0028616
2015-03-08 06:42	mtaal	File Added: Selection_111.png
2015-03-08 06:42	mtaal	File Added: Selection_112.png
2015-03-08 06:54	hgbot	Checkin
2015-03-08 06:54	hgbot	Note Added: 0075270
2015-03-08 06:54	hgbot	Status	new => resolved
2015-03-08 06:54	hgbot	Resolution	open => fixed
2015-03-08 06:54	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9b4bd0fb3703863a74bd4916e5db0673ee8ae523 [^]
2015-03-13 12:00	Orekaria	Review Assigned To	=> Orekaria
2015-03-13 12:00	Orekaria	Status	resolved => closed
2015-03-13 12:00	Orekaria	Fixed in Version	=> RR15Q2