0029183: Running combo unit test fails on js error - Openbravo Issue Tracking System

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0029183

Retail Modules

Web POS

public

2015-03-08 06:42

2015-03-13 12:00

Reporter

mtaal

Assigned To

marvintm

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR15Q2

Merge Request Status

Review Assigned To

Orekaria

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0029183: Running combo unit test fails on js error

Description

See related issue, change for that adds js code which fails in specific case.

The code:
      if (me.$.listOrderLines.collection.models.length > 0 && me.$.listOrderLines.collection.models[me.$.listOrderLines.collection.models.length - 1]._changing) {
        me.$.listOrderLines.scrollToBottom = true;
      } else if (list.models && list.length > 0 && model.id === list.models[list.length - 1].id) {
        me.$.listOrderLines.scrollToBottom = true;
      }

in this case it goes into the else but list is not defined causing a js error on js.models

Steps To Reproduce

Install unit/pos test modules
Login to STA-1 store
run:
OB.POS.JSUnitTest.runCombosTests()

Proposed Solution

Add additional safeguard in code so that if list parameter is not set the js code does not fail.

Additional Information

Tags

No tags attached.

Relationships

caused by

defect

0028616

RR15Q2