Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0029174
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2015-03-06 14:332015-05-06 20:25
ReportercaristuView Statuspublic 
Assigned ToAugustoMauch 
PriorityimmediateResolutionfixedFixed in Version3.0PR15Q2
StatusclosedFix in branchFixed in SCM revision7c384195efac
ProjectionnoneETAnoneTarget Version3.0PR15Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression levelProduction - QA Approved
Regression date2014-07-11
Regression introduced in release3.0PR14Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/119c05bb76af1d1f6f681ac60a1c8eb3afe1a10c [^]
Triggers an Emergency PackNo
Summary

0029174: Summarize fields are not displayed in widgets

DescriptionSummarize fields are not displayed in widgets. The following error appears in the log when obtaining the information of a widget with one of this fields:

2015-03-06 15:33:29,603 [ajp-localhost%2F127.0.0.1-8809-8] ERROR org.openbravo.service.datasource.DataSourceServlet -
java.lang.NullPointerException
    at org.hibernate.dialect.function.StandardAnsiSqlAggregationFunctions$SumFunction.determineJdbcTypeCode(StandardAnsiSqlAggregationFunctions.java:145)
    at org.hibernate.dialect.function.StandardAnsiSqlAggregationFunctions$SumFunction.getReturnType(StandardAnsiSqlAggregationFunctions.java:157)
Steps To Reproduce1) Add the "Stock by Warehouse" widget in the Workspace
2) Notice that the summarize field (Sum) for the Quantity on Hand does not appear
TagsNo tags attached.
Attached Filespng file icon beforeQ4.png [^] (67,675 bytes) 2015-03-06 14:33


png file icon afterQ4.png [^] (64,087 bytes) 2015-03-06 14:33

- Relationships Relation Graph ] Dependency Graph ]
caused by defect 0026992 closedAugustoMauch "SUM" Summarize field does not show the total in widgets with huge quantity of data 
related to defect 0032604 closedalostale Stock by Warehouse widget logs error message 
related to defect 0032605 closedalostale widgets summary field not displayed if HQL has group by clause 
related to defect 0036004 acknowledgedTriage Platform Base Review widget definitions included in the standard distribution 
causes design defect 0029741 acknowledgedTriage Platform Base Summarize fields are not displayed in widgets when the query contains subqueries or uses functions 

-  Notes
(0075397)
alostale (manager)
2015-03-10 14:47

Reported case is not standard: quantiy on hand column is already a sum in the query.

The SQL to get the total should look like

select sum(qtyOnHand)
  from (select sum(qtyOnHand)
          from ...)

which is not feasible with HQL (subqueries are not supported in the from clause).

Even this concrete case worked before fix for 0026992 when all records were in client, it didn't when other case.

Please provide actual customer's widget definition to understand the real case and decide on a possible solution.
(0075698)
hgbot (developer)
2015-03-17 18:53

Repository: erp/devel/pi
Changeset: 7c384195efacec360a20e17531acf50aaacf1038
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Mar 17 18:43:56 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7c384195efacec360a20e17531acf50aaacf1038 [^]

Fixes issue 29174: Changes the way summary fields work in widgets

Before this issue [1] was fixed, widget summary fields were computed in the front end, even if the grid had not loaded all the records. This behaviour was wrong, and to fix that issue i
t was decided to compute the summary fields in the backend, the same way it is done in standard grids.

The problem is that widget summary fields that used to show results before fixing [1] (remember that the result that were shown were not valid) do no longer work now, as it is not possi
ble to create a HQL to compute them in the server side. There were three types of summary fields that were not working:
  a) Those based on columns that had an alias in the HQL clause
  b) Those based on columns defined by a subquery
  c) Those based on columns defined in the HQL clase with a summary function

Columns defined like a) are now supported. In order to work they must have a proper value in its Where Clause Left Part field. Columns defined like b) and c) are now no longer supported
. If there is a column of these types in a widget, none of its summary fields will be shown, and a message will be shown in the log.

[1] https://issues.openbravo.com/view.php?id=26992 [^]

---
M modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_FIELD.xml
M modules/org.openbravo.client.querylist/src/org/openbravo/client/querylist/QueryListDataSource.java
---
(0075699)
hgbot (developer)
2015-03-17 18:56

Repository: erp/mods/com.openbravo.support.test
Changeset: 04f7dd013730a799821fbf55b395804fa9c81ca4
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Mar 17 18:55:08 2015 +0100
URL: http://code.openbravo.com/erp/mods/com.openbravo.support.test/rev/04f7dd013730a799821fbf55b395804fa9c81ca4 [^]

Adds two widgets to test issue 29174

The first widget, called Test WIdget: Proper summary field, contains a supported summary field. The second widget, called Test Widget: Not proper summary field, conaints an unsupported sumary field, based on a subquery. When this widget is displayed the summary field is not shown and an error message is shown in the log.

---
M src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
A src-db/database/sourcedata/OBCQL_QUERY_COLUMN.xml
A src-db/database/sourcedata/OBCQL_WIDGET_QUERY.xml
A src-db/database/sourcedata/OBKMO_WIDGET_CLASS.xml
---
(0075700)
AugustoMauch (manager)
2015-03-17 18:56

To test it use the widget defined here [1]

[1] https://code.openbravo.com/erp/mods/com.openbravo.support.test/rev/04f7dd013730 [^]
(0075740)
hudsonbot (developer)
2015-03-18 15:38

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/327af339611e [^]
Maturity status: Test
(0075841)
alostale (manager)
2015-03-23 08:24

code reviewed minor issues:
 * shouldn't exception logs [1] and [2] log also stack traces?
 * copyright for org.openbravo.client.querylist.QueryListDataSource should be updated

tested

[1] https://code.openbravo.com/erp/devel/pi/rev/7c384195efacec360a20e17531acf50aaacf1038#l2.33 [^]
[2] https://code.openbravo.com/erp/devel/pi/rev/7c384195efacec360a20e17531acf50aaacf1038#l2.38 [^]

- Issue History
Date Modified Username Field Change
2015-03-06 14:33 caristu New Issue
2015-03-06 14:33 caristu Assigned To => AugustoMauch
2015-03-06 14:33 caristu Modules => Core
2015-03-06 14:33 caristu Regression introduced in release => 3.0PR14Q4
2015-03-06 14:33 caristu Triggers an Emergency Pack => No
2015-03-06 14:33 caristu File Added: beforeQ4.png
2015-03-06 14:33 caristu File Added: afterQ4.png
2015-03-06 14:43 caristu Issue Monitored: networkb
2015-03-06 14:43 caristu Resolution time => 1432159200
2015-03-06 14:45 caristu Regression level => Production - QA Approved
2015-03-06 14:46 caristu version => pi
2015-03-06 15:34 caristu Description Updated View Revisions
2015-03-09 17:09 AugustoMauch Regression date => 2014-07-11
2015-03-09 17:09 AugustoMauch Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/119c05bb76af1d1f6f681ac60a1c8eb3afe1a10c [^]
2015-03-09 17:09 AugustoMauch Relationship added caused by 0026992
2015-03-10 14:47 alostale Note Added: 0075397
2015-03-10 14:47 alostale Assigned To AugustoMauch => caristu
2015-03-10 14:47 alostale Status new => feedback
2015-03-11 18:30 AugustoMauch Status feedback => new
2015-03-11 18:30 AugustoMauch Assigned To caristu => AugustoMauch
2015-03-11 18:30 AugustoMauch Status new => acknowledged
2015-03-17 14:37 alostale Assigned To AugustoMauch => platform
2015-03-17 18:52 AugustoMauch Assigned To platform => AugustoMauch
2015-03-17 18:52 AugustoMauch Status acknowledged => scheduled
2015-03-17 18:52 AugustoMauch Issue Monitored: alostale
2015-03-17 18:52 AugustoMauch Review Assigned To => alostale
2015-03-17 18:53 hgbot Checkin
2015-03-17 18:53 hgbot Note Added: 0075698
2015-03-17 18:53 hgbot Status scheduled => resolved
2015-03-17 18:53 hgbot Resolution open => fixed
2015-03-17 18:53 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7c384195efacec360a20e17531acf50aaacf1038 [^]
2015-03-17 18:56 hgbot Checkin
2015-03-17 18:56 hgbot Note Added: 0075699
2015-03-17 18:56 AugustoMauch Note Added: 0075700
2015-03-18 15:38 hudsonbot Checkin
2015-03-18 15:38 hudsonbot Note Added: 0075740
2015-03-23 08:24 alostale Note Added: 0075841
2015-03-23 08:24 alostale Status resolved => closed
2015-03-23 08:24 alostale Fixed in Version => 3.0PR15Q2
2015-04-29 19:21 hgbot Checkin
2015-04-29 19:21 hgbot Note Added: 0076888
2015-04-29 19:21 hgbot Checkin
2015-04-29 19:21 hgbot Note Added: 0076889
2015-04-29 20:18 hgbot Checkin
2015-04-29 20:18 hgbot Note Added: 0076894
2015-04-29 20:19 caristu Relationship added causes 0029741
2015-04-29 20:21 caristu Note Deleted: 0076888
2015-04-29 20:21 caristu Note Deleted: 0076894
2015-04-29 20:21 caristu Note Deleted: 0076889
2015-05-06 20:25 eugeni Issue Monitored: eugeni
2016-04-05 16:09 alostale Relationship added related to 0032604
2016-04-05 17:15 alostale Relationship added related to 0032605
2017-05-16 11:24 caristu Relationship added related to 0036004


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker