Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0029162
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersmajoralways2015-03-06 10:062015-03-24 03:44
ReportermaiteView Statuspublic 
Assigned Toreinaldoguerra 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionc2fb827a4f00
ProjectionnoneETAnoneTarget Version3.0PR15Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toaferraz
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0029162: Add Transaction process inside Match statement process, does not consider amount of 0.00 equals to 0

DescriptionAdd Transaction process inside Match statement process, does not consider amount of 0.00 equals to 0
Steps To Reproduce1. Access Financial Account "Cuenta de banco" and create new register in Bank Statement window. Add new bank statement line setting IN amount=50. Process bank statement
2. Via database, verify that "dramount" is 0
3. Run "Match statement" process, cancelling automatic matching
4. Press "+" button to add transaction and realize that transaction type has been correctly set to BPDeposit
5. Via database, update "dramount" field to 0.00
6. Run "Match statement" process, cancelling automatic matching
7. Press "+" button to add transaction and realize that transaction type has been incorrectly set to BP Withdrawal

NOTE: user is not able to manually create bank statement lines with 0.00 values but bank statement import process create bank statement lines with 0.00 values. In my opinion, we need to correct the problem in Add Transactions process (or we should correct different import formats in order to not insert decimals when amount is zero)
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00291973.0PR15Q2 closedSandrahuguet Payment Out is registered as "BP Deposit" transaction type in financial account 
depends on backport 00293833.0PR15Q1.2 closedreinaldoguerra Add Transaction process inside Match statement process, does not consider amount of 0.00 equals to 0 

-  Notes
(0075820)
reinaldoguerra (developer)
2015-03-20 16:13

 Test plan used:
With a Postgres database environment:
1- Login into Openbravo ERP
2- Access Financial Account window and select "Cuenta de banco"
3- Create new register in Bank Statement tab
4- Add a new bank statement line setting amount IN=50. Process bank statement
5- Via database and usign PgAdmin, verify that "dramount" field is 0 in Fin_Bankstatementline table
6- Run "Match statement" process, cancelling automatic matching
7- Press "+" button to add transaction and realize that transaction type has been correctly set to BPDeposit
8- Via database, update "dramount" field to 0.00
9- Run "Match statement" process again, cancelling automatic matching
10- Press "+" button to add transaction and realize that transaction type has been correctly set to BPDeposit as "0.00" is now consider as "0"
(0075894)
hgbot (developer)
2015-03-23 17:38

 Repository: erp/devel/pi
Changeset: c2fb827a4f009088a8850f2a2939fbbb83764c18
Author: Reinaldo Guerra <reinaldo.guerra <at> peoplewalking.com>
Date: Wed Mar 18 16:47:06 2015 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/c2fb827a4f009088a8850f2a2939fbbb83764c18 [^]

Fixed bug 29162: Add Transaction process does not consider well amounts of 0.00

The "compareTo" method was taken into account instead of "equals", to compare BigDecimal.ZERO value with 0.00 (a BigDecimal value with a scale), inside AddTransactionFilterExpression class.
This change was made because BigDecimal "equals", compares the value and the scale, returning false when comparing 0 with 0.00, while "compareTo" only compares values, so considers amounts 0.00 and 0 as the same values. Now transaction type is correctly set to BP Deposit, when "dramount" field is set to 0.00.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddTransactionFilterExpression.java
---
(0075895)
hgbot (developer)
2015-03-23 17:38

 Repository: erp/devel/pi
Changeset: 31a785774e3e25256d14f912becddd4fb8b3dc57
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Mar 23 17:05:15 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/31a785774e3e25256d14f912becddd4fb8b3dc57 [^]

Related to issue 29162: Update copyright

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddTransactionFilterExpression.java
---
(0075896)
hgbot (developer)
2015-03-23 17:38

 Repository: erp/devel/pi
Changeset: 86f26739f0456a1a96b042ea23ca17fe3515020d
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Mar 23 17:27:10 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/86f26739f0456a1a96b042ea23ca17fe3515020d [^]

Related to issue 29162: Make code more clear

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddTransactionFilterExpression.java
---
(0075897)
aferraz (manager)
2015-03-23 17:57

 Code review + Testing OK
(0075913)
hudsonbot (developer)
2015-03-24 03:44

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/63f9617f42fb [^]
Maturity status: Test
(0075914)
hudsonbot (developer)
2015-03-24 03:44

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/63f9617f42fb [^]
Maturity status: Test
(0075915)
hudsonbot (developer)
2015-03-24 03:44

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/63f9617f42fb [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-03-06 10:06 maite New Issue
2015-03-06 10:06 maite Assigned To => Sandrahuguet
2015-03-06 10:06 maite Modules => Advanced Payables and Receivables Mngmt
2015-03-06 10:06 maite Resolution time => 1428357600
2015-03-06 10:06 maite Triggers an Emergency Pack => No
2015-03-06 10:06 maite Issue Monitored: networkb
2015-03-11 00:40 reinaldoguerra Assigned To Sandrahuguet => reinaldoguerra
2015-03-11 00:40 reinaldoguerra Status new => scheduled
2015-03-13 10:35 jonalegriaesarte Target Version 3.0PR15Q2 => 3.0PR15Q3
2015-03-20 16:13 reinaldoguerra Note Added: 0075820
2015-03-23 17:38 hgbot Checkin
2015-03-23 17:38 hgbot Note Added: 0075894
2015-03-23 17:38 hgbot Status scheduled => resolved
2015-03-23 17:38 hgbot Resolution open => fixed
2015-03-23 17:38 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c2fb827a4f009088a8850f2a2939fbbb83764c18 [^]
2015-03-23 17:38 hgbot Checkin
2015-03-23 17:38 hgbot Note Added: 0075895
2015-03-23 17:38 hgbot Checkin
2015-03-23 17:38 hgbot Note Added: 0075896
2015-03-23 17:41 aferraz Relationship added related to 0029197
2015-03-23 17:56 aferraz Status resolved => new
2015-03-23 17:56 aferraz Resolution fixed => open
2015-03-23 17:56 aferraz Status new => scheduled
2015-03-23 17:56 aferraz Status scheduled => resolved
2015-03-23 17:56 aferraz Resolution open => fixed
2015-03-23 17:57 aferraz Review Assigned To => aferraz
2015-03-23 17:57 aferraz Note Added: 0075897
2015-03-23 17:57 aferraz Status resolved => closed
2015-03-24 03:44 hudsonbot Checkin
2015-03-24 03:44 hudsonbot Note Added: 0075913
2015-03-24 03:44 hudsonbot Checkin
2015-03-24 03:44 hudsonbot Note Added: 0075914
2015-03-24 03:44 hudsonbot Checkin
2015-03-24 03:44 hudsonbot Note Added: 0075915

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker