Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0029159
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2015-03-06 09:102015-03-13 12:24
ReporteraaroncaleroView Statuspublic 
Assigned Toaaroncalero 
PrioritynormalResolutionfixedFixed in VersionRR15Q2
StatusclosedFix in branchFixed in SCM revisioneb884fa2d763
ProjectionnoneETAnoneTarget VersionRR15Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToOrekaria
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0029159: When the scan event is fired on the receipt, the POS changes to the scan tab even if it's already open

DescriptionWhen the scan event is triggered on the receipt (receipt.trigger('scan')), the following code is being executed:
this.receipt.on('scan', function (params) {
  this.manualTap('scan', params);
}, this);
This forces the POS window to change to the scan tab (redrawing all the components on that tab) even if the scan tab is already being shown.
In slow machines, this can cause performance issues.
Steps To ReproduceCheck the file web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js on the org.openbravo.retail.posterminal module and verify the following code is there:
this.receipt.on('scan', function (params) {
  this.manualTap('scan', params);
}, this);
Proposed SolutionWe should change to the scan tab only if the current tab is different from the scan tab. We can do that checking the OB.MobileApp.model.get('lastPaneShown') parameter.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0075227)
hgbot (developer)
2015-03-06 09:17

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: eb884fa2d7638b96cabdad303512695bebc4fc47
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Fri Mar 06 09:13:38 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eb884fa2d7638b96cabdad303512695bebc4fc47 [^]

Fixed issue 29159: When the scan event is fired on the receipt, the POS changes to the scan tab even if it's already open

Added the check of the current tab to switch to the scan tab only when the POS is on a different tab

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js
---

- Issue History
Date Modified Username Field Change
2015-03-06 09:10 aaroncalero New Issue
2015-03-06 09:10 aaroncalero Assigned To => aaroncalero
2015-03-06 09:10 aaroncalero Triggers an Emergency Pack => No
2015-03-06 09:17 hgbot Checkin
2015-03-06 09:17 hgbot Note Added: 0075227
2015-03-06 09:17 hgbot Status new => resolved
2015-03-06 09:17 hgbot Resolution open => fixed
2015-03-06 09:17 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eb884fa2d7638b96cabdad303512695bebc4fc47 [^]
2015-03-13 12:24 Orekaria Review Assigned To => Orekaria
2015-03-13 12:24 Orekaria Status resolved => closed
2015-03-13 12:24 Orekaria Fixed in Version => RR15Q2


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker