Openbravo Issue Tracking System - Retail Modules
View Issue Details
0029159Retail ModulesWeb POSpublic2015-03-06 09:102015-03-13 12:24
aaroncalero 
aaroncalero 
normalminorhave not tried
closedfixed 
5
 
RR15Q2RR15Q2 
Orekaria
No
0029159: When the scan event is fired on the receipt, the POS changes to the scan tab even if it's already open
When the scan event is triggered on the receipt (receipt.trigger('scan')), the following code is being executed:
this.receipt.on('scan', function (params) {
  this.manualTap('scan', params);
}, this);
This forces the POS window to change to the scan tab (redrawing all the components on that tab) even if the scan tab is already being shown.
In slow machines, this can cause performance issues.
Check the file web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js on the org.openbravo.retail.posterminal module and verify the following code is there:
this.receipt.on('scan', function (params) {
  this.manualTap('scan', params);
}, this);
We should change to the scan tab only if the current tab is different from the scan tab. We can do that checking the OB.MobileApp.model.get('lastPaneShown') parameter.
No tags attached.
Issue History
2015-03-06 09:10aaroncaleroNew Issue
2015-03-06 09:10aaroncaleroAssigned To => aaroncalero
2015-03-06 09:10aaroncaleroTriggers an Emergency Pack => No
2015-03-06 09:17hgbotCheckin
2015-03-06 09:17hgbotNote Added: 0075227
2015-03-06 09:17hgbotStatusnew => resolved
2015-03-06 09:17hgbotResolutionopen => fixed
2015-03-06 09:17hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eb884fa2d7638b96cabdad303512695bebc4fc47 [^]
2015-03-13 12:24OrekariaReview Assigned To => Orekaria
2015-03-13 12:24OrekariaStatusresolved => closed
2015-03-13 12:24OrekariaFixed in Version => RR15Q2

Notes
(0075227)
hgbot   
2015-03-06 09:17   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: eb884fa2d7638b96cabdad303512695bebc4fc47
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Fri Mar 06 09:13:38 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eb884fa2d7638b96cabdad303512695bebc4fc47 [^]

Fixed issue 29159: When the scan event is fired on the receipt, the POS changes to the scan tab even if it's already open

Added the check of the current tab to switch to the scan tab only when the POS is on a different tab

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js
---