Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0029031
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementmajoralways2015-02-23 17:422015-03-27 02:12
ReporteregoitzView Statuspublic 
Assigned Toreinaldoguerra 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision48625170c6e7
ProjectionnoneETAnoneTarget Version3.0PR15Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tovmromanos
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0029031: The product selector does not work on the transaction tab under financial account window

DescriptionWhen using the product as a dimension the product fields is shown when adding a transation on the financial account window.
That selector does not show data
Steps To Reproduce-Enable the product dimension.
You can do it on the client definition window on the header by click on the show product dimension on header checkbox and also on the dimension tab by selecing the header check box for transaction document.
-go to the financial account window
-go to the transaction lines
-add a new row.
-Try to select a product
*N products are shown.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0075113)
reinaldoguerra (developer)
2015-03-02 23:09

Test plan used:
1- Login into Openbravo ERP
2- Enable the product dimension:
   Go to Client window
   Check the "Show in header" product dimension on header tab
   Go to Dimensions tab, filter by "Financial Account Transaction" as Document Category and "Product" as Dimension
   Check the "Show in header" flag
3- Go to the financial account window and select "Cuenta de Banco"
4- Go to the transaction tab and add a new record
5- Now products are shown when product's selector is opened
(0076035)
hgbot (developer)
2015-03-26 19:02

Repository: erp/devel/pi
Changeset: 48625170c6e7c2ec2876ce0ff388a8e99887582a
Author: Reinaldo Guerra <reinaldo.guerra <at> peoplewalking.com>
Date: Mon Mar 02 12:11:03 2015 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/48625170c6e7c2ec2876ce0ff388a8e99887582a [^]

Fixed bug 29031: Product's selector does not work on financial's transaction tab

The filter expression for product's search selector, was changed in order to exclude the financial account window, from the "salesPriceList" boolean filter, as this window fails if the "isSalesTransaction" condition is included, just like happens for Commission's window.
Now products's selector works, when adding a transaction for a financial account, even if without the price list version active, because the transaction tab has not this field defined.

---
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
---
(0076036)
vmromanos (manager)
2015-03-26 19:06

Code review + testing OK

The solution is not the best one from a technical point of view, but it works and it's similar to the one in 0028426, that's why I have accepted it.

However, if in the future we have more windows with the same problem, applying the same solution would be a mess. Instead of it, I would propose to link this field to a selector that doesn't take into account the price list field.
(0076048)
hudsonbot (developer)
2015-03-27 02:12

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b8858c8b542b [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-02-23 17:42 egoitz New Issue
2015-02-23 17:42 egoitz Assigned To => Sandrahuguet
2015-02-23 17:42 egoitz Modules => Core
2015-02-23 17:42 egoitz Resolution time => 1426719600
2015-02-23 17:42 egoitz Triggers an Emergency Pack => No
2015-02-26 23:22 reinaldoguerra Assigned To Sandrahuguet => reinaldoguerra
2015-02-26 23:22 reinaldoguerra Status new => scheduled
2015-03-02 23:09 reinaldoguerra Note Added: 0075113
2015-03-26 19:02 hgbot Checkin
2015-03-26 19:02 hgbot Note Added: 0076035
2015-03-26 19:02 hgbot Status scheduled => resolved
2015-03-26 19:02 hgbot Resolution open => fixed
2015-03-26 19:02 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/48625170c6e7c2ec2876ce0ff388a8e99887582a [^]
2015-03-26 19:06 vmromanos Review Assigned To => vmromanos
2015-03-26 19:06 vmromanos Note Added: 0076036
2015-03-26 19:06 vmromanos Status resolved => closed
2015-03-27 02:12 hudsonbot Checkin
2015-03-27 02:12 hudsonbot Note Added: 0076048


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker