Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0028987
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementmajoralways2015-02-18 18:022015-02-26 12:04
ReporteregoitzView Statuspublic 
Assigned Toumartirena 
PriorityurgentResolutionfixedFixed in Version3.0PR15Q2
StatusclosedFix in branchFixed in SCM revisionaba0f61a4140
ProjectionnoneETAnoneTarget Version3.0PR15Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToSandrahuguet
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0028987: Under some circustancde the Add details button takes long to be loaded

DescriptionOn environment with many payments for the same client when the popup is opened it takes long to fill the data.
Steps To Reproduce-Open the add detail button on an environment with big amount of data.
Proposed SolutionAttached a posible solution.
With the patch a flush is not executed before calling the stored procedure.
TagsPerformance
Attached Filesdiff file icon addDetails.flush.diff [^] (752 bytes) 2015-02-18 18:02 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0074874)
hgbot (developer)
2015-02-24 18:08

 Repository: erp/devel/pi
Changeset: aba0f61a4140b1267ac9ca783731a672ad5d71b6
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Tue Feb 24 12:38:51 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/aba0f61a4140b1267ac9ca783731a672ad5d71b6 [^]

Fixes bug 28987: Add payment does not take long to load with lot of credit paym.

When opening Add Payment process definition it has to load the default values of the parameters of the process definition. One of this parameters is the credit of the business partner of the payment. The method that calculates this credit calls the method seqnumberpaymentstatus that uses CallStoredProcedure.getInstance().call to call the database function. This method is executed for each credit payment of the customer and on each execution an unnecessary flush was being done, so with lots of credit payments the impact on performance was huge.
A false flag has been added to call process to not to do flush on each execution of the process, so the performance problem is avoided.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
---
(0074939)
hudsonbot (developer)
2015-02-25 21:22

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/96ba7b028cb7 [^]
Maturity status: Test
(0074958)
Sandrahuguet (developer)
2015-02-26 12:04

 Verified

- Issue History
Date Modified Username Field Change
2015-02-18 18:02 egoitz New Issue
2015-02-18 18:02 egoitz Assigned To => umartirena
2015-02-18 18:02 egoitz File Added: addDetails.flush.diff
2015-02-18 18:02 egoitz Modules => Core
2015-02-18 18:02 egoitz Resolution time => 1425078000
2015-02-18 18:02 egoitz Triggers an Emergency Pack => No
2015-02-18 18:08 egoitz Tag Attached: Performance
2015-02-24 18:08 hgbot Checkin
2015-02-24 18:08 hgbot Note Added: 0074874
2015-02-24 18:08 hgbot Status new => resolved
2015-02-24 18:08 hgbot Resolution open => fixed
2015-02-24 18:08 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/aba0f61a4140b1267ac9ca783731a672ad5d71b6 [^]
2015-02-25 21:22 hudsonbot Checkin
2015-02-25 21:22 hudsonbot Note Added: 0074939
2015-02-26 12:04 Sandrahuguet Review Assigned To => Sandrahuguet
2015-02-26 12:04 Sandrahuguet Note Added: 0074958
2015-02-26 12:04 Sandrahuguet Status resolved => closed
2015-02-26 12:04 Sandrahuguet Fixed in Version => 3.0PR15Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker