Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028987Openbravo ERP09. Financial managementpublic2015-02-18 18:022015-02-26 12:04
Reporteregoitz 
Assigned Toumartirena 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q2Fixed in Version3.0PR15Q2 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket34225
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028987: Under some circustancde the Add details button takes long to be loaded
DescriptionOn environment with many payments for the same client when the popup is opened it takes long to fill the data.
Steps To Reproduce-Open the add detail button on an environment with big amount of data.
Proposed SolutionAttached a posible solution.
With the patch a flush is not executed before calling the stored procedure.
Additional Information
TagsPerformance
Relationships
Attached Filesdiff addDetails.flush.diff (752) 2015-02-18 18:02
https://issues.openbravo.com/file_download.php?file_id=7804&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-02-18 18:02egoitzNew Issue
2015-02-18 18:02egoitzAssigned To => umartirena
2015-02-18 18:02egoitzFile Added: addDetails.flush.diff
2015-02-18 18:02egoitzOBNetwork customer => Yes
2015-02-18 18:02egoitzModules => Core
2015-02-18 18:02egoitzSupport ticket => 34225
2015-02-18 18:02egoitzResolution time => 1425078000
2015-02-18 18:02egoitzTriggers an Emergency Pack => No
2015-02-18 18:08egoitzTag Attached: Performance
2015-02-24 18:08hgbotCheckin
2015-02-24 18:08hgbotNote Added: 0074874
2015-02-24 18:08hgbotStatusnew => resolved
2015-02-24 18:08hgbotResolutionopen => fixed
2015-02-24 18:08hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/aba0f61a4140b1267ac9ca783731a672ad5d71b6 [^]
2015-02-25 21:22hudsonbotCheckin
2015-02-25 21:22hudsonbotNote Added: 0074939
2015-02-26 12:04SandrahuguetReview Assigned To => Sandrahuguet
2015-02-26 12:04SandrahuguetNote Added: 0074958
2015-02-26 12:04SandrahuguetStatusresolved => closed
2015-02-26 12:04SandrahuguetFixed in Version => 3.0PR15Q2

Notes
(0074874)
hgbot   
2015-02-24 18:08   
Repository: erp/devel/pi
Changeset: aba0f61a4140b1267ac9ca783731a672ad5d71b6
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Tue Feb 24 12:38:51 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/aba0f61a4140b1267ac9ca783731a672ad5d71b6 [^]

Fixes bug 28987: Add payment does not take long to load with lot of credit paym.

When opening Add Payment process definition it has to load the default values of the parameters of the process definition. One of this parameters is the credit of the business partner of the payment. The method that calculates this credit calls the method seqnumberpaymentstatus that uses CallStoredProcedure.getInstance().call to call the database function. This method is executed for each credit payment of the customer and on each execution an unnecessary flush was being done, so with lots of credit payments the impact on performance was huge.
A false flag has been added to call process to not to do flush on each execution of the process, so the performance problem is avoided.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
---
(0074939)
hudsonbot   
2015-02-25 21:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/96ba7b028cb7 [^]
Maturity status: Test
(0074958)
Sandrahuguet   
2015-02-26 12:04   
Verified