Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0028843
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2015-02-03 12:492015-02-09 21:48
ReporterSandrahuguetView Statuspublic 
Assigned ToAugustoMauch 
PriorityimmediateResolutionfixedFixed in Version3.0PR15Q2
StatusclosedFix in branchFixed in SCM revision3ae59cee1ac2
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionCommunity ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0028843: Characteristic selector not show all values

DescriptionCharacteristic selector not show all values when the product characteristics have been updated with one value.
Steps To Reproduce-Apply the provided patch. It adds a tree field to the Characteristics tab of the Product window.
As F&B International Group Admin
-Go to Product characteristics window:
   create a new register for orgnization: *
   Variant: No
   name: TEST
-Go to values tab:
     create two registers:
       1- name: one
       2.-name: two
-Go to Product window:
   create a new register
   orgnization: *
   is generic: yes
-Go to Characteristics tab:
    open the drop down of the tree field.
    select the value "one"
    click on the drop down of M_Ch_Value selector.
    realise that "two" value does not appear any more.
TagsNo tags attached.
Attached Filesdiff file icon test28843.diff [^] (8,098 bytes) 2015-02-05 12:54 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 00259063.0PR14Q2 closedAugustoMauch Tree Extension Project 
related to defect 0028872 closedAugustoMauch Opening the popup of a tree item with a partial filter does not return any results 
related to defect 0028887 closedplatform Magnifying glass button in characteristic selector shows no results 
blocks defect 0028836 closedSandrahuguet Update Characteristics is not working fine 

-  Notes
(0074226)
hgbot (developer)
2015-02-05 12:57

 Repository: erp/devel/pi
Changeset: 3ae59cee1ac2babfe381b7b6d50f738c3bc69007
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Feb 05 12:33:34 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3ae59cee1ac2babfe381b7b6d50f738c3bc69007 [^]

Fixes issue 28843: Characteristic selector does not filter by the selected item

The problem was that if a value was selected in a form item that uses the tree references, when the user opened the drop down the values were filtered using the selected value. This is not the correct behaviour, if the user opens manually the dropdown all the values that comply with the where clause should be shown.

This happened because each time the picklist was shown, its values were retrieved filtering the selected value. Now if the user is manually opening the tree item, the result records will not be filtered by the selected record.

Also a couple of changes have been done in the getCriteriaFromTreeItem function:
- For the criteria the entered value (the text currently shown in the tree item) is used, instead of the selected value.
- A not-null check has been added for the valueMap of the item before trying to use it.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-tree.js
---
(0074258)
hudsonbot (developer)
2015-02-06 15:42

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/354f8004acc8 [^]
Maturity status: Test
(0074266)
alostale (manager)
2015-02-09 09:18

 code reviewed:
-According to JavaScript coding conventions [1] should use single quotes [2]

Tested

Closing though small code style issue

[1] http://wiki.openbravo.com/wiki/JavaScript_Coding_Conventions#Single_Quotes [^]
[2] https://code.openbravo.com/erp/devel/pi/rev/3ae59cee1ac2babfe381b7b6d50f738c3bc69007#l1.64 [^]
(0074270)
hgbot (developer)
2015-02-09 09:25

 Repository: erp/devel/pi
Changeset: 5461e9cb19dd891040bb3b0e8f2b2f901df165c3
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Feb 09 09:24:32 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5461e9cb19dd891040bb3b0e8f2b2f901df165c3 [^]

Related with issue 28843: Replaces double quotes with single quotes

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-tree.js
---
(0074303)
hudsonbot (developer)
2015-02-09 21:48

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d68c131a3f59 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-02-03 12:49 Sandrahuguet New Issue
2015-02-03 12:49 Sandrahuguet Assigned To => AugustoMauch
2015-02-03 12:49 Sandrahuguet Modules => Core
2015-02-03 12:49 Sandrahuguet Triggers an Emergency Pack => No
2015-02-03 12:50 Sandrahuguet Relationship added blocks 0028836
2015-02-03 12:50 Sandrahuguet Priority urgent => immediate
2015-02-04 18:05 AugustoMauch Relationship added related to 0025906
2015-02-05 12:20 AugustoMauch Issue Monitored: alostale
2015-02-05 12:20 AugustoMauch Review Assigned To => alostale
2015-02-05 12:54 AugustoMauch File Added: test28843.diff
2015-02-05 12:55 AugustoMauch Steps to Reproduce Updated View Revisions
2015-02-05 12:57 hgbot Checkin
2015-02-05 12:57 hgbot Note Added: 0074226
2015-02-05 12:57 hgbot Status new => resolved
2015-02-05 12:57 hgbot Resolution open => fixed
2015-02-05 12:57 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3ae59cee1ac2babfe381b7b6d50f738c3bc69007 [^]
2015-02-05 13:19 AugustoMauch Relationship added related to 0028872
2015-02-06 12:30 Sandrahuguet Relationship added related to 0028887
2015-02-06 15:42 hudsonbot Checkin
2015-02-06 15:42 hudsonbot Note Added: 0074258
2015-02-09 09:18 alostale Note Added: 0074266
2015-02-09 09:18 alostale Status resolved => closed
2015-02-09 09:18 alostale Fixed in Version => 3.0PR15Q2
2015-02-09 09:25 hgbot Checkin
2015-02-09 09:25 hgbot Note Added: 0074270
2015-02-09 21:48 hudsonbot Checkin
2015-02-09 21:48 hudsonbot Note Added: 0074303

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker