Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028843Openbravo ERPA. Platformpublic2015-02-03 12:492015-02-09 21:48
ReporterSandrahuguet 
Assigned ToAugustoMauch 
PriorityimmediateSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in Version3.0PR15Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028843: Characteristic selector not show all values
DescriptionCharacteristic selector not show all values when the product characteristics have been updated with one value.
Steps To Reproduce-Apply the provided patch. It adds a tree field to the Characteristics tab of the Product window.
As F&B International Group Admin
-Go to Product characteristics window:
   create a new register for orgnization: *
   Variant: No
   name: TEST
-Go to values tab:
     create two registers:
       1- name: one
       2.-name: two
-Go to Product window:
   create a new register
   orgnization: *
   is generic: yes
-Go to Characteristics tab:
    open the drop down of the tree field.
    select the value "one"
    click on the drop down of M_Ch_Value selector.
    realise that "two" value does not appear any more.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 00259063.0PR14Q2 closed AugustoMauch Tree Extension Project 
related to defect 0028872 closed AugustoMauch Opening the popup of a tree item with a partial filter does not return any results 
related to defect 0028887 closed platform Magnifying glass button in characteristic selector shows no results 
blocks defect 0028836 closed Sandrahuguet Update Characteristics is not working fine 
Attached Filesdiff test28843.diff (8,098) 2015-02-05 12:54
https://issues.openbravo.com/file_download.php?file_id=7771&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-02-03 12:49SandrahuguetNew Issue
2015-02-03 12:49SandrahuguetAssigned To => AugustoMauch
2015-02-03 12:49SandrahuguetModules => Core
2015-02-03 12:49SandrahuguetTriggers an Emergency Pack => No
2015-02-03 12:50SandrahuguetRelationship addedblocks 0028836
2015-02-03 12:50SandrahuguetPriorityurgent => immediate
2015-02-04 18:05AugustoMauchRelationship addedrelated to 0025906
2015-02-05 12:20AugustoMauchIssue Monitored: alostale
2015-02-05 12:20AugustoMauchReview Assigned To => alostale
2015-02-05 12:54AugustoMauchFile Added: test28843.diff
2015-02-05 12:55AugustoMauchSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7626#r7626
2015-02-05 12:57hgbotCheckin
2015-02-05 12:57hgbotNote Added: 0074226
2015-02-05 12:57hgbotStatusnew => resolved
2015-02-05 12:57hgbotResolutionopen => fixed
2015-02-05 12:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3ae59cee1ac2babfe381b7b6d50f738c3bc69007 [^]
2015-02-05 13:19AugustoMauchRelationship addedrelated to 0028872
2015-02-06 12:30SandrahuguetRelationship addedrelated to 0028887
2015-02-06 15:42hudsonbotCheckin
2015-02-06 15:42hudsonbotNote Added: 0074258
2015-02-09 09:18alostaleNote Added: 0074266
2015-02-09 09:18alostaleStatusresolved => closed
2015-02-09 09:18alostaleFixed in Version => 3.0PR15Q2
2015-02-09 09:25hgbotCheckin
2015-02-09 09:25hgbotNote Added: 0074270
2015-02-09 21:48hudsonbotCheckin
2015-02-09 21:48hudsonbotNote Added: 0074303

Notes
(0074226)
hgbot   
2015-02-05 12:57   
Repository: erp/devel/pi
Changeset: 3ae59cee1ac2babfe381b7b6d50f738c3bc69007
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Feb 05 12:33:34 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3ae59cee1ac2babfe381b7b6d50f738c3bc69007 [^]

Fixes issue 28843: Characteristic selector does not filter by the selected item

The problem was that if a value was selected in a form item that uses the tree references, when the user opened the drop down the values were filtered using the selected value. This is not the correct behaviour, if the user opens manually the dropdown all the values that comply with the where clause should be shown.

This happened because each time the picklist was shown, its values were retrieved filtering the selected value. Now if the user is manually opening the tree item, the result records will not be filtered by the selected record.

Also a couple of changes have been done in the getCriteriaFromTreeItem function:
- For the criteria the entered value (the text currently shown in the tree item) is used, instead of the selected value.
- A not-null check has been added for the valueMap of the item before trying to use it.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-tree.js
---
(0074258)
hudsonbot   
2015-02-06 15:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/354f8004acc8 [^]
Maturity status: Test
(0074266)
alostale   
2015-02-09 09:18   
code reviewed:
-According to JavaScript coding conventions [1] should use single quotes [2]

Tested

Closing though small code style issue

[1] http://wiki.openbravo.com/wiki/JavaScript_Coding_Conventions#Single_Quotes [^]
[2] https://code.openbravo.com/erp/devel/pi/rev/3ae59cee1ac2babfe381b7b6d50f738c3bc69007#l1.64 [^]
(0074270)
hgbot   
2015-02-09 09:25   
Repository: erp/devel/pi
Changeset: 5461e9cb19dd891040bb3b0e8f2b2f901df165c3
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Feb 09 09:24:32 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5461e9cb19dd891040bb3b0e8f2b2f901df165c3 [^]

Related with issue 28843: Replaces double quotes with single quotes

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-tree.js
---
(0074303)
hudsonbot   
2015-02-09 21:48   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d68c131a3f59 [^]
Maturity status: Test