Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0028668
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementmajoralways2015-01-18 23:172015-05-07 22:17
ReporterrjapoovaView Statuspublic 
Assigned Toeduardo_Argal 
PriorityimmediateResolutionfixedFixed in Versionpi
StatusclosedFix in branchFixed in SCM revision5e2441fc0b3c
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version3.0PR14Q4SCM revision 
Review Assigned Toumartirena
Web browserGoogle Chrome
ModulesCore
Regression levelProduction - Confirmed Stable
Regression date
Regression introduced in release3.0PR14Q4
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0028668: Pressing Cancel in Match Statement or in Process Reconciliation does not trigger a refresh

DescriptionIn the Financial Account transactions window you can start a reconciliation flow with the Match Statement window.

That window has two buttons: Done (complete the process) and Cancel (abandon the process).

Given that cancel does not return the system in its previous state and that transactions might have been created in the background (see issue 28667), when you Cancel, the system should refresh the screen otherwise the created transactions are not visible to the user.

The same applies to the Confirm Process Reconciliation window.

This is very confusing and a source of many errors.
Steps To ReproduceSee video:
https://drive.google.com/file/d/0B2uCUQlrOPvINlU3VUxNNnJpYVU/view?usp=sharing [^]
Proposed SolutionPlease notice that if issue 28667 is resolved, this issue is not relevant since cancelling will not result in any new transaction.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 00297263.0PR15Q2 closededuardo_Argal Pressing Cancel in Match Statement or in Process Reconciliation does not trigger a refresh 
depends on backport 00297273.0PR15Q1.4 closededuardo_Argal Pressing Cancel in Match Statement or in Process Reconciliation does not trigger a refresh 
caused by feature request 00293903.0PR14Q4 closedSandrahuguet Reconciliation refactor project 
related to design defect 0028669 closedTriage Omni OMS Language in Confim Process Reconciliation window is very confusing 
related to defect 0028667 closedTriage Omni OMS Cancelling a Match Statement flow does not fully return system to previous state 
causes defect 0029810 closedTriage Finance Match statement popup does not show cross button 

-  Notes
(0076891)
hgbot (developer)
2015-04-29 19:43

 Repository: erp/devel/pi
Changeset: 5e2441fc0b3cb7d3152a37b44de74d1150d0c84b
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Wed Apr 29 17:33:40 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5e2441fc0b3cb7d3152a37b44de74d1150d0c84b [^]

Fixes issue 28668: Pressing Cancel in Match Statement or in Process Reconciliation does not trigger a refresh.
Cancel button has been removed as it was considered confusing. Now there are two buttons, one for closing the window called 'OK', as it was before, and another one called 'Reconcile'.

Both triggers refresh. Messages have been added to improve user understanding on how the window works. New message to inform the user any change will be persisted. This message can be disabled once clear and will not popup again. Message to run algorithm as well improved.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_ELEMENT.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_REFERENCE.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_REF_LIST.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementActionHandler.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/UnMatchTransactionActionHandler.java
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-matchStatement.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
A modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadGetPreferenceActionHandler.java
A modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadPreferenceActionHandler.java
---
(0076892)
umartirena (reporter)
2015-04-29 19:44

 Code Review + Testing OK
(0076924)
hgbot (developer)
2015-05-01 11:57

 Repository: erp/devel/pi
Changeset: 30de30c4d8093d060116dfc5d404b7377cd15ed6
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Fri May 01 11:56:45 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/30de30c4d8093d060116dfc5d404b7377cd15ed6 [^]

Related to issue 28668: Pressing Cancel in Match Statement or in Process Reconciliation does not trigger a refresh.
Refactor query to use named parameters to avoid this piece to be used as template for other developers as this could be a risky practice due to injections.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadGetPreferenceActionHandler.java
---
(0077188)
hudsonbot (developer)
2015-05-07 22:17

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test
(0077194)
hudsonbot (developer)
2015-05-07 22:17

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-01-18 23:17 rjapoova New Issue
2015-01-18 23:17 rjapoova Assigned To => dmiguelez
2015-01-18 23:17 rjapoova Web browser => Google Chrome
2015-01-18 23:17 rjapoova Modules => Core
2015-01-18 23:17 rjapoova Triggers an Emergency Pack => No
2015-04-24 19:00 dmitry_mezentsev Assigned To dmiguelez => Triage Finance
2015-04-24 19:00 dmitry_mezentsev Status new => acknowledged
2015-04-24 19:00 dmitry_mezentsev Web browser Google Chrome => Google Chrome
2015-04-24 19:00 dmitry_mezentsev Priority normal => immediate
2015-04-24 19:01 dmitry_mezentsev Relationship added caused by 0029390
2015-04-24 19:01 dmitry_mezentsev Web browser Google Chrome => Google Chrome
2015-04-24 19:01 dmitry_mezentsev Regression level => Production - Confirmed Stable
2015-04-24 19:01 dmitry_mezentsev Regression introduced in release => 3.0PR14Q4
2015-04-28 13:12 eduardo_Argal Status acknowledged => scheduled
2015-04-28 13:12 eduardo_Argal Assigned To Triage Finance => eduardo_Argal
2015-04-28 19:33 eduardo_Argal Status scheduled => feedback
2015-04-28 19:33 eduardo_Argal Status feedback => new
2015-04-28 19:33 eduardo_Argal Status new => scheduled
2015-04-29 19:43 hgbot Checkin
2015-04-29 19:43 hgbot Note Added: 0076891
2015-04-29 19:43 hgbot Status scheduled => resolved
2015-04-29 19:43 hgbot Resolution open => fixed
2015-04-29 19:43 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5e2441fc0b3cb7d3152a37b44de74d1150d0c84b [^]
2015-04-29 19:44 umartirena Review Assigned To => umartirena
2015-04-29 19:44 umartirena Note Added: 0076892
2015-04-29 19:44 umartirena Status resolved => closed
2015-04-29 19:44 umartirena Fixed in Version => pi
2015-04-29 20:28 dmitry_mezentsev Relationship added related to 0028669
2015-04-29 20:32 dmitry_mezentsev Relationship added related to 0028667
2015-05-01 11:57 hgbot Checkin
2015-05-01 11:57 hgbot Note Added: 0076924
2015-05-07 13:06 alostale Relationship added causes 0029810
2015-05-07 22:17 hudsonbot Checkin
2015-05-07 22:17 hudsonbot Note Added: 0077188
2015-05-07 22:17 hudsonbot Checkin
2015-05-07 22:17 hudsonbot Note Added: 0077194

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker